The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
GDGT-3323, GDGT-3344: Explain content diagnostics scans and center Type column (#84018)
Stas Gavrylovc1b7924a2abe
diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/DiagnosticsHeader/DiagnosticsHeader.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/DiagnosticsHeader/DiagnosticsHeader.tsxindex 13d0c283460..ce1617a5262 100644--- a/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/DiagnosticsHeader/DiagnosticsHeader.tsx+++ b/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/DiagnosticsHeader/DiagnosticsHeader.tsx@@ -6,7 +6,7 @@ import {PillTabNavigation,} from "metabase/common/components/PillTabNavigation";import { MonitorHeaderTitle } from "metabase/monitor/components/MonitorHeaderTitle";-import { Stack } from "metabase/ui";+import { Group, Icon, Stack, Text, Tooltip, UnstyledButton } from "metabase/ui";import * as Urls from "metabase/urls";export const DiagnosticsHeader = memo(function DiagnosticsHeader() {@@ -49,7 +49,41 @@ export const DiagnosticsHeader = memo(function DiagnosticsHeader() {return (<Stack gap="xl"><MonitorHeaderTitle>{t`Content diagnostics`}</MonitorHeaderTitle>- <PillTabNavigation tabs={tabs} />+ <Group justify="space-between" gap="md" wrap="nowrap">+ <PillTabNavigation tabs={tabs} />+ <DiagnosticsInfo />+ </Group></Stack>);});++function DiagnosticsInfo() {+ return (+ <Tooltip+ label={+ <Stack gap="sm">+ <Text c="inherit" fz="inherit" lh="inherit">+ {t`Content is scanned once a day at 4 AM server time to avoid slowing down your instance.`}+ </Text>+ <Text c="inherit" fz="inherit" lh="inherit">+ {t`Scans run in the background, so it can take a while before new findings show up.`}+ </Text>+ <Text c="inherit" fz="inherit" lh="inherit">+ {t`Dismiss a finding once you've fixed it. If the problem is still there, the finding will come back after the next scan.`}+ </Text>+ </Stack>+ }+ multiline+ maw="20rem"+ position="bottom-end"+ >+ <UnstyledButton+ aria-label={t`How content diagnostics works`}+ flex="none"+ style={{ lineHeight: 0 }}+ >+ <Icon name="info" c="text-secondary" />+ </UnstyledButton>+ </Tooltip>+ );+}diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/common-columns.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/common-columns.tsxindex 4b55b3290fd..e8d3b0b69ff 100644--- a/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/common-columns.tsx+++ b/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/common-columns.tsx@@ -5,7 +5,9 @@ import type { useGetIcon } from "metabase/hooks/use-icon";import {Ellipsified,FixedSizeIcon,+ Flex,Group,+ SortableHeaderPill,Text,type TreeTableColumnDef,} from "metabase/ui";@@ -13,7 +15,7 @@ import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";import type { ContentDiagnosticsBaseFinding } from "metabase-types/api";import { DiagnosticsEntityIcon } from "./DiagnosticsEntityIcon";-import { TOOLTIP_OPEN_DELAY_MS } from "./constants";+import { TOOLTIP_OPEN_DELAY_MS, TYPE_COLUMN_MIN_WIDTH } from "./constants";import {getCollectionName,getEntityName,@@ -46,10 +48,18 @@ export function getCommonColumns<T extends ContentDiagnosticsBaseFinding>(},entityType: {id: "entity-type",- header: t`Type`,+ header: ({ column }) => (+ <Flex justify="center" flex={1}>+ <SortableHeaderPill+ name={t`Type`}+ sort={column.getIsSorted() || undefined}+ />+ </Flex>+ ),enableSorting: true,sortDescFirst: false,width: "auto",+ minWidth: TYPE_COLUMN_MIN_WIDTH,accessorFn: (finding) => getEntityTypeLabel(finding),cell: ({ row }) => (<DiagnosticsEntityIcondiff --git a/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/constants.ts b/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/constants.tsindex 3ac528c7491..a43b06fd2f4 100644--- a/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/constants.ts+++ b/enterprise/frontend/src/metabase-enterprise/monitor/content-diagnostics/components/constants.ts@@ -1,2 +1,3 @@export const DEFAULT_INCLUDE_PERSONAL_COLLECTIONS = true;export const TOOLTIP_OPEN_DELAY_MS = 300;+export const TYPE_COLUMN_MIN_WIDTH = 90;