The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
chore: convert ObjectDetail viz to typescript (#70425)
Uladzimir Havenchykc28beea34419
diff --git a/frontend/src/metabase/visualizations/types/visualization.ts b/frontend/src/metabase/visualizations/types/visualization.tsindex 782be8f0f61..1dd5ff0054b 100644--- a/frontend/src/metabase/visualizations/types/visualization.ts+++ b/frontend/src/metabase/visualizations/types/visualization.ts@@ -435,6 +435,7 @@ export type VisualizationSettingsDefinitions<color?: SingleSeriesSettingDefinition<Value, Props>;column?: DatasetColumnSettingDefinition<Value, Props>;column_settings?: DatasetColumnSettingDefinition<Value, Props>;+ column_title?: DatasetColumnSettingDefinition<Value, Props>;currency?: DatasetColumnSettingDefinition<Value, Props>;currency_in_header?: DatasetColumnSettingDefinition<Value, Props>;currency_style?: DatasetColumnSettingDefinition<Value, Props>;diff --git a/frontend/src/metabase/visualizations/visualizations/ObjectDetail.jsx b/frontend/src/metabase/visualizations/visualizations/ObjectDetail.tsxsimilarity index 83%rename from frontend/src/metabase/visualizations/visualizations/ObjectDetail.jsxrename to frontend/src/metabase/visualizations/visualizations/ObjectDetail.tsxindex 27b30a9bfc5..9b8b31ee8cf 100644--- a/frontend/src/metabase/visualizations/visualizations/ObjectDetail.jsx+++ b/frontend/src/metabase/visualizations/visualizations/ObjectDetail.tsx@@ -11,7 +11,12 @@ import {getMinSize,} from "metabase/visualizations/shared/utils/sizes";-const ObjectDetailProperties = {+import type {+ VisualizationDefinition,+ VisualizationSettingsDefinitions,+} from "../types";++const ObjectDetailProperties: VisualizationDefinition = {getUiName() {return t`Detail`;},@@ -29,8 +34,8 @@ const ObjectDetailProperties = {...columnSettings({ hidden: true }),...tableColumnSettings({ isShowingDetailsOnlyColumns: true }),},- columnSettings: (column) => {- const settings = {+ columnSettings: () => {+ const settings: VisualizationSettingsDefinitions = {column_title: {title: t`Column title`,widget: "input",@@ -48,6 +53,7 @@ const ObjectDetailProperties = {return settings;},isSensible: () => true,+ checkRenderable: () => true,};const ObjectDetailWithProperties = Object.assign(