Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Closes EMB-816 misleading text for number of rows (#63561)

Sébastienc3461ab6467c
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_Default.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_Default.png
index d5e2a9f0c70..5f67aa5151b 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_Default.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_Default.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Default.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Default.png
index c4c25f3008e..9bf39b2165b 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Default.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Default.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Scroll.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Scroll.png
index 67fa1eb67b8..3244779ac18 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Scroll.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Scroll.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_Scroll.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_Scroll.png
index f83f0951216..a4d55be8a35 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_Scroll.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Dark_Theme_Scroll.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_Default.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_Default.png
index 43007538f34..17c22364248 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_Default.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_Default.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Default.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Default.png
index 3bcd75d3509..abc063c2dff 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Default.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Default.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Scroll.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Scroll.png
index fde9d76361b..b210349e2e3 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Scroll.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Scroll.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_Scroll.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_Scroll.png
index 10daa90f3f1..0e1f47ebcb8 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_Scroll.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Light_Theme_Scroll.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Default.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Default.png
index 3b5b08fa8c7..a4fe808cdb3 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Default.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Default.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Default.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Default.png
index 6fe8cf62149..367081f31b9 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Default.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Default.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Scroll.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Scroll.png
index 29ea746b28b..e16441012f8 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Scroll.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Scroll.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Scroll.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Scroll.png
index 84ec76d6a66..7b3afa24c5d 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Scroll.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Scroll.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png
index d4be1e2d9d8..95fab0b56cf 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png
index 339a06b5eae..360878e0e03 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png
index f745749b82b..9b79496c17b 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year_Dropdown.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year_Dropdown.png
index 229426534a6..fbaf34f5aef 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year_Dropdown.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year_Dropdown.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png
index 7d1a805742a..b452ac6d36d 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png
index 875ff7d218e..59ab8dfa7f6 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png
index 736c347ff9b..16a83ec341a 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
index 271de8bdb3f..5bd01e79ee8 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png
index 4bb5a504b23..28871580441 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_Single_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_Single_With_Value.png
index 8862757eb60..6079c23dfe6 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_Single_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_Single_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png
index 694a9ff0f59..cce6ba4efe3 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png
index bf93baae53d..28871580441 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png
index 89955c68213..b2ab97bf166 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text.png
index 9fde42c9796..90ce5dd686f 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text_With_Value.png
index 9fde42c9796..90ce5dd686f 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Unit_Of_Time.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Unit_Of_Time.png
index 28a68516ec1..4452a320415 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Unit_Of_Time.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Unit_Of_Time.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_All_Options.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_All_Options.png
index 33e8b863233..edca73f9cba 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_All_Options.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_All_Options.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Month_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Month_Year.png
index ab1a98a05f7..01c09b31b8f 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Month_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Month_Year.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year.png
index ce5de13d3b0..8243c85d9d5 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year_Dropdown.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year_Dropdown.png
index 66449774609..42cfbcb3534 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year_Dropdown.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year_Dropdown.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png
index d88549fda50..eeb1937c047 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png
index 021133dcef5..697d0af0e80 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Single.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Single.png
index 16a132d6b79..e50e3413383 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Single.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Single.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Number.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Number.png
index 0fa3aee6089..f3773386235 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Number.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Number.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png
index 3f23bd2fcbb..372fda54646 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_Single_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_Single_With_Value.png
index f6082a1d96b..621424a034b 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_Single_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_Single_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png
index 6409bd6c3ee..19c3db2ff67 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png
index 0441c3775c3..372fda54646 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png
index 6ab1f1de9cf..6b2316330c3 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text.png
index cea9b0546e8..6505f80aa35 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text_With_Value.png
index 2512834b512..6505f80aa35 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Unit_Of_Time.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Unit_Of_Time.png
index 1d61fc4c4b0..de322218182 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Unit_Of_Time.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Unit_Of_Time.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedQuestionView_Table_Light_Theme.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedQuestionView_Table_Light_Theme.png
index 2678a4d237d..ccc0b623a3b 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedQuestionView_Table_Light_Theme.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedQuestionView_Table_Light_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table.png b/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table.png
index 9ae680dc9b1..befe22e0e05 100644
Binary files a/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table.png and b/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table.png differ
diff --git a/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table_Embedding_Theme.png b/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table_Embedding_Theme.png
index 68ada308d8c..60f846a1765 100644
Binary files a/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table_Embedding_Theme.png and b/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table_Embedding_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table_Embedding_Theme_With_Sticky_Background_Color.png b/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table_Embedding_Theme_With_Sticky_Background_Color.png
index 46fa08d200b..599fa041d8d 100644
Binary files a/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table_Embedding_Theme_With_Sticky_Background_Color.png and b/.loki/reference/chrome_laptop_viz_Table_Dashboard_Table_Embedding_Theme_With_Sticky_Background_Color.png differ
diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-number-source.cy.spec.js b/e2e/test/scenarios/dashboard-filters/dashboard-filters-number-source.cy.spec.js
index 31143f31fc8..bff1b064f11 100644
--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-number-source.cy.spec.js
+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-number-source.cy.spec.js
@@ -163,7 +163,9 @@ describe("scenarios > dashboard > filters", { tags: "@slow" }, () => {
cy.findByText("225").click();
cy.button("Update filter").click();
});
- H.getDashboardCard().findByText("2,000 rows").should("be.visible");
+ H.getDashboardCard()
+ .findByText("Showing first 2,000 rows")
+ .should("be.visible");
});
it("should allow to use a card source with numeric columns and multiple values", () => {
diff --git a/e2e/test/scenarios/dashboard-filters/dashboard-filters-reset-clear.cy.spec.ts b/e2e/test/scenarios/dashboard-filters/dashboard-filters-reset-clear.cy.spec.ts
index bfbaf0a4f59..3e817e787d2 100644
--- a/e2e/test/scenarios/dashboard-filters/dashboard-filters-reset-clear.cy.spec.ts
+++ b/e2e/test/scenarios/dashboard-filters/dashboard-filters-reset-clear.cy.spec.ts
@@ -678,7 +678,7 @@ describe("scenarios > dashboard > filters > reset all filters", () => {
cy.signInAsAdmin();
});
- describe("resetting to empty value", () => {
+ describe("resetting to empty value", { tags: "@flaky" }, () => {
it("works across all tabs with 'auto-apply filters' on", () => {
createDashboardWithParameterInEachTab({
autoApplyFilters: true,
diff --git a/e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js b/e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js
index 786f4c02136..0c8ebd271e5 100644
--- a/e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js
+++ b/e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js
@@ -103,7 +103,7 @@ describe("issue 61013", () => {
H.getDashboardCards().should("have.length", 1);
H.getDashboardCard(0).within(() => {
cy.findByText("Orders question").should("be.visible");
- cy.findByText("2,000 rows").should("be.visible");
+ cy.findByText("Showing first 2,000 rows").should("be.visible");
});
cy.findByTestId("edit-bar")
@@ -115,7 +115,7 @@ describe("issue 61013", () => {
H.getDashboardCards().should("have.length", 1);
H.getDashboardCard(0).within(() => {
cy.findByText("Orders question").should("be.visible");
- cy.findByText("2,000 rows").should("be.visible");
+ cy.findByText("Showing first 2,000 rows").should("be.visible");
});
});
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
index baa81bea568..59945b8cf04 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
@@ -155,7 +155,7 @@ describe("scenarios > embedding > sdk iframe embedding", () => {
});
frame.within(() => {
- cy.findByText("2,000 Zeilen").should("exist");
+ cy.findByText("Zeige die ersten 2,000 Zeilen").should("exist");
});
});
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/theming.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/theming.cy.spec.ts
index 05c6f5fce8c..87a66cd7be0 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/theming.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/theming.cy.spec.ts
@@ -55,7 +55,7 @@ describe("scenarios > embedding > sdk iframe embedding > theming", () => {
DARK_THEME.colors.background,
);
- cy.findByText("2,000 rows").should(
+ cy.findByText("Showing first 2,000 rows").should(
"have.css",
"color",
DARK_THEME.colors["text-primary"],
@@ -128,7 +128,7 @@ describe("scenarios > embedding > sdk iframe embedding > theming", () => {
LIGHT_THEME.colors.brand,
);
- cy.findByText("2,000 rows").should(
+ cy.findByText("Showing first 2,000 rows").should(
"have.css",
"color",
LIGHT_THEME.colors["text-primary"],
@@ -160,7 +160,7 @@ describe("scenarios > embedding > sdk iframe embedding > theming", () => {
DARK_THEME.colors.brand,
);
- cy.findByText("2,000 rows").should(
+ cy.findByText("Showing first 2,000 rows").should(
"have.css",
"color",
DARK_THEME.colors["text-primary"],
@@ -192,7 +192,7 @@ describe("scenarios > embedding > sdk iframe embedding > theming", () => {
LIGHT_THEME.colors.brand,
);
- cy.findByText("2,000 rows").should(
+ cy.findByText("Showing first 2,000 rows").should(
"have.css",
"color",
LIGHT_THEME.colors["text-primary"],
diff --git a/e2e/test/scenarios/visualizations-tabular/table.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/table.cy.spec.js
index 6339f0c7e1f..967c1ded5bf 100644
--- a/e2e/test/scenarios/visualizations-tabular/table.cy.spec.js
+++ b/e2e/test/scenarios/visualizations-tabular/table.cy.spec.js
@@ -530,7 +530,7 @@ describe("scenarios > visualizations > table > dashboards context", () => {
.findByText(rowsRegex)
.should("not.exist");
- cy.get("@tableDashcard").findByText("2,000 rows");
+ cy.get("@tableDashcard").findByText("Showing first 2,000 rows");
// Enable pagination
H.editDashboard();
diff --git a/frontend/src/metabase/common/utils/format-row-count.ts b/frontend/src/metabase/common/utils/format-row-count.ts
new file mode 100644
index 00000000000..939c116cb64
--- /dev/null
+++ b/frontend/src/metabase/common/utils/format-row-count.ts
@@ -0,0 +1,11 @@
+import { msgid, ngettext } from "ttag";
+
+import type { NumberFormatter } from "../hooks/use-number-formatter";
+
+export const formatRowCount = (
+ count: number,
+ formatNumber: NumberFormatter,
+) => {
+ const countString = formatNumber(count);
+ return ngettext(msgid`${countString} row`, `${countString} rows`, count);
+};
diff --git a/frontend/src/metabase/common/utils/get-row-count-message.ts b/frontend/src/metabase/common/utils/get-row-count-message.ts
new file mode 100644
index 00000000000..3f52c16e860
--- /dev/null
+++ b/frontend/src/metabase/common/utils/get-row-count-message.ts
@@ -0,0 +1,20 @@
+import { t } from "ttag";
+
+import { HARD_ROW_LIMIT } from "metabase-lib/v1/queries/utils";
+
+import type { NumberFormatter } from "../hooks/use-number-formatter";
+
+import { formatRowCount } from "./format-row-count";
+
+export function getRowCountMessage(
+ result: { data: { rows_truncated: number }; row_count: number },
+ formatNumber: NumberFormatter,
+) {
+ if (result.data.rows_truncated > 0) {
+ return t`Showing first ${formatRowCount(result.row_count, formatNumber)}`;
+ }
+ if (result.row_count === HARD_ROW_LIMIT) {
+ return t`Showing first ${formatRowCount(HARD_ROW_LIMIT, formatNumber)}`;
+ }
+ return t`Showing ${formatRowCount(result.row_count, formatNumber)}`;
+}
diff --git a/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.tsx b/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.tsx
index 8538495a74c..4931ed426d2 100644
--- a/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.tsx
+++ b/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.tsx
@@ -52,6 +52,7 @@ export interface DataGridProps<TData>
DataGridStylesProps {
emptyState?: React.ReactNode;
showRowsCount?: boolean;
+ rowsTruncated?: number;
isColumnReorderingDisabled?: boolean;
theme?: DataGridTheme;
zoomedRowIndex?: number;
@@ -80,6 +81,7 @@ export const DataGrid = function DataGrid<TData>({
onAddColumnClick,
onWheel,
tableFooterExtraButtons,
+ rowsTruncated,
}: DataGridProps<TData>) {
const {
virtualColumns,
@@ -396,6 +398,7 @@ export const DataGrid = function DataGrid<TData>({
table={table}
enablePagination={enablePagination}
showRowsCount={showRowsCount}
+ rowsTruncated={rowsTruncated}
style={styles?.footer}
className={classNames?.footer}
tableFooterExtraButtons={tableFooterExtraButtons}
diff --git a/frontend/src/metabase/data-grid/components/Footer/Footer.tsx b/frontend/src/metabase/data-grid/components/Footer/Footer.tsx
index 81d9cd98147..7de5d75776e 100644
--- a/frontend/src/metabase/data-grid/components/Footer/Footer.tsx
+++ b/frontend/src/metabase/data-grid/components/Footer/Footer.tsx
@@ -3,6 +3,7 @@ import cx from "classnames";
import { msgid, ngettext } from "ttag";
import { useNumberFormatter } from "metabase/common/hooks/use-number-formatter";
+import { getRowCountMessage } from "metabase/common/utils/get-row-count-message";
import { FOOTER_HEIGHT } from "metabase/data-grid/constants";
import { PaginationFooter } from "metabase/visualizations/components/PaginationFooter/PaginationFooter";
@@ -12,6 +13,7 @@ export interface FooterProps<TData> {
table: Table<TData>;
enablePagination?: boolean;
showRowsCount?: boolean;
+ rowsTruncated?: number;
style?: React.CSSProperties;
className?: string;
tableFooterExtraButtons?: React.ReactNode;
@@ -24,6 +26,7 @@ export const Footer = <TData,>({
className,
style,
tableFooterExtraButtons,
+ rowsTruncated,
}: FooterProps<TData>) => {
const formatNumber = useNumberFormatter();
const wrapperAttributes = {
@@ -58,11 +61,19 @@ export const Footer = <TData,>({
<div {...wrapperAttributes}>
{tableFooterExtraButtons}
<span className={S.rowsCount}>
- {ngettext(
- msgid`${formatNumber(total)} row`,
- `${formatNumber(total)} rows`,
- total,
- )}
+ {rowsTruncated !== undefined
+ ? getRowCountMessage(
+ {
+ data: { rows_truncated: rowsTruncated ?? 0 },
+ row_count: total,
+ },
+ formatNumber,
+ )
+ : ngettext(
+ msgid`${formatNumber(total)} row`,
+ `${formatNumber(total)} rows`,
+ total,
+ )}
</span>
</div>
);
diff --git a/frontend/src/metabase/lib/data_grid.js b/frontend/src/metabase/lib/data_grid.js
index 4733ded20f2..407add09357 100644
--- a/frontend/src/metabase/lib/data_grid.js
+++ b/frontend/src/metabase/lib/data_grid.js
@@ -179,6 +179,7 @@ export function pivot(data, normalCol, pivotCol, cellCol) {
columns: pivotValues,
rows: pivotedRows,
sourceRows,
+ rows_truncated: data.rows_truncated,
};
}
diff --git a/frontend/src/metabase/query_builder/components/view/QuestionRowCount/QuestionRowCount.tsx b/frontend/src/metabase/query_builder/components/view/QuestionRowCount/QuestionRowCount.tsx
index 4fee2493d11..ddc51ca694c 100644
--- a/frontend/src/metabase/query_builder/components/view/QuestionRowCount/QuestionRowCount.tsx
+++ b/frontend/src/metabase/query_builder/components/view/QuestionRowCount/QuestionRowCount.tsx
@@ -1,6 +1,6 @@
import cx from "classnames";
import { useMemo } from "react";
-import { msgid, ngettext, t } from "ttag";
+import { t } from "ttag";
import _ from "underscore";
import PopoverWithTrigger from "metabase/common/components/PopoverWithTrigger";
@@ -8,6 +8,8 @@ import {
type NumberFormatter,
useNumberFormatter,
} from "metabase/common/hooks/use-number-formatter";
+import { formatRowCount } from "metabase/common/utils/format-row-count";
+import { getRowCountMessage } from "metabase/common/utils/get-row-count-message";
import CS from "metabase/css/core/index.css";
import Database from "metabase/entities/databases";
import { connect } from "metabase/lib/redux";
@@ -163,11 +165,6 @@ function RowCountLabel({
);
}
-const formatRowCount = (count: number, formatNumber: NumberFormatter) => {
- const countString = formatNumber(count);
- return ngettext(msgid`${countString} row`, `${countString} rows`, count);
-};
-
function getLimitMessage(
question: Question,
result: Dataset,
@@ -193,16 +190,6 @@ function getLimitMessage(
return t`Showing first ${formatRowCount(HARD_ROW_LIMIT, formatNumber)} rows`;
}
-function getRowCountMessage(result: Dataset, formatNumber: NumberFormatter) {
- if (result.data.rows_truncated > 0) {
- return t`Showing first ${formatRowCount(result.row_count, formatNumber)}`;
- }
- if (result.row_count === HARD_ROW_LIMIT) {
- return t`Showing first ${formatRowCount(HARD_ROW_LIMIT, formatNumber)} rows`;
- }
- return t`Showing ${formatRowCount(result.row_count, formatNumber)}`;
-}
-
function getDatabaseId(_state: State, { question }: OwnProps & StateProps) {
return question.databaseId();
}
diff --git a/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx b/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx
index 0ca72abbc16..d3cf6aa09ae 100644
--- a/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx
+++ b/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx
@@ -821,6 +821,7 @@ export const TableInteractiveInner = forwardRef(function TableInteractiveInner(
{...tableProps}
styles={dataGridStyles}
showRowsCount={isDashboard}
+ rowsTruncated={data.rows_truncated}
isColumnReorderingDisabled={isColumnReorderingDisabled}
emptyState={emptyState}
zoomedRowIndex={zoomedRowIndex}
diff --git a/frontend/src/metabase/visualizations/visualizations/Table/Table.tsx b/frontend/src/metabase/visualizations/visualizations/Table/Table.tsx
index 88ff21c10b3..4df69cfd9af 100644
--- a/frontend/src/metabase/visualizations/visualizations/Table/Table.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/Table/Table.tsx
@@ -60,7 +60,10 @@ interface TableProps extends VisualizationProps {
}
interface TableState {
- data: Pick<DatasetData, "cols" | "rows" | "results_timezone"> | null;
+ data: Pick<
+ DatasetData,
+ "cols" | "rows" | "results_timezone" | "rows_truncated"
+ > | null;
question: Question | null;
}
@@ -424,7 +427,7 @@ class Table extends Component<TableProps, TableState> {
question,
});
} else {
- const { cols, rows, results_timezone } = data;
+ const { cols, rows, results_timezone, rows_truncated } = data;
const columnSettings = settings["table.columns"] ?? [];
const columnIndexes = findColumnIndexesForColumnSettings(
cols,
@@ -442,6 +445,7 @@ class Table extends Component<TableProps, TableState> {
cols: columnIndexes.map((i) => cols[i]),
rows: rows.map((row) => columnIndexes.map((i) => row[i])),
results_timezone,
+ rows_truncated,
},
question,
});