Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Return 204 No Content from CSV append/replace endpoints (#74945)

Romeo Van Snickc3f9cac18fd0
diff --git a/src/metabase/warehouse_schema_rest/api/table.clj b/src/metabase/warehouse_schema_rest/api/table.clj
index eef94deec30..aad904f0d86 100644
--- a/src/metabase/warehouse_schema_rest/api/table.clj
+++ b/src/metabase/warehouse_schema_rest/api/table.clj
@@ -440,10 +440,8 @@
[:file (ms/InstanceOfClass java.io.File)]
[:action upload/update-action-schema]]]
(try
- (let [_result (upload/update-csv! options)]
- {:status 200
- ;; There is scope to return something more interesting.
- :body nil})
+ (upload/update-csv! options)
+ api/generic-204-no-content
(catch Throwable e
{:status (or (-> e ex-data :status-code)
500)
diff --git a/test/metabase/warehouse_schema_rest/api/table_test.clj b/test/metabase/warehouse_schema_rest/api/table_test.clj
index c1bb9948b96..cba6df592f8 100644
--- a/test/metabase/warehouse_schema_rest/api/table_test.clj
+++ b/test/metabase/warehouse_schema_rest/api/table_test.clj
@@ -1115,7 +1115,7 @@
(mt/with-empty-db
(testing "Happy path"
(upload-test/with-uploads-enabled!
- (is (= {:status 200, :body nil}
+ (is (= {:status 204, :body nil}
(update-csv-via-api! :metabase.upload/append)))))
(testing "Failure paths return an appropriate status code and a message in the body"
(upload-test/with-uploads-disabled!
@@ -1146,7 +1146,7 @@
(mt/with-empty-db
(testing "Happy path"
(upload-test/with-uploads-enabled!
- (is (= {:status 200, :body nil}
+ (is (= {:status 204, :body nil}
(update-csv-via-api! :metabase.upload/replace)))))
(testing "Failure paths return an appropriate status code and a message in the body"
(upload-test/with-uploads-disabled!