Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove unused types (#65834)

Fraserc461d1296c04
diff --git a/frontend/src/metabase-types/entities/index.ts b/frontend/src/metabase-types/entities/index.ts
index 9337056e18a..6b571608924 100644
--- a/frontend/src/metabase-types/entities/index.ts
+++ b/frontend/src/metabase-types/entities/index.ts
@@ -1,2 +1 @@
-export * from "./table";
export * from "./common";
diff --git a/frontend/src/metabase-types/entities/table.ts b/frontend/src/metabase-types/entities/table.ts
deleted file mode 100644
index 11096da77b9..00000000000
--- a/frontend/src/metabase-types/entities/table.ts
+++ /dev/null
@@ -1,5 +0,0 @@
-import type { Table } from "metabase-types/api";
-
-export interface TableEntity extends Table {
- updateProperty: (name: string, value: string | number | null) => void;
-}
diff --git a/frontend/src/metabase-types/forms/index.ts b/frontend/src/metabase-types/forms/index.ts
deleted file mode 100644
index 974ef36da32..00000000000
--- a/frontend/src/metabase-types/forms/index.ts
+++ /dev/null
@@ -1,123 +0,0 @@
-/**
- * @deprecated
- */
-export type FieldName = string;
-
-/**
- * @deprecated
- */
-export type DefaultFieldValue = unknown;
-
-/**
- * @deprecated
- */
-export type FieldValues = Record<FieldName, DefaultFieldValue>;
-
-/**
- * @deprecated
- */
-export type BaseFieldValues = {
- [field: string]: any;
-};
-
-type FieldValidateResultOK = undefined | null | false;
-type FieldValidateResultError = string;
-
-/**
- * @deprecated
- */
-export type Validator = (
- value: string,
-) => FieldValidateResultOK | FieldValidateResultError;
-
-// Extending Record type here as field definition's props
-// will be just spread to the final field widget
-// (e.g. autoFocus, placeholder)
-/**
- * @deprecated
- */
-export type BaseFieldDefinition = Record<string, unknown> & {
- name: string;
- type?: string;
- title?: string;
- description?: string;
- placeholder?: string;
- hidden?: boolean;
-
- info?: string;
- infoLabel?: string;
- infoLabelTooltip?: string;
-
- align?: "left" | "right";
- horizontal?: boolean;
- descriptionPosition?: "top" | "bottom";
- visibleIf?: Record<FieldName, unknown>;
-
- initial?: () => DefaultFieldValue;
- validate?: Validator;
- normalize?: (value: any) => DefaultFieldValue;
-};
-
-/**
- * @deprecated
- */
-export type StandardFormFieldDefinition = BaseFieldDefinition & {
- // If not is not provided, we're going to use default text input
- type?: string | (() => JSX.Element);
-};
-
-/**
- * @deprecated
- */
-export type CustomFormFieldDefinition = BaseFieldDefinition & {
- widget: () => JSX.Element;
-};
-
-/**
- * @deprecated
- */
-export type FormFieldDefinition =
- | StandardFormFieldDefinition
- | CustomFormFieldDefinition;
-
-/**
- * @deprecated
- */
-export type FormField<Values, Value = DefaultFieldValue> = {
- name: keyof Values;
- value: Value;
- error?: string;
- initialValue: Value;
-
- active: boolean;
- dirty: boolean;
- invalid: boolean;
- pristine: boolean;
- touched: boolean;
- valid: boolean;
- visited: boolean;
-
- onBlur: () => void;
- onFocus: () => void;
- onChange: (value: Value) => void;
-};
-
-/**
- * @deprecated
- */
-export type FormObject<Values> = {
- fields: FormFieldDefinition[] | ((values?: Values) => FormFieldDefinition[]);
-};
-
-/**
- * @deprecated
- */
-export type PopulatedFormObject<Values extends BaseFieldValues> = {
- fields: (values?: Values) => FormFieldDefinition[];
- fieldNames: (values?: Partial<Values>) => (keyof Values)[];
- hidden: (obj: unknown) => void;
- initial: (values?: Partial<Values>) => Values;
- normalize: (values: Values) => Values;
- validate: (obj: unknown, opts: { values: Values }) => void;
- disablePristineSubmit?: boolean;
-};
diff --git a/frontend/src/metabase-types/guards/date-time.ts b/frontend/src/metabase-types/guards/date-time.ts
index 8698a03e3f8..293e6bf9f02 100644
--- a/frontend/src/metabase-types/guards/date-time.ts
+++ b/frontend/src/metabase-types/guards/date-time.ts
@@ -1,20 +1,8 @@
-import type {
- DateTimeAbsoluteUnit,
- DateTimeRelativeUnit,
-} from "metabase-types/api";
-import {
- dateTimeAbsoluteUnits,
- dateTimeRelativeUnits,
-} from "metabase-types/api";
+import type { DateTimeAbsoluteUnit } from "metabase-types/api";
+import { dateTimeAbsoluteUnits } from "metabase-types/api";
export const isAbsoluteDateTimeUnit = (
value: unknown,
): value is DateTimeAbsoluteUnit => {
return dateTimeAbsoluteUnits.includes(value as DateTimeAbsoluteUnit);
};
-
-export const isRelativeDateTimeUnit = (
- value: unknown,
-): value is DateTimeAbsoluteUnit => {
- return dateTimeRelativeUnits.includes(value as DateTimeRelativeUnit);
-};
diff --git a/frontend/src/metabase-types/guards/forms.ts b/frontend/src/metabase-types/guards/forms.ts
deleted file mode 100644
index 73aa2c48e8d..00000000000
--- a/frontend/src/metabase-types/guards/forms.ts
+++ /dev/null
@@ -1,16 +0,0 @@
-import type {
- CustomFormFieldDefinition,
- FormFieldDefinition,
- StandardFormFieldDefinition,
-} from "metabase-types/forms";
-
-import { isReactComponent } from "./react";
-
-export function isCustomWidget(
- formField: FormFieldDefinition,
-): formField is CustomFormFieldDefinition {
- return (
- !(formField as StandardFormFieldDefinition).type &&
- isReactComponent((formField as CustomFormFieldDefinition).widget)
- );
-}
diff --git a/frontend/src/metabase-types/guards/index.ts b/frontend/src/metabase-types/guards/index.ts
index 055480ce520..196d0818197 100644
--- a/frontend/src/metabase-types/guards/index.ts
+++ b/frontend/src/metabase-types/guards/index.ts
@@ -3,6 +3,5 @@ export * from "./click-behavior";
export * from "./common";
export * from "./dom";
export * from "./settings";
-export * from "./forms";
export * from "./parameters";
export * from "./react";
diff --git a/frontend/src/metabase-types/guards/react.ts b/frontend/src/metabase-types/guards/react.ts
index ff77c21f155..b49375677e5 100644
--- a/frontend/src/metabase-types/guards/react.ts
+++ b/frontend/src/metabase-types/guards/react.ts
@@ -8,15 +8,3 @@ export function isReactDOMTypeElement(
): element is React.ReactElement {
return ReactIs.isElement(element) && typeof element.type === "string";
}
-
-export function isReactComponent(
- component: any,
-): component is React.FC | React.Component | React.ExoticComponent {
- return (
- typeof component === "function" ||
- // Checking for "Exotic" components such as ones returned by memo, forwardRef
- (typeof component === "object" &&
- "$$typeof" in component &&
- typeof component["$$typeof"] === "symbol")
- );
-}