Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix double vertical scrollbar in popovers with AccordionList (#74407)

Oleh Kc4939f2ad679
diff --git a/frontend/src/metabase/common/components/AccordionList/AccordionList.module.css b/frontend/src/metabase/common/components/AccordionList/AccordionList.module.css
index 9c4ab13b006..d452c8030c8 100644
--- a/frontend/src/metabase/common/components/AccordionList/AccordionList.module.css
+++ b/frontend/src/metabase/common/components/AccordionList/AccordionList.module.css
@@ -1,8 +1,11 @@
+:global(.mb-mantine-Popover-dropdown):has(> .accordionListRoot) {
+ display: flex;
+ flex-direction: column;
+}
+
.accordionListRoot {
outline: none;
overflow: auto;
- max-width: inherit;
- max-height: inherit;
}
.hasSearch {
diff --git a/frontend/src/metabase/querying/notebook/components/ClauseStep/ClausePopover.module.css b/frontend/src/metabase/querying/notebook/components/ClauseStep/ClausePopover.module.css
index 799e6ed8456..00d44b07045 100644
--- a/frontend/src/metabase/querying/notebook/components/ClauseStep/ClausePopover.module.css
+++ b/frontend/src/metabase/querying/notebook/components/ClauseStep/ClausePopover.module.css
@@ -12,10 +12,17 @@
* onto a child element instead.
*/
overflow: visible;
+ /* Reset box-sizing to content-box so when .dropdownContent inherits max-height, it
+ won't include border. Otherwise, it will make .dropdownContent overflow .dropdown
+ by 2px.
+ */
+ box-sizing: content-box;
}
.dropdownContent {
overflow: auto;
+ display: flex;
+ flex-direction: column;
max-width: inherit;
max-height: inherit;
}