The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
fix: documents charts rendering when resizing is sluggish (#68204)
Maksym Yakubychc5ff6bbbbdb3
diff --git a/e2e/support/test-visualization-data.ts b/e2e/support/test-visualization-data.tsnew file mode 100644index 00000000000..927caadec8c--- /dev/null+++ b/e2e/support/test-visualization-data.ts@@ -0,0 +1,374 @@+import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";+import type {+ NativeQuestionDetails,+ StructuredQuestionDetails,+} from "e2e/support/helpers/api";++const {+ PRODUCTS,+ PRODUCTS_ID,+ ORDERS,+ ORDERS_ID,+ PEOPLE_ID,+ ACCOUNTS_ID,+ ACCOUNTS,+} = SAMPLE_DATABASE;++export const ORDERS_COUNT_BY_CREATED_AT: StructuredQuestionDetails = {+ display: "line",+ name: "Orders by Created At (Month)",+ query: {+ "source-table": ORDERS_ID,+ aggregation: [["count"]],+ breakout: [["field", ORDERS.CREATED_AT, { "temporal-unit": "month" }]],+ },+ visualization_settings: {+ "graph.dimensions": ["CREATED_AT"],+ "graph.metrics": ["count"],+ },+};++export const ORDERS_COUNT_BY_PRODUCT_CATEGORY: StructuredQuestionDetails = {+ display: "bar",+ name: "Orders by Product Category",+ query: {+ "source-table": ORDERS_ID,+ aggregation: [["count"]],+ breakout: [+ ["field", PRODUCTS.CATEGORY, { "source-field": ORDERS.PRODUCT_ID }],+ ],+ },+ visualization_settings: {+ "graph.dimensions": ["CATEGORY"],+ "graph.metrics": ["count"],+ },+};++export const ACCOUNTS_COUNT_BY_COUNTRY: StructuredQuestionDetails = {+ display: "bar",+ name: "Accounts by Country",+ query: {+ "source-table": ACCOUNTS_ID,+ aggregation: [["count"]],+ breakout: [["field", ACCOUNTS.COUNTRY, null]],+ },+ visualization_settings: {+ "graph.dimensions": ["COUNTRY"],+ "graph.metrics": ["count"],+ },+};++export const ACCOUNTS_COUNT_BY_CREATED_AT: StructuredQuestionDetails = {+ display: "bar",+ name: "Accounts by Created At (Month)",+ query: {+ "source-table": ACCOUNTS_ID,+ aggregation: [["count"]],+ breakout: [["field", ACCOUNTS.CREATED_AT, { "temporal-unit": "month" }]],+ },+ visualization_settings: {+ "graph.dimensions": ["CREATED_AT"],+ "graph.metrics": ["count"],+ },+};++export const ORDERS_COUNT_BY_CREATED_AT_AND_PRODUCT_CATEGORY: StructuredQuestionDetails =+ {+ display: "line",+ name: "Orders by Created At (Month) & Category",+ query: {+ "source-table": ORDERS_ID,+ aggregation: [["count"]],+ breakout: [+ ["field", ORDERS.CREATED_AT, { "temporal-unit": "month" }],+ ["field", PRODUCTS.CATEGORY, { "source-field": ORDERS.PRODUCT_ID }],+ ],+ },+ visualization_settings: {+ "graph.dimensions": ["CREATED_AT", "CATEGORY"],+ "graph.metrics": ["count"],+ },+ };++export const PRODUCTS_COUNT_BY_CREATED_AT: StructuredQuestionDetails = {+ display: "bar",+ name: "Products by Created At (Month)",+ query: {+ "source-table": PRODUCTS_ID,+ aggregation: [["count"]],+ breakout: [["field", PRODUCTS.CREATED_AT, { "temporal-unit": "month" }]],+ },+ visualization_settings: {+ "graph.dimensions": ["CREATED_AT"],+ "graph.metrics": ["count"],+ },+};++export const PRODUCTS_COUNT_BY_CREATED_AT_AND_CATEGORY: StructuredQuestionDetails =+ {+ display: "bar",+ name: "Products by Created At (Month) and Category",+ query: {+ "source-table": PRODUCTS_ID,+ aggregation: [["count"]],+ breakout: [+ ["field", PRODUCTS.CREATED_AT, { "temporal-unit": "month" }],+ ["field", PRODUCTS.CATEGORY, null],+ ],+ },+ visualization_settings: {+ "graph.dimensions": ["CREATED_AT", "CATEGORY"],+ "graph.metrics": ["count"],+ },+ };++export const PRODUCTS_AVERAGE_BY_CREATED_AT: StructuredQuestionDetails = {+ display: "bar",+ name: "Products average by Created At (Month)",+ query: {+ "source-table": PRODUCTS_ID,+ aggregation: [["avg", ["field", PRODUCTS.PRICE, null]]],+ breakout: [["field", PRODUCTS.CREATED_AT, { "temporal-unit": "month" }]],+ },+ visualization_settings: {+ "graph.dimensions": ["CREATED_AT"],+ "graph.metrics": ["count"],+ },+};++export const PRODUCTS_COUNT_BY_CATEGORY: StructuredQuestionDetails = {+ display: "bar",+ name: "Products by Category",+ query: {+ "source-table": PRODUCTS_ID,+ aggregation: [["count"]],+ breakout: [["field", PRODUCTS.CATEGORY, null]],+ },+ visualization_settings: {+ "graph.dimensions": ["CATEGORY"],+ "graph.metrics": ["count"],+ },+};++export const PRODUCTS_AVERAGE_BY_CATEGORY: StructuredQuestionDetails = {+ display: "bar",+ name: "Products average by Category",+ query: {+ "source-table": PRODUCTS_ID,+ aggregation: [["avg", ["field", PRODUCTS.PRICE, null]]],+ breakout: [["field", PRODUCTS.CATEGORY, null]],+ },+ visualization_settings: {+ "graph.dimensions": ["CATEGORY"],+ "graph.metrics": ["avg"],+ },+};++export const PRODUCTS_COUNT_BY_CATEGORY_PIE: StructuredQuestionDetails = {+ ...PRODUCTS_COUNT_BY_CATEGORY,+ display: "pie",+ name: "Products by Category (Pie)",+};++export const SCALAR_CARD: Record<string, NativeQuestionDetails> = {+ LANDING_PAGE_VIEWS: {+ display: "scalar",+ name: "Landing Page",+ native: {+ query: 'SELECT 1000 as "views"',+ },+ },+ CHECKOUT_PAGE_VIEWS: {+ display: "scalar",+ name: "Checkout Page",+ native: {+ query: 'SELECT 600 as "views"',+ },+ },+ PAYMENT_DONE_PAGE_VIEWS: {+ display: "scalar",+ name: "Payment Done Page",+ native: {+ query: 'SELECT 100 as "views"',+ },+ },+};++export const PIVOT_TABLE_CARD: StructuredQuestionDetails = {+ name: "Pivot table",+ display: "pivot",+ query: {+ aggregation: [["count"], ["avg", ["field", ORDERS.QUANTITY, null]]],+ breakout: [+ ["field", ORDERS.CREATED_AT, { "temporal-unit": "year" }],+ ["field", PRODUCTS.CATEGORY, { "source-field": ORDERS.PRODUCT_ID }],+ ],+ "source-table": ORDERS_ID,+ },+};++export const STEP_COLUMN_CARD: NativeQuestionDetails = {+ name: "Step Column",+ display: "table",+ native: {+ query: `+ SELECT 'Landing page' AS "Step"+ UNION+ SELECT 'Checkout page' AS "Step"+ UNION+ SELECT 'Payment done page' AS "Step"+ `,+ },+};++export const VIEWS_COLUMN_CARD: NativeQuestionDetails = {+ name: "Views Column",+ display: "table",+ native: {+ query: `+ SELECT 1000 as "Views"+ UNION+ SELECT 600 as "Views"+ UNION+ SELECT 100 as "Views"+ `,+ },+};++export const ACCOUNTS_COUNT_BY_CREATED_AT_AREA: StructuredQuestionDetails = {+ ...ACCOUNTS_COUNT_BY_CREATED_AT,+ display: "area",+ name: "Accounts by Created At (Area)",+};++export const PRODUCTS_AVERAGE_BY_CATEGORY_ROW: StructuredQuestionDetails = {+ ...PRODUCTS_AVERAGE_BY_CATEGORY,+ display: "row",+ name: "Products avg by Category (Row)",+};++export const PRODUCTS_AVERAGE_BY_CATEGORY_WATERFALL: StructuredQuestionDetails =+ {+ ...PRODUCTS_AVERAGE_BY_CATEGORY,+ display: "waterfall",+ name: "Products avg by Category (Waterfall)",+ };++export const PRODUCTS_COUNT_SUM_BY_CREATED_AT_COMBO: StructuredQuestionDetails =+ {+ name: "Products count & sum by Created At (Combo)",+ display: "combo",+ query: {+ "source-table": PRODUCTS_ID,+ aggregation: [["count"], ["sum", ["field", PRODUCTS.PRICE, null]]],+ breakout: [["field", PRODUCTS.CREATED_AT, { "temporal-unit": "month" }]],+ },+ visualization_settings: {+ "graph.dimensions": ["CREATED_AT"],+ "graph.metrics": ["count", "sum"],+ "graph.show_values": true,+ },+ };++export const ORDERS_CREATED_AT_SCATTER: StructuredQuestionDetails = {+ name: "Orders by Created At (Scatter)",+ display: "scatter",+ query: {+ "source-table": ORDERS_ID,+ aggregation: [+ ["count"],+ [+ "distinct",+ ["field", PRODUCTS.ID, { "source-field": ORDERS.PRODUCT_ID }],+ ],+ ],+ breakout: [["field", ORDERS.CREATED_AT, { "temporal-unit": "month" }]],+ },+ visualization_settings: {+ "graph.dimensions": ["CREATED_AT"],+ "graph.metrics": ["count", "count_2"],+ },+};++export const PEOPLE_LOCATION_MAP: NativeQuestionDetails = {+ name: "People by Location (Map)",+ display: "map",+ native: {+ query:+ 'SELECT -80 AS "LNG", 40 AS "LAT" UNION ALL SELECT -120 AS "LNG", 40 AS "LAT"',+ },+ visualization_settings: {+ "map.type": "pin",+ "map.latitude_column": "LAT",+ "map.longitude_column": "LNG",+ },+};++export const PEOPLE_SOURCE_FUNNEL: StructuredQuestionDetails = {+ name: "People by Source (Funnel)",+ display: "funnel",+ query: {+ "source-table": PEOPLE_ID,+ aggregation: [["count"]],+ breakout: [["field", SAMPLE_DATABASE.PEOPLE.SOURCE, null]],+ },+ visualization_settings: {+ "funnel.dimension": "SOURCE",+ "funnel.metric": "count",+ },+};++export const SAMPLE_FLOW_SANKEY: NativeQuestionDetails = {+ name: "Sample Flow (Sankey)",+ display: "sankey",+ native: {+ query: `+ SELECT 'Social Media' AS source, 'Landing Page' AS target, 30000 AS metric+ UNION ALL+ SELECT 'Email Campaign', 'Landing Page', 20000+ UNION ALL+ SELECT 'Paid Search', 'Landing Page', 25000+ UNION ALL+ SELECT 'Landing Page', 'Signup Form', 60000+ UNION ALL+ SELECT 'Signup Form', 'Free Trial', 40000+ UNION ALL+ SELECT 'Signup Form', 'Abandoned Signup', 20000+ UNION ALL+ SELECT 'Free Trial', 'Onboarding', 30000+ UNION ALL+ SELECT 'Free Trial', 'Churned During Trial', 10000+ UNION ALL+ SELECT 'Onboarding', 'Active Users', 25000+ UNION ALL+ SELECT 'Onboarding', 'Churned After Onboarding', 5000+ UNION ALL+ SELECT 'Active Users', 'Paid Subscription', 20000+ UNION ALL+ SELECT 'Active Users', 'Cancelled Subscription', 5000+ `,+ },+ visualization_settings: {+ "graph.show_values": true,+ "graph.label_value_formatting": "compact",+ },+};++export const ORDERS_COUNT_PROGRESS: StructuredQuestionDetails = {+ name: "Orders count (Progress)",+ display: "progress",+ query: {+ "source-table": ORDERS_ID,+ aggregation: [["count"]],+ },+};++export const ORDERS_CREATED_AT_SMARTSCALAR: StructuredQuestionDetails = {+ name: "Orders by Created At (SmartScalar)",+ display: "smartscalar",+ query: {+ "source-table": ORDERS_ID,+ aggregation: [["count"]],+ breakout: [["field", ORDERS.CREATED_AT, { "temporal-unit": "month" }]],+ },+};diff --git a/e2e/test/scenarios/documents/documents.cy.spec.ts b/e2e/test/scenarios/documents/documents.cy.spec.tsindex 98d022a6941..b8b47d5acd8 100644--- a/e2e/test/scenarios/documents/documents.cy.spec.ts+++ b/e2e/test/scenarios/documents/documents.cy.spec.ts@@ -4,12 +4,19 @@ import {ORDERS_QUESTION_ID,READ_ONLY_PERSONAL_COLLECTION_ID,} from "e2e/support/cypress_sample_instance_data";+import type {+ NativeQuestionDetails,+ StructuredQuestionDetails,+} from "e2e/support/helpers/api";import {ACCOUNTS_COUNT_BY_CREATED_AT,ORDERS_COUNT_BY_PRODUCT_CATEGORY,+ PIVOT_TABLE_CARD,PRODUCTS_AVERAGE_BY_CATEGORY,PRODUCTS_COUNT_BY_CATEGORY_PIE,-} from "e2e/support/test-visualizer-data";+ SCALAR_CARD,+ STEP_COLUMN_CARD,+} from "e2e/support/test-visualization-data";import type { Document } from "metabase-types/api";const { H } = cy;@@ -548,6 +555,9 @@ describe("documents", () => {beforeEach(() => {H.createQuestion(PRODUCTS_AVERAGE_BY_CATEGORY);H.createQuestion(ACCOUNTS_COUNT_BY_CREATED_AT);+ H.createQuestion(PIVOT_TABLE_CARD);+ H.createNativeQuestion(STEP_COLUMN_CARD);+ H.createNativeQuestion(SCALAR_CARD.LANDING_PAGE_VIEWS);// Need to get this one to simulate recent activityH.createQuestion(PRODUCTS_COUNT_BY_CATEGORY_PIE).then(({ body: { id } }) => cy.request("POST", `/api/card/${id}/query`),@@ -810,6 +820,192 @@ describe("documents", () => {});});+ const PADDING_CARD = 1;+ type ChartCard =+ | (StructuredQuestionDetails & { name: string })+ | (NativeQuestionDetails & { name: string });+ type ChartSpec = {+ label: string;+ card: ChartCard;+ paddingX: number;+ selector: string;+ };++ const isNativeQuestion = (+ question: ChartCard,+ ): question is NativeQuestionDetails & { name: string } =>+ "native" in question;++ const createQuestionForCard = (+ question: ChartCard,+ nameOverride?: string,+ ) => {+ const details = nameOverride+ ? { ...question, name: nameOverride }+ : question;+ return isNativeQuestion(details)+ ? H.createNativeQuestion(details)+ : H.createQuestion(details);+ };++ const chartTypes: ChartSpec[] = [+ {+ label: "line",+ card: ACCOUNTS_COUNT_BY_CREATED_AT,+ paddingX: 16 + PADDING_CARD,+ selector: "[data-testid='chart-container'] > :first-child",+ },+ {+ label: "pie",+ card: PRODUCTS_COUNT_BY_CATEGORY_PIE,+ paddingX: 14 + PADDING_CARD,+ selector: "[data-testid='chart-with-legend']",+ },+ ];++ const assertChartMatchesContainerWidth = (+ cardName: string,+ paddingX: number,+ selector: string,+ ) => {+ H.getDocumentCard(cardName).then(($card) => {+ const cardWidth = $card.width()!;+ cy.wrap($card).find(selector).as("chart");++ cy.get("@chart")+ .should("exist")+ .then(($chart) => {+ const width = $chart.width()!;+ expect(width + paddingX * 2).to.equal(cardWidth);+ });+ });+ };++ it("keeps chart widths in sync during flex resize", () => {+ const cardIds: Record<string, { firstId: number; secondId: number }> =+ {};++ // Create all questions first+ chartTypes.forEach(({ label, card }) => {+ const secondCardName = `${card.name} (copy)`;++ cy.then(() =>+ createQuestionForCard(card).then(({ body }) => {+ cardIds[label] = { firstId: body.id, secondId: 0 };+ }),+ );++ cy.then(() =>+ createQuestionForCard(card, secondCardName).then(({ body }) => {+ cardIds[label].secondId = body.id;+ }),+ );+ });++ cy.then(() => {+ const content = chartTypes.map(({ label }) => ({+ type: "resizeNode",+ attrs: {+ height: 350,+ minHeight: 280,+ _id: `flex-${label}`,+ },+ content: [+ {+ type: "flexContainer",+ attrs: {+ _id: `flex-${label}-container`,+ columnWidths: [50, 50],+ },+ content: [+ {+ type: "cardEmbed",+ attrs: {+ id: cardIds[label].firstId,+ name: null,+ _id: `flex-${label}-card-1`,+ },+ },+ {+ type: "cardEmbed",+ attrs: {+ id: cardIds[label].secondId,+ name: null,+ _id: `flex-${label}-card-2`,+ },+ },+ ],+ },+ ],+ }));++ return H.createDocument({+ name: "Flex chart width document",+ document: {+ type: "doc",+ content,+ },+ collection_id: null,+ idAlias: "flexDocumentId",+ });+ });++ cy.intercept("POST", "/api/card/*/query").as("cardQuery");++ H.visitDocument("@flexDocumentId");++ // Wait for all cards to load (16 chart types × 2 cards each = 32 queries)+ for (let i = 0; i < chartTypes.length * 2; i++) {+ cy.wait("@cardQuery", { timeout: 15000 });+ }++ chartTypes.forEach(({ card, paddingX, selector }) => {+ const firstCardName = card.name;+ const secondCardName = `${card.name} (copy)`;++ const firstCardChart =+ H.getDocumentCard(firstCardName).find(selector);+ const secondCardChart =+ H.getDocumentCard(secondCardName).find(selector);++ firstCardChart.should("exist");+ secondCardChart.should("exist");++ const flexContainer = H.getFlexContainerForCard(firstCardName);+ const handles = H.getResizeHandlesForFlexContianer(flexContainer);++ handles.eq(0).then(($handle) => {+ cy.wrap($handle).realMouseDown({+ button: "left",+ position: "center",+ });++ const steps = [10, 40, 60, -100, -10, -40, -60];+ steps.forEach((deltaX) => {+ cy.wrap($handle).realMouseMove(deltaX, 0, {+ position: "center",+ });++ assertChartMatchesContainerWidth(+ firstCardName,+ paddingX,+ selector,+ );+ assertChartMatchesContainerWidth(+ secondCardName,+ paddingX,+ selector,+ );+ });++ cy.wrap($handle).realMouseUp({+ button: "left",+ position: "center",+ });+ });+ });+ });+it("should copy an added card on save", () => {cy.intercept({method: "PUT",diff --git a/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.tsx b/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.tsxindex 09f0e1c682a..05a5d60542f 100644--- a/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.tsx+++ b/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.tsx@@ -7,7 +7,8 @@ import type {MutableRefObject,PropsWithoutRef,} from "react";-import React, { Component, createRef } from "react";+import React, { Component, createContext, createRef } from "react";+import { flushSync } from "react-dom";import _ from "underscore";import CS from "metabase/css/core/index.css";@@ -17,12 +18,17 @@ import resizeObserver from "metabase/lib/resize-observer";const WAIT_TIME = delay(300);+export const ExplicitSizeRefreshModeContext = createContext<+ RefreshMode | undefined+>(undefined);+const REFRESH_MODE = {throttle: (fn: () => void) => _.throttle(fn, WAIT_TIME),debounce: (fn: () => void) => debounce(fn, WAIT_TIME),debounceLeading: (fn: () => void) =>debounce(fn, WAIT_TIME, { leading: true }),none: (fn: () => void) => fn,+ layout: (fn: () => void) => () => flushSync(fn),};export type RefreshMode = keyof typeof REFRESH_MODE;@@ -61,6 +67,8 @@ export function ExplicitSize<T>({class WrappedComponent extends Component<T & InnerProps> {static displayName = `ExplicitSize[${displayName}]`;+ static contextType = ExplicitSizeRefreshModeContext;+state: ExplicitSizeState = {width: null,height: null,@@ -134,13 +142,22 @@ export function ExplicitSize<T>({}_getRefreshMode = () => {- if (isCypressActive || this._printMediaQuery?.matches) {+ if (this.context) {+ return this.context as RefreshMode;+ }++ const calculatedRefreshMode =+ typeof refreshMode === "function"+ ? refreshMode(this.props)+ : refreshMode;+ if (+ calculatedRefreshMode !== "layout" &&+ (isCypressActive || this._printMediaQuery?.matches)+ ) {return "none";- } else if (typeof refreshMode === "function") {- return refreshMode(this.props);- } else {- return refreshMode;}++ return calculatedRefreshMode;};_updateRefreshMode = () => {diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsxindex 04a995b6ea0..a12bc90b303 100644--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx@@ -16,6 +16,7 @@ import { t } from "ttag";import { useListCommentsQuery } from "metabase/api";import { getTargetChildCommentThreads } from "metabase/comments/utils";import { Ellipsified } from "metabase/common/components/Ellipsified";+import { ExplicitSizeRefreshModeContext } from "metabase/common/components/ExplicitSize/ExplicitSize";import { QuestionPickerModal } from "metabase/common/components/Pickers/QuestionPicker/components/QuestionPickerModal";import type { QuestionPickerValueItem } from "metabase/common/components/Pickers/QuestionPicker/types";import { navigateToCardFromDocument } from "metabase/documents/actions";@@ -657,29 +658,31 @@ export const CardEmbedComponent = memo({series ? (<><Box className={styles.questionResults}>- <Visualization- rawSeries={series}- metadata={metadata}- mode={DocumentMode}- onChangeCardAndRun={- isPublicDocument ? undefined : handleChangeCardAndRun- }- onUpdateQuestion={- isPublicDocument ? undefined : handleUpdateQuestion- }- onUpdateVisualizationSettings={- isPublicDocument- ? undefined- : handleUpdateVisualizationSettings- }- getExtraDataForClick={() => ({})}- isEditing={false}- isDashboard={false}- isDocument={true}- showTitle={false}- error={datasetError?.message}- errorIcon={datasetError?.icon}- />+ <ExplicitSizeRefreshModeContext.Provider value="layout">+ <Visualization+ rawSeries={series}+ metadata={metadata}+ mode={DocumentMode}+ onChangeCardAndRun={+ isPublicDocument ? undefined : handleChangeCardAndRun+ }+ onUpdateQuestion={+ isPublicDocument ? undefined : handleUpdateQuestion+ }+ onUpdateVisualizationSettings={+ isPublicDocument+ ? undefined+ : handleUpdateVisualizationSettings+ }+ getExtraDataForClick={() => ({})}+ isEditing={false}+ isDashboard={false}+ isDocument={true}+ showTitle={false}+ error={datasetError?.message}+ errorIcon={datasetError?.icon}+ />+ </ExplicitSizeRefreshModeContext.Provider></Box></>) : (diff --git a/frontend/src/metabase/visualizations/components/ChartWithLegend.tsx b/frontend/src/metabase/visualizations/components/ChartWithLegend.tsxindex 0002d63bff9..873f55caf41 100644--- a/frontend/src/metabase/visualizations/components/ChartWithLegend.tsx+++ b/frontend/src/metabase/visualizations/components/ChartWithLegend.tsx@@ -189,6 +189,7 @@ const ChartWithLegendInner = ({paddingLeft: PADDING,paddingRight: PADDING,}}+ data-testid="chart-with-legend"ref={forwardedRef}>{legend && (diff --git a/frontend/src/metabase/visualizations/components/EChartsRenderer/ResponsiveEChartsRenderer.tsx b/frontend/src/metabase/visualizations/components/EChartsRenderer/ResponsiveEChartsRenderer.tsxindex bddd6b58aae..b5691c42ce8 100644--- a/frontend/src/metabase/visualizations/components/EChartsRenderer/ResponsiveEChartsRenderer.tsx+++ b/frontend/src/metabase/visualizations/components/EChartsRenderer/ResponsiveEChartsRenderer.tsx@@ -1,4 +1,4 @@-import { forwardRef, useEffect } from "react";+import { forwardRef, useLayoutEffect } from "react";import { ExplicitSize } from "metabase/common/components/ExplicitSize";import { isNumber } from "metabase/lib/types";@@ -24,7 +24,7 @@ const _ResponsiveEChartsRenderer = forwardRef<}: ResponsiveEChartsRendererProps,ref,) {- useEffect(() => {+ useLayoutEffect(() => {if (isNumber(width) && isNumber(height)) {onResize?.(width, height);}diff --git a/frontend/src/metabase/visualizations/components/ScalarValue/ScalarValue.tsx b/frontend/src/metabase/visualizations/components/ScalarValue/ScalarValue.tsxindex 37683fbbefe..ed94af39afd 100644--- a/frontend/src/metabase/visualizations/components/ScalarValue/ScalarValue.tsx+++ b/frontend/src/metabase/visualizations/components/ScalarValue/ScalarValue.tsx@@ -14,7 +14,7 @@ import { ScalarRoot, ScalarValueWrapper } from "./ScalarValue.styled";import { findSize, getMaxFontSize } from "./utils";export const ScalarWrapper = ({ children }: PropsWithChildren) => (- <ScalarRoot>{children}</ScalarRoot>+ <ScalarRoot data-testid="scalar-root">{children}</ScalarRoot>);interface ScalarValueProps {diff --git a/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx b/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsxindex 88d60a71022..22b1aef09e3 100644--- a/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx+++ b/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx@@ -807,7 +807,7 @@ export const TableInteractiveInner = forwardRef(function TableInteractiveInner(export const TableInteractive = _.compose(withMantineTheme,- ExplicitSize({+ ExplicitSize<TableProps>({refreshMode: "throttle",}),)(TableInteractiveInner);diff --git a/frontend/src/metabase/visualizations/visualizations/Progress/Progress.jsx b/frontend/src/metabase/visualizations/visualizations/Progress/Progress.jsxindex d41ebdc4ebf..52dc3f1a9c7 100644--- a/frontend/src/metabase/visualizations/visualizations/Progress/Progress.jsx+++ b/frontend/src/metabase/visualizations/visualizations/Progress/Progress.jsx@@ -234,6 +234,7 @@ export class Progress extends Component {<divref={this.rootRef}className={cx(this.props.className, CS.flex, CS.layoutCentered)}+ data-testid="progress-bar-root"><divclassName={cx(diff --git a/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.tsx b/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.tsxindex 76c657a6a62..e3553234ffc 100644--- a/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.tsx+++ b/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.tsx@@ -82,7 +82,7 @@ interface RowChartRendererProps extends RowChartProps<GroupedDatum> {function RowChartRendererInner(props: RowChartRendererProps) {return (- <RowChartContainer>+ <RowChartContainer data-testid="row-chart-container"><RowChart {...props} /></RowChartContainer>);