Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix removing all tags from a transform job (#63837)

Alexander Polyankinc60b139cf4a6
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/api/transform_job.clj b/enterprise/backend/src/metabase_enterprise/transforms/api/transform_job.clj
index 2ca3b17d87e..983338b2276 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/api/transform_job.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/api/transform_job.clj
@@ -83,7 +83,7 @@
(api/check-400 (transforms.schedule/validate-cron-expression schedule)
(deferred-tru "Invalid cron expression: {0}" schedule)))
;; Validate tag IDs if provided
- (when tag-ids
+ (when (seq tag-ids)
(let [existing-tags (set (t2/select-pks-vec :model/TransformTag :id [:in tag-ids]))]
(api/check-400 (= (set tag-ids) existing-tags)
(deferred-tru "Some tag IDs do not exist"))))
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/api/transform_job_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/api/transform_job_test.clj
index 281aa51da72..1547e73a279 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms/api/transform_job_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms/api/transform_job_test.clj
@@ -160,6 +160,17 @@
(is (string? response))
(is (re-find #"Invalid cron expression" response)))))))))
+(deftest update-job-remove-tags-test
+ (testing "PUT /api/ee/transform-job/:id"
+ (mt/with-premium-features #{:transforms}
+ (testing "should be able to remove all tags from a job"
+ (mt/with-temp [:model/TransformTag tag {}
+ :model/TransformJob job {}
+ :model/TransformJobTransformTag _ {:job_id (:id job) :tag_id (:id tag) :position 0}]
+ (let [response (mt/user-http-request :crowberto :put 200 (str "ee/transform-job/" (:id job))
+ {:tag_ids []})]
+ (is (= [] (:tag_ids response)))))))))
+
(deftest delete-job-test
(testing "DELETE /api/ee/transform-job/:id"
(mt/with-premium-features #{:transforms}