Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move build-scripts.yml jobs into run-tests.yml (#82101)

Chris Vandoodewaardc6f84f1abeae
diff --git a/.github/file-paths.yaml b/.github/file-paths.yaml
index edcadc31cae..2c58d13926a 100644
--- a/.github/file-paths.yaml
+++ b/.github/file-paths.yaml
@@ -270,6 +270,13 @@ cljs:
- ".github/workflows/cljs.yml"
- "shadow-cljs.edn"
+build_scripts:
+ - ".github/actions/prepare-backend/**"
+ - ".github/file-paths.yaml"
+ - ".github/workflows/build-scripts.yml"
+ - "bin/**"
+ - "deps.edn"
+
embedder_plugin:
- ".github/actions/prepare-backend/**"
- ".github/file-paths.yaml"
diff --git a/.github/workflows/build-scripts.yml b/.github/workflows/build-scripts.yml
index 2b13c13d26b..0373a91fb80 100644
--- a/.github/workflows/build-scripts.yml
+++ b/.github/workflows/build-scripts.yml
@@ -1,34 +1,19 @@
name: Build scripts
on:
- push:
- branches:
- - 'master'
- - 'release-**'
- pull_request:
+ workflow_call:
+ inputs:
+ skip-build-scripts:
+ type: boolean
+ default: false
+ skip-embedder-plugin:
+ type: boolean
+ default: false
jobs:
- files-changed:
- name: Check which files changed
- runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
- timeout-minutes: 3
- permissions:
- contents: read
- outputs:
- embedder_plugin: ${{ steps.changes.outputs.embedder_plugin }}
- steps:
- - uses: actions/checkout@v6
- - name: Test which files changed
- uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
- id: changes
- with:
- token: ${{ github.token }}
- filters: .github/file-paths.yaml
-
test-embedder-plugin:
- needs: files-changed
- if: needs.files-changed.outputs.embedder_plugin == 'true'
+ if: ${{ !inputs.skip-embedder-plugin }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
permissions:
@@ -78,6 +63,7 @@ jobs:
'[metabase-enterprise.semantic-search.appdb-pgvector-mode-test/appdb-pgvector-in-process-embedder-round-trip-test]'
test-build-scripts:
+ if: ${{ !inputs.skip-build-scripts }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
steps:
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index d2f1d3790ab..08b3d894c35 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -54,6 +54,8 @@ jobs:
e2e_specs: ${{ steps.changes.outputs.e2e_specs }}
e2e_infra: ${{ steps.changes.outputs.e2e_infra }}
backend_all: ${{ steps.changes.outputs.backend_all }}
+ build_scripts: ${{ steps.changes.outputs.build_scripts }}
+ embedder_plugin: ${{ steps.changes.outputs.embedder_plugin }}
frontend_all: ${{ steps.changes.outputs.frontend_all }}
frontend_sources: ${{ steps.changes.outputs.frontend_sources }}
frontend_unit_infra: ${{ steps.changes.outputs.frontend_unit_infra }}
@@ -360,6 +362,22 @@ jobs:
${{ needs.embedding-sdk-package.result != 'success' ||
needs.uberjar.result != 'success' }}
+ build-scripts-tests:
+ needs: [should-run, files-changed]
+ if: |
+ !cancelled() &&
+ (needs.should-run.outputs.verdict == 'force-run' ||
+ needs.files-changed.result == 'success')
+ uses: ./.github/workflows/build-scripts.yml
+ secrets: inherit
+ with:
+ skip-build-scripts: >-
+ ${{ needs.should-run.outputs.verdict != 'force-run' &&
+ needs.files-changed.outputs.build_scripts != 'true' }}
+ skip-embedder-plugin: >-
+ ${{ needs.should-run.outputs.verdict != 'force-run' &&
+ needs.files-changed.outputs.embedder_plugin != 'true' }}
+
bundle-size:
needs: [uberjar, files-changed]
if: |