The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Move useHelpLink from nav into common/hooks (#81843)
Fraserc71cf2a3792d
diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjsindex a77ff9f5f20..6354a259733 100644--- a/frontend/lint/module-boundaries.mjs+++ b/frontend/lint/module-boundaries.mjs@@ -103,7 +103,6 @@ const elements = [type: "shared",name: "upsells",pattern: "frontend/src/metabase/common/components/upsells/**",- enforceSharedTiers: false,}),...["frontend/src/metabase/common/search/**",diff --git a/frontend/src/metabase/common/components/upsells/StoragePurchaseModal/StorageSetupErrorView.tsx b/frontend/src/metabase/common/components/upsells/StoragePurchaseModal/StorageSetupErrorView.tsxindex 9a22bbd8eec..e840ea5e13d 100644--- a/frontend/src/metabase/common/components/upsells/StoragePurchaseModal/StorageSetupErrorView.tsx+++ b/frontend/src/metabase/common/components/upsells/StoragePurchaseModal/StorageSetupErrorView.tsx@@ -1,7 +1,7 @@import { c, t } from "ttag";import { ExternalLink } from "metabase/common/components/ExternalLink";-import { useHelpLink } from "metabase/nav/components/AppSwitcher/useHelpLink";+import { useHelpLink } from "metabase/common/hooks";import { Icon } from "metabase/ui";import { StorageSetupStatusView } from "./StorageSetupStatusView";diff --git a/frontend/src/metabase/common/hooks/index.ts b/frontend/src/metabase/common/hooks/index.tsindex 87d60ef3ea6..e328c2bda9b 100644--- a/frontend/src/metabase/common/hooks/index.ts+++ b/frontend/src/metabase/common/hooks/index.ts@@ -5,6 +5,7 @@ export * from "./use-dnd-sensors";export * from "./use-docs-url";export * from "./use-get-personal-collection";export * from "./use-has-token-feature";+export { useHelpLink } from "./use-help-link";export * from "./use-locale";export * from "./use-notification-channels";export * from "./use-scroll-to-top";diff --git a/frontend/src/metabase/nav/components/AppSwitcher/useHelpLink.ts b/frontend/src/metabase/common/hooks/use-help-link.tssimilarity index 100%rename from frontend/src/metabase/nav/components/AppSwitcher/useHelpLink.tsrename to frontend/src/metabase/common/hooks/use-help-link.tsdiff --git a/frontend/src/metabase/nav/components/AppSwitcher/useHelpLink.unit.spec.ts b/frontend/src/metabase/common/hooks/use-help-link.unit.spec.tssimilarity index 98%rename from frontend/src/metabase/nav/components/AppSwitcher/useHelpLink.unit.spec.tsrename to frontend/src/metabase/common/hooks/use-help-link.unit.spec.tsindex 208ce24b46f..9d86798e650 100644--- a/frontend/src/metabase/nav/components/AppSwitcher/useHelpLink.unit.spec.ts+++ b/frontend/src/metabase/common/hooks/use-help-link.unit.spec.ts@@ -9,7 +9,7 @@ import {createMockVersion,} from "metabase-types/api/mocks";-import { useHelpLink } from "./useHelpLink";+import { useHelpLink } from "./use-help-link";interface SetupOptions {customLinkDestination?: string;diff --git a/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx b/frontend/src/metabase/home/components/Onboarding/Onboarding.tsxindex abb9b6cc429..f79964cb811 100644--- a/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx+++ b/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx@@ -2,8 +2,12 @@ import { useMemo, useRef } from "react";import { jt, t } from "ttag";import { ExternalLink } from "metabase/common/components/ExternalLink";-import { useDocsUrl, useLearnUrl, useTempStorage } from "metabase/common/hooks";-import { useHelpLink } from "metabase/nav/components/AppSwitcher/useHelpLink";+import {+ useDocsUrl,+ useHelpLink,+ useLearnUrl,+ useTempStorage,+} from "metabase/common/hooks";import { useSelector } from "metabase/redux";import type { ChecklistItemValue } from "metabase/redux/store";import { getIsPaidPlan } from "metabase/selectors/settings";diff --git a/frontend/src/metabase/nav/components/AppSwitcher/AppSwitcher.tsx b/frontend/src/metabase/nav/components/AppSwitcher/AppSwitcher.tsxindex c0a38b9c06b..d5dc2fa2477 100644--- a/frontend/src/metabase/nav/components/AppSwitcher/AppSwitcher.tsx+++ b/frontend/src/metabase/nav/components/AppSwitcher/AppSwitcher.tsx@@ -7,6 +7,7 @@ import { ExternalLink } from "metabase/common/components/ExternalLink";import { ForwardRefLink } from "metabase/common/components/Link";import { trackDataStudioOpened } from "metabase/common/data-studio/analytics";import { canAccessDataStudio as canAccessDataStudioSelector } from "metabase/common/data-studio/selectors";+import { useHelpLink } from "metabase/common/hooks";import { trackMonitorOpened } from "metabase/common/monitor/analytics";import { canAccessMonitor as canAccessMonitorSelector } from "metabase/common/monitor/selectors";import { prepareInitials } from "metabase/common/utils/user";@@ -40,7 +41,6 @@ import { AboutModal } from "../AboutModal/AboutModal";import S from "./AppSwitcher.module.css";import { useGetCurrentApp } from "./useGetCurrentApp";-import { useHelpLink } from "./useHelpLink";const CURRENT_APP_ICON_OVERRIDES: {name: IconName;