The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
GIT-8461 hide "Visualize another way" button for Sankey charts (#67753)
Egor Grushinc822a6228c52
diff --git a/e2e/test/scenarios/dashboard/visualizer/reproductions.cy.spec.ts b/e2e/test/scenarios/dashboard/visualizer/reproductions.cy.spec.tsindex 32ece424c86..e5b00ee8e3a 100644--- a/e2e/test/scenarios/dashboard/visualizer/reproductions.cy.spec.ts+++ b/e2e/test/scenarios/dashboard/visualizer/reproductions.cy.spec.ts@@ -1,3 +1,4 @@+import { SAMPLE_DB_ID } from "e2e/support/cypress_data";import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";import type {DashboardDetails,@@ -290,3 +291,51 @@ describe("issue 65908 (UXW-2293)", () => {});});});++describe("issue 65317", () => {+ const SANKEY_QUERY = `+SELECT 'A' AS source, 'B' AS target, 100 AS value+UNION ALL+SELECT 'B', 'C', 80+UNION ALL+SELECT 'C', 'D', 60+`;++ beforeEach(() => {+ H.restore();+ cy.signInAsAdmin();+ });++ it("should not show 'Visualize another way' button for Sankey charts (metabase#65317)", () => {+ H.createDashboard({+ name: "Dashboard with Sankey",+ }).then(({ body: dashboard }) => {+ H.createNativeQuestion({+ name: "Sankey Question",+ native: {+ query: SANKEY_QUERY,+ },+ display: "sankey",+ database: SAMPLE_DB_ID,+ }).then(({ body: card }) => {+ H.addOrUpdateDashboardCard({+ card_id: card.id,+ dashboard_id: dashboard.id,+ card: {+ size_x: 12,+ size_y: 8,+ },+ });++ H.visitDashboard(dashboard.id);+ });+ });++ H.editDashboard();++ H.getDashboardCard(0).realHover({ scrollBehavior: "bottom" });++ cy.findByTestId("dashboardcard-actions-panel").should("be.visible");+ cy.findByLabelText("Visualize another way").should("not.exist");+ });+});diff --git a/frontend/src/metabase/dashboard/components/DashCard/DashCardActionsPanel/DashCardActionsPanel.tsx b/frontend/src/metabase/dashboard/components/DashCard/DashCardActionsPanel/DashCardActionsPanel.tsxindex d746b54a04e..bc71737f062 100644--- a/frontend/src/metabase/dashboard/components/DashCard/DashCardActionsPanel/DashCardActionsPanel.tsx+++ b/frontend/src/metabase/dashboard/components/DashCard/DashCardActionsPanel/DashCardActionsPanel.tsx@@ -17,6 +17,7 @@ import type { NewParameterOpts } from "metabase/parameters/utils/dashboards";import { Box, Icon } from "metabase/ui";import { getVisualizationRaw } from "metabase/visualizations";import {+ isDisabledForVisualizer,isVisualizerDashboardCard,isVisualizerSupportedVisualization,} from "metabase/visualizer/utils";@@ -221,6 +222,7 @@ function DashCardActionsPanelInner({!isVisualizerDashboardCard(dashcard) &&!isVisualizerSupportedVisualization(dashcard?.card.display) &&!isVirtualDashCard(dashcard) &&+ !isDisabledForVisualizer(dashcard?.card.display) &&onEditVisualization) {buttons.push(diff --git a/frontend/src/metabase/visualizations/types/visualization.ts b/frontend/src/metabase/visualizations/types/visualization.tsindex aa89de5d1a9..6c450754511 100644--- a/frontend/src/metabase/visualizations/types/visualization.ts+++ b/frontend/src/metabase/visualizations/types/visualization.ts@@ -335,6 +335,7 @@ export type VisualizationDefinition = {disableSettingsConfig?: boolean;supportPreviewing?: boolean;supportsVisualizer?: boolean;+ disableVisualizer?: boolean;minSize: VisualizationGridSize;defaultSize: VisualizationGridSize;diff --git a/frontend/src/metabase/visualizations/visualizations/SankeyChart/chart-definition.ts b/frontend/src/metabase/visualizations/visualizations/SankeyChart/chart-definition.tsindex 78a1871c34b..0f47611f9bd 100644--- a/frontend/src/metabase/visualizations/visualizations/SankeyChart/chart-definition.ts+++ b/frontend/src/metabase/visualizations/visualizations/SankeyChart/chart-definition.ts@@ -14,6 +14,7 @@ import {} from "metabase/visualizations/shared/utils/sizes";import type {ComputedVisualizationSettings,+ VisualizationDefinition,VisualizationSettingsDefinitions,} from "metabase/visualizations/types";import { isDate, isDimension, isMetric } from "metabase-lib/v1/types/utils/isa";@@ -141,13 +142,14 @@ export const SETTINGS_DEFINITIONS = {},};-export const SANKEY_CHART_DEFINITION = {+export const SANKEY_CHART_DEFINITION: VisualizationDefinition = {getUiName: () => t`Sankey`,identifier: "sankey",iconName: "sankey",// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045noun: t`sankey chart`,minSize: getMinSize("sankey"),+ disableVisualizer: true,defaultSize: getDefaultSize("sankey"),isSensible: (data: DatasetData) => {const { cols, rows } = data;diff --git a/frontend/src/metabase/visualizer/utils/dashboard-card-supports-visualizer.ts b/frontend/src/metabase/visualizer/utils/dashboard-card-supports-visualizer.tsindex 2adb4b6fa13..ef18640db43 100644--- a/frontend/src/metabase/visualizer/utils/dashboard-card-supports-visualizer.ts+++ b/frontend/src/metabase/visualizer/utils/dashboard-card-supports-visualizer.ts@@ -24,3 +24,13 @@ export function isVisualizerSupportedVisualization(return visualizations.get(display)?.supportsVisualizer;}++export function isDisabledForVisualizer(+ display: VisualizationDisplay | null | undefined,+) {+ if (!display) {+ return false;+ }++ return visualizations.get(display)?.disableVisualizer;+}