Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

test(eajs): handleLink should prevent default behavior when returning `{handled:true}` (#70592)

Nicolò Prettoc8d5e94fface
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
index e3f4d07889f..7f3b6dfe957 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
@@ -499,16 +499,42 @@ describe("scenarios > embedding > modular embedding", () => {
cy.wait("@getDashCardQuery");
+ // Spy on the iframe's anchor clicks and window.open
+ // so we can check the default behavior is prevented
+ cy.get("iframe").then(($iframe) => {
+ const iframeWin: any = $iframe[0].contentWindow;
+ expect(iframeWin).to.not.be.null;
+
+ iframeWin.__blankLinkClicks = [];
+ iframeWin.__windowOpenCalls = [];
+
+ iframeWin.HTMLAnchorElement.prototype.click = function () {
+ iframeWin.__blankLinkClicks.push(this.href);
+ };
+
+ iframeWin.open = function (...args: unknown[]) {
+ iframeWin.__windowOpenCalls.push(args);
+ };
+ });
+
frame.within(() => {
cy.findByText("Order 448").click();
});
- // Verify handleLink was called with the correct URL
+ cy.log("Verify handleLink was called with the correct URL");
cy.window()
.its("handleLinkCalls")
.should("have.length", 1)
.its(0)
.should("include", "https://example.org/order/448");
+
+ cy.log("Verify that no default navigation happened");
+ cy.get("iframe")
+ .its("0.contentWindow.__blankLinkClicks")
+ .should("have.length", 0);
+ cy.get("iframe")
+ .its("0.contentWindow.__windowOpenCalls")
+ .should("have.length", 0);
});
});