Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

UXW-3775 open Metric Viewer in the same tab (#73009)

Denis Berezinc8f5c5e6d9bb
diff --git a/e2e/test/scenarios/data-studio/data-studio-metrics.cy.spec.ts b/e2e/test/scenarios/data-studio/data-studio-metrics.cy.spec.ts
index eb1a64b0662..c23efc306d2 100644
--- a/e2e/test/scenarios/data-studio/data-studio-metrics.cy.spec.ts
+++ b/e2e/test/scenarios/data-studio/data-studio-metrics.cy.spec.ts
@@ -272,7 +272,6 @@ describe("scenarios > data studio > library > metrics", () => {
cy.log("Verify View link opens in new tab");
H.DataStudio.Metrics.moreMenu().click();
H.DataStudio.Metrics.exploreLink()
- .should("have.attr", "target", "_blank")
.should("have.attr", "href")
.and("match", /\/explore\?metricId=\d+/);
});
diff --git a/frontend/src/metabase/data-studio/common/components/MoreMenu/MoreMenu.tsx b/frontend/src/metabase/data-studio/common/components/MoreMenu/MoreMenu.tsx
index f60046b39cd..2aee0ac4720 100644
--- a/frontend/src/metabase/data-studio/common/components/MoreMenu/MoreMenu.tsx
+++ b/frontend/src/metabase/data-studio/common/components/MoreMenu/MoreMenu.tsx
@@ -49,7 +49,6 @@ export function MoreMenu({
<Menu.Item
component={Link}
to={previewUrl}
- target="_blank"
leftSection={<Icon name="share" />}
>
{previewLabel ?? t`Preview`}
diff --git a/frontend/src/metabase/metrics/components/MetricHeader/MetricToolbar/MetricToolbar.tsx b/frontend/src/metabase/metrics/components/MetricHeader/MetricToolbar/MetricToolbar.tsx
index ae5bd4a7166..522adc22b0a 100644
--- a/frontend/src/metabase/metrics/components/MetricHeader/MetricToolbar/MetricToolbar.tsx
+++ b/frontend/src/metabase/metrics/components/MetricHeader/MetricToolbar/MetricToolbar.tsx
@@ -114,7 +114,6 @@ function MetricToolbarButtons({
<Button
component={ForwardRefLink}
to={Urls.exploreMetric(card.id)}
- target="_blank"
leftSection={<Icon name="external" />}
data-testid="explore-link"
>