Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

feat: use id-slug url for table row details (#78126)

Uladzimir Havenchykc8f693f5da13
diff --git a/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js
index 5a32f12fb91..7e444102a6b 100644
--- a/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js
+++ b/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js
@@ -659,7 +659,7 @@ describe("scenarios > question > object details", { tags: "@slow" }, () => {
H.openObjectDetail(0);
cy.findByTestId("object-detail").within(() => {
- const expectedUrl = `http://localhost:4000/table/${PEOPLE_ID}/detail/1`;
+ const expectedUrl = `http://localhost:4000/table/${PEOPLE_ID}-people/detail/1`;
cy.findByLabelText("Copy link to this record").click();
H.readClipboard().should("equal", expectedUrl);
diff --git a/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts b/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts
index d3c8b4fd059..bcd838e4f94 100644
--- a/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts
+++ b/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts
@@ -4,6 +4,7 @@ import {
isImplicitDeleteAction,
isImplicitUpdateAction,
} from "metabase/actions/utils";
+import * as Urls from "metabase/urls";
import { singularize } from "metabase/utils/formatting";
import { formatValue } from "metabase/visualizations/lib/formatting";
import type Question from "metabase-lib/v1/Question";
@@ -222,7 +223,9 @@ export function getRowUrl(
}
if (typeof table?.id === "number") {
- return `/table/${table.id}/detail/${rowId}`;
+ const tableUrl = Urls.table({ id: table.id, name: table.display_name });
+
+ return `${tableUrl}/detail/${rowId}`;
}
return undefined;
diff --git a/frontend/src/metabase/visualizations/components/ObjectDetail/utils.unit.spec.ts b/frontend/src/metabase/visualizations/components/ObjectDetail/utils.unit.spec.ts
index 52e1f5db106..982e25ba877 100644
--- a/frontend/src/metabase/visualizations/components/ObjectDetail/utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/components/ObjectDetail/utils.unit.spec.ts
@@ -5,6 +5,7 @@ import {
createMockDatasetData,
createMockImplicitQueryAction,
createMockNativeDatasetQuery,
+ createMockTable,
} from "metabase-types/api/mocks";
import {
ORDERS_ID,
@@ -18,6 +19,7 @@ import {
getDisplayId,
getIdValue,
getObjectName,
+ getRowUrl,
getSinglePKIndex,
isValidImplicitDeleteAction,
isValidImplicitUpdateAction,
@@ -261,6 +263,38 @@ describe("ObjectDetail utils", () => {
});
});
+ describe("getRowUrl", () => {
+ const question = new Question(card, metadata);
+ const model = new Question({ ...card, type: "model" }, metadata);
+ const table = createMockTable({ id: 5, display_name: "Invoices" });
+
+ it("should return undefined when there is not exactly one PK column", () => {
+ expect(getRowUrl(question, [idCol, productIdCol], table, 1)).toBe(
+ undefined,
+ );
+ expect(getRowUrl(question, [qtyCol], table, 1)).toBe(undefined);
+ });
+
+ it("should return a model URL with the model slug", () => {
+ expect(getRowUrl(model, [idCol, qtyCol], table, 1)).toBe(
+ "/model/1-special-order/detail/1",
+ );
+ });
+
+ it("should return a table URL with the table slug", () => {
+ expect(getRowUrl(question, [idCol, qtyCol], table, 1)).toBe(
+ "/table/5-invoices/detail/1",
+ );
+ });
+
+ it("should return undefined for virtual tables", () => {
+ const virtualTable = createMockTable({ id: "card__17" });
+ expect(getRowUrl(question, [idCol, qtyCol], virtualTable, 1)).toBe(
+ undefined,
+ );
+ });
+ });
+
describe("getActionItems", () => {
const onDelete = jest.fn();
const onUpdate = jest.fn();