Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

`Tenant Collections` -> `Shared collections` in permissions page (#67452)

Nicolò Prettoc95d1d48839d
diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.tsx
index 49d6ebcbb4d..a4281628239 100644
--- a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.tsx
@@ -93,7 +93,7 @@ export const getTenantCollectionsSidebar = createSelector(
(collectionsTree, collectionId): CollectionSidebarType => {
return {
selectedId: collectionId,
- title: t`Tenant Collections`,
+ title: t`Shared collections`,
entityGroups: [collectionsTree || []],
filterPlaceholder: t`Search for a collection`,
};
diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/index.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/index.tsx
index 1840ad903ab..8acb1ff2756 100644
--- a/enterprise/frontend/src/metabase-enterprise/tenants/index.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/tenants/index.tsx
@@ -126,7 +126,7 @@ export function initializePlugin() {
// Register tenant collection permissions tab and routes
PLUGIN_ADMIN_PERMISSIONS_TABS.tabs.push({
- name: t`Tenant Collections`,
+ name: t`Shared collections`,
value: "tenant-collections",
});
diff --git a/frontend/src/metabase/admin/permissions/pages/CollectionPermissionsPage/tests/common.unit.spec.tsx b/frontend/src/metabase/admin/permissions/pages/CollectionPermissionsPage/tests/common.unit.spec.tsx
index 18e44c623a0..69f45fac52f 100644
--- a/frontend/src/metabase/admin/permissions/pages/CollectionPermissionsPage/tests/common.unit.spec.tsx
+++ b/frontend/src/metabase/admin/permissions/pages/CollectionPermissionsPage/tests/common.unit.spec.tsx
@@ -225,7 +225,7 @@ describe("Admin > CollectionPermissionsPage", () => {
setup();
expect(
- screen.queryByRole("radio", { name: "Tenant Collections" }),
+ screen.queryByRole("radio", { name: "Shared collections" }),
).not.toBeInTheDocument();
});
});
diff --git a/frontend/src/metabase/admin/permissions/pages/CollectionPermissionsPage/tests/enterprise.unit.spec.tsx b/frontend/src/metabase/admin/permissions/pages/CollectionPermissionsPage/tests/enterprise.unit.spec.tsx
index a7476f47199..6f28f1bc934 100644
--- a/frontend/src/metabase/admin/permissions/pages/CollectionPermissionsPage/tests/enterprise.unit.spec.tsx
+++ b/frontend/src/metabase/admin/permissions/pages/CollectionPermissionsPage/tests/enterprise.unit.spec.tsx
@@ -16,7 +16,7 @@ import {
const tokenFeatures = { tenants: true, audit_app: true };
describe("Admin > CollectionPermissionsPage (enterprise)", () => {
- describe("Tenant Collections Tab", () => {
+ describe("Shared collections Tab", () => {
it("shows the tab when tenants are enabled", async () => {
setup({
tokenFeatures,
@@ -25,7 +25,7 @@ describe("Admin > CollectionPermissionsPage (enterprise)", () => {
});
expect(
- await screen.findByRole("radio", { name: "Tenant Collections" }),
+ await screen.findByRole("radio", { name: "Shared collections" }),
).toBeInTheDocument();
});
@@ -37,7 +37,7 @@ describe("Admin > CollectionPermissionsPage (enterprise)", () => {
});
expect(
- screen.queryByRole("radio", { name: "Tenant Collections" }),
+ screen.queryByRole("radio", { name: "Shared collections" }),
).not.toBeInTheDocument();
});
});