Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Unskip transform tests (#63733)

Alexander Polyankinc98dca560d3d
diff --git a/e2e/test/scenarios/admin/transforms.cy.spec.ts b/e2e/test/scenarios/admin/transforms.cy.spec.ts
index 494657c3f19..0294b11a454 100644
--- a/e2e/test/scenarios/admin/transforms.cy.spec.ts
+++ b/e2e/test/scenarios/admin/transforms.cy.spec.ts
@@ -508,21 +508,21 @@ H.describeWithSnowplowEE("scenarios > admin > transforms", () => {
});
describe("tags", () => {
- it("should be able to add and remove tags", { tags: "@flaky" }, () => {
+ it("should be able to add and remove tags", () => {
createMbqlTransform({ visitTransform: true });
getTagsInput().click();
- H.popover().findByRole("option", { name: "hourly" }).click();
+ H.popover().findByText("hourly").click();
cy.wait("@updateTransform");
assertOptionSelected("hourly");
assertOptionNotSelected("daily");
- H.popover().findByRole("option", { name: "daily" }).click();
+ H.popover().findByText("daily").click();
cy.wait("@updateTransform");
assertOptionSelected("hourly");
assertOptionSelected("daily");
- H.popover().findByRole("option", { name: "hourly" }).click();
+ H.popover().findByText("hourly").click();
cy.wait("@updateTransform");
assertOptionNotSelected("hourly");
assertOptionSelected("daily");
@@ -542,7 +542,8 @@ H.describeWithSnowplowEE("scenarios > admin > transforms", () => {
getTagsInput().click();
H.popover()
- .findByRole("option", { name: "hourly" })
+ .findByText("hourly")
+ .parent()
.findByLabelText("Rename tag")
.click({ force: true });
H.modal().within(() => {
@@ -560,7 +561,8 @@ H.describeWithSnowplowEE("scenarios > admin > transforms", () => {
getTagsInput().click();
H.popover()
- .findByRole("option", { name: "hourly" })
+ .findByText("hourly")
+ .parent()
.findByLabelText("Delete tag")
.click({ force: true });
H.modal().within(() => {
@@ -596,7 +598,8 @@ H.describeWithSnowplowEE("scenarios > admin > transforms", () => {
cy.log("Remove the new tag from transform B");
getTagsInput().click();
H.popover()
- .findByRole("option", { name: "New tag" })
+ .findByText("New tag")
+ .parent()
.findByLabelText("Delete tag")
.click({ force: true });
H.modal().within(() => {
@@ -1377,22 +1380,18 @@ describe("scenarios > admin > transforms > databases without :schemas", () => {
cy.intercept("DELETE", "/api/ee/transform-tag/*").as("deleteTag");
});
- it(
- "should be not be possible to create a new schema when updating a transform target",
- { tags: "@flaky" },
- () => {
- createMbqlTransform({
- databaseId: WRITABLE_DB_ID,
- sourceTable: "ORDERS",
- visitTransform: true,
- targetSchema: null,
- });
+ it("should be not be possible to create a new schema when updating a transform target", () => {
+ createMbqlTransform({
+ databaseId: WRITABLE_DB_ID,
+ sourceTable: "ORDERS",
+ visitTransform: true,
+ targetSchema: null,
+ });
- getTransformPage().button("Change target").click();
+ getTransformPage().button("Change target").click();
- H.modal().findByLabelText("Schema").should("not.exist");
- },
- );
+ H.modal().findByLabelText("Schema").should("not.exist");
+ });
it("should be not be possible to create a new schema when the database does not support schemas", () => {
cy.log("create a new transform");
@@ -1540,22 +1539,21 @@ describe("scenarios > admin > transforms > jobs", () => {
});
describe("tags", () => {
- // skipped because it's flaking so often
- it("should be able to add and remove tags", { tags: "@skip" }, () => {
+ it("should be able to add and remove tags", () => {
H.createTransformJob({ name: "New job" }, { visitTransformJob: true });
getTagsInput().click();
- H.popover().findByRole("option", { name: "hourly" }).click();
+ H.popover().findByText("hourly").click();
cy.wait("@updateJob");
assertOptionSelected("hourly");
assertOptionNotSelected("daily");
- H.popover().findByRole("option", { name: "daily" }).click();
+ H.popover().findByText("daily").click();
cy.wait("@updateJob");
assertOptionSelected("hourly");
assertOptionSelected("daily");
- H.popover().findByRole("option", { name: "hourly" }).click();
+ H.popover().findByText("hourly").click();
cy.wait("@updateJob");
assertOptionNotSelected("hourly");
assertOptionSelected("daily");
@@ -1640,7 +1638,7 @@ describe("scenarios > admin > transforms > jobs", () => {
});
describe("filtering", () => {
- it("should be able to filter jobs ", { tags: "@flaky" }, () => {
+ it("should be able to filter jobs ", () => {
cy.log("run hourly job so know that was recently run");
visitJobListPage();