Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Compare ex-data, ex-message of throwables on pivot parity mismatch (#79180)

metambenc991b6d3f714
diff --git a/src/metabase/query_processor/pivot.clj b/src/metabase/query_processor/pivot.clj
index 3ccd2a77be1..0976ade1b1a 100644
--- a/src/metabase/query_processor/pivot.clj
+++ b/src/metabase/query_processor/pivot.clj
@@ -757,13 +757,16 @@
(catch Throwable t
{:throwable t}))))
+(def ^:private throwable-signature
+ (juxt class ex-message ex-data))
+
(defn- outcomes-match?
- "True when two `{:outcome ...}`/`{:throwable ...}` maps represent equivalent behavior — both threw the
- same throwable class, or both succeeded with row-equivalent results."
+ "True when two `{:outcome ...}`/`{:throwable ...}` maps represent equivalent behavior — both threw
+ throwables with the same signature (see [[throwable-signature]]), or both succeeded with row-equivalent results."
[{primary-outcome :outcome primary-t :throwable}
{secondary-outcome :outcome secondary-t :throwable}]
(cond
- (and primary-t secondary-t) (= (class primary-t) (class secondary-t))
+ (and primary-t secondary-t) (= (throwable-signature primary-t) (throwable-signature secondary-t))
(or primary-t secondary-t) false
:else (pivot-rows-equivalent? primary-outcome secondary-outcome)))
@@ -799,7 +802,7 @@
When [[*check-pivot-parity?*]] is on and both paths are applicable, both run (primary via the caller's
rff, secondary via the default rff for comparison) and disagreement is reported via
- [[*on-parity-mismatch*]]. Parity checking is on by default in test builds.
+ [[*on-parity-mismatch*]]. Parity checking is on by default in clojure.test tests.
Wrap this call in [[metabase.query-processor.streaming/streaming-response]] yourself."
([query]