Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

UXW-2862 Fix test flake (#68784)

Brad Andersonc9bcbbfd73e2
diff --git a/frontend/src/metabase/palette/components/Palette.unit.spec.tsx b/frontend/src/metabase/palette/components/Palette.unit.spec.tsx
index 105cc73500e..79e5523ab79 100644
--- a/frontend/src/metabase/palette/components/Palette.unit.spec.tsx
+++ b/frontend/src/metabase/palette/components/Palette.unit.spec.tsx
@@ -20,12 +20,14 @@ import { Palette } from "./Palette";
const setup = ({
routeProps,
searchResults = [],
+ searchResultsDelay,
}: {
routeProps?: { disableCommandPalette?: boolean };
searchResults?: SearchResult[];
+ searchResultsDelay?: number;
} = {}) => {
setupDatabasesEndpoints([]);
- setupSearchEndpoints(searchResults);
+ setupSearchEndpoints(searchResults, searchResultsDelay);
setupRecentViewsEndpoints([]);
renderWithProviders(<Route path="/" component={Palette} {...routeProps} />, {
withKBar: true,
@@ -97,6 +99,7 @@ describe("command palette", () => {
setup({
searchResults: [createMockSearchResult({ name: "Metric search result" })],
+ searchResultsDelay: 50, // add a delay to endpoint so that loading state can be triggered consistently w/o test flakes
});
await userEvent.keyboard("[ControlLeft>]k");
diff --git a/frontend/test/__support__/server-mocks/search.ts b/frontend/test/__support__/server-mocks/search.ts
index 10563169ce6..c4f33bbcc60 100644
--- a/frontend/test/__support__/server-mocks/search.ts
+++ b/frontend/test/__support__/server-mocks/search.ts
@@ -4,7 +4,10 @@ import { match } from "ts-pattern";
import type { CollectionItem, SearchResult } from "metabase-types/api";
import type { EmbeddingDataPicker } from "metabase-types/store/embedding-data-picker";
-export function setupSearchEndpoints(items: (CollectionItem | SearchResult)[]) {
+export function setupSearchEndpoints(
+ items: (CollectionItem | SearchResult)[],
+ delay?: number,
+) {
const name = "search";
fetchMock.removeRoute(name);
fetchMock.get(
@@ -39,7 +42,7 @@ export function setupSearchEndpoints(items: (CollectionItem | SearchResult)[]) {
table_db_id,
};
},
- { name },
+ { name, delay },
);
}