The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix string field IDs leaking into bulk-metadata queries (#71167)
Eric Normandc9c7f230fbc8
diff --git a/src/metabase/lib/walk/util.cljc b/src/metabase/lib/walk/util.cljcindex 1b277d5dfd1..469582d8f04 100644--- a/src/metabase/lib/walk/util.cljc+++ b/src/metabase/lib/walk/util.cljc@@ -185,7 +185,7 @@implicit-join-field-opt? #(and (:source-field %) (not (:join-alias %)))walk-clause (fn [clause](lib.util.match/match-lite clause- [:field (opts :guard implicit-join-field-opt?) id]+ [:field (opts :guard implicit-join-field-opt?) (id :guard pos-int?)](vswap! joined-field-ids conj! id)_ nil)diff --git a/test/metabase/lib/walk/util_test.cljc b/test/metabase/lib/walk/util_test.cljcindex 32a0746c863..23972bf21d5 100644--- a/test/metabase/lib/walk/util_test.cljc+++ b/test/metabase/lib/walk/util_test.cljc@@ -165,7 +165,12 @@{:source-table $$venues:joins [{:source-table $$users:alias "U"- :condition [:= [:field $categories.name {:source-field %venues.category-id}] &U.users.name]}]})))))))+ :condition [:= [:field $categories.name {:source-field %venues.category-id}] &U.users.name]}]}))))))+ (testing "Ignores string field names (should only collect integer field IDs) - GHY-3085"+ (mu/disable-enforcement+ (is (= #{}+ (lib.walk.util/all-implicitly-joined-field-ids+ [:field {:source-field 1} "CITY"]))))))(deftest ^:parallel all-implicitly-joined-table-ids-test(testing "Returns table IDs from implicit joins by resolving FK relationships"