Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Convert `app-embed` and `app-public` to TypeScript (#69438)

Fraserca002fd953cb
diff --git a/frontend/src/metabase/app-embed.js b/frontend/src/metabase/app-embed.ts
similarity index 100%
rename from frontend/src/metabase/app-embed.js
rename to frontend/src/metabase/app-embed.ts
diff --git a/frontend/src/metabase/app-public.js b/frontend/src/metabase/app-public.ts
similarity index 100%
rename from frontend/src/metabase/app-public.js
rename to frontend/src/metabase/app-public.ts
diff --git a/rspack.main.config.js b/rspack.main.config.js
index 1c8b25ee986..88a1ff66cf6 100644
--- a/rspack.main.config.js
+++ b/rspack.main.config.js
@@ -96,8 +96,8 @@ const config = {
// eventually we should have multiple (single file) entry points for various pieces of the app to enable code splitting
entry: {
"app-main": "./app-main.js",
- "app-public": "./app-public.js",
- "app-embed": "./app-embed.js",
+ "app-public": "./app-public.ts",
+ "app-embed": "./app-embed.ts",
"app-embed-sdk": "./app-embed-sdk.tsx",
"vendor-styles": "./css/vendor.css",
styles: "./css/index.module.css",
diff --git a/tsconfig.json b/tsconfig.json
index c3b09bc2b9f..ca27e45ddef 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -36,7 +36,7 @@
// The following files will load `frontend/src/metabase/app` which will conflict with
// `frontend/src/metabase/App.tsx`, since now we're loading both JS and TS files.
"frontend/src/metabase/app-main.js",
- "frontend/src/metabase/app-public.js",
- "frontend/src/metabase/app-embed.js"
+ "frontend/src/metabase/app-public.ts",
+ "frontend/src/metabase/app-embed.ts"
]
}