The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Convert query_builder test loose ends to TypeScript (#76938)
Romeo Van Snickca6033b69883
diff --git a/frontend/src/metabase/query_builder/components/QuestionActivityTimeline.unit.spec.js b/frontend/src/metabase/query_builder/components/QuestionActivityTimeline.unit.spec.tsxsimilarity index 52%rename from frontend/src/metabase/query_builder/components/QuestionActivityTimeline.unit.spec.jsrename to frontend/src/metabase/query_builder/components/QuestionActivityTimeline.unit.spec.tsxindex 5ba4d37629f..55108903519 100644--- a/frontend/src/metabase/query_builder/components/QuestionActivityTimeline.unit.spec.js+++ b/frontend/src/metabase/query_builder/components/QuestionActivityTimeline.unit.spec.tsx@@ -8,67 +8,40 @@ import {waitForLoaderToBeRemoved,} from "__support__/ui";import { QuestionActivityTimeline } from "metabase/query_builder/components/QuestionActivityTimeline";-import { createMockUser, createMockUserInfo } from "metabase-types/api/mocks";+import Question from "metabase-lib/v1/Question";+import {+ createMockCard,+ createMockUserListResult,+} from "metabase-types/api/mocks";import { createMockRevision } from "metabase-types/api/mocks/revision";-const REVISIONS = [- {- is_reversion: true,- description: "bar",- timestamp: "2016-05-08T02:02:07.441Z",- user: {- common_name: "Bar",- },- },- {- is_creation: true,- description: "foo",- timestamp: "2016-04-08T02:02:07.441Z",- user: {- common_name: "Foo",- },- },-];+interface SetupOpts {+ canWrite: boolean;+}++async function setup({ canWrite }: SetupOpts) {+ const question = new Question(createMockCard({ can_write: canWrite }));-async function setup({ question }) {setupRevisionsEndpoints([createMockRevision(),createMockRevision({ id: 2 }),]);- setupUsersEndpoints([createMockUserInfo()]);- renderWithProviders(- <QuestionActivityTimeline- question={question}- revisions={REVISIONS}- currentUser={createMockUser()}- />,- );+ setupUsersEndpoints([createMockUserListResult()]);+ renderWithProviders(<QuestionActivityTimeline question={question} />);await waitForLoaderToBeRemoved();}describe("QuestionActivityTimeline", () => {describe("when the user does not have perms to modify the question", () => {- const question = {- canWrite: () => false,- getModerationReviews: () => [],- id: () => 1,- };-it("should not render revert action buttons", async () => {- await setup({ question });+ await setup({ canWrite: false });expect(() => screen.getByTestId("question-revert-button")).toThrow();});});describe("when the user does have perms to modify the question", () => {- const question = {- canWrite: () => true,- getModerationReviews: () => [],- id: () => 1,- };-it("should render revert action buttons", async () => {- await setup({ question });+ await setup({ canWrite: true });expect(screen.getByTestId("question-revert-button")).toBeInTheDocument();});});diff --git a/frontend/src/metabase/query_builder/components/Warnings.unit.spec.js b/frontend/src/metabase/query_builder/components/Warnings.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/query_builder/components/Warnings.unit.spec.jsrename to frontend/src/metabase/query_builder/components/Warnings.unit.spec.tsxdiff --git a/frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.unit.spec.tsxindex 2dc0b5206d4..53bce4f5201 100644--- a/frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.unit.spec.tsx+++ b/frontend/src/metabase/query_builder/components/view/sidebars/ChartSettingsSidebar.unit.spec.tsx@@ -36,7 +36,7 @@ describe("ChartSettingsSidebar", () => {},});- it("should hide the title when showSidebarTitle is false", () => {+ it("hides the gauge options header while keeping formatting sections visible", () => {renderWithProviders(<ChartSettingsSidebarquestion={table.question().setDisplay("gauge")}@@ -61,7 +61,7 @@ describe("ChartSettingsSidebar", () => {expect(screen.getByText("Ranges")).toBeInTheDocument();});- it("should not hide the title when showSidebarTitle is false", () => {+ it("shows the number options header for scalar display when showSidebarTitle is true", () => {renderWithProviders(<ChartSettingsSidebarquestion={table.question().setDisplay("scalar")}