Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Ensure we catch semantic search errors with failover and prometheus metrics (#68639)

Noah Mosscb4238760641
diff --git a/enterprise/backend/src/metabase_enterprise/semantic_search/core.clj b/enterprise/backend/src/metabase_enterprise/semantic_search/core.clj
index d55c00f5700..0e989215cae 100644
--- a/enterprise/backend/src/metabase_enterprise/semantic_search/core.clj
+++ b/enterprise/backend/src/metabase_enterprise/semantic_search/core.clj
@@ -79,8 +79,12 @@
deduped-results (m/distinct-by (juxt :model :id) combined-results)]
(take total-limit deduped-results)))))
(catch Exception e
- (log/error e "Error executing semantic search")
- (throw (ex-info "Error executing semantic search" {:type :semantic-search-error} e)))))
+ (log/error e "Error executing semantic search, falling back to appdb")
+ (let [fallback (fallback-engine)]
+ (analytics/inc! :metabase-search/semantic-error-fallback {:fallback-engine fallback})
+ (if fallback
+ (search.engine/results (assoc search-ctx :search-engine fallback))
+ (throw (ex-info "Error executing semantic search" {:type :semantic-search-error} e)))))))
(defenterprise update-index!
"Enterprise implementation of semantic index updating."
diff --git a/enterprise/backend/test/metabase_enterprise/semantic_search/core_test.clj b/enterprise/backend/test/metabase_enterprise/semantic_search/core_test.clj
index 613b8b25289..b23403a9c7d 100644
--- a/enterprise/backend/test/metabase_enterprise/semantic_search/core_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/semantic_search/core_test.clj
@@ -223,3 +223,23 @@
(testing ":search-string is empty"
(let [results (semantic.core/results (assoc search-ctx :search-string ""))]
(is (= fallback-results results))))))))))
+
+(deftest test-semantic-search-error-fallback
+ (testing "semantic search falls back to appdb when it throws an error"
+ (mt/with-premium-features #{:semantic-search}
+ (let [fallback-results [(make-card-result 1 "fallback-card-1")
+ (make-card-result 2 "fallback-card-2")]
+ search-ctx search-context
+ metrics (atom {})]
+ (with-redefs [semantic.pgvector-api/query (fn [& _]
+ (throw (ex-info "Semantic search unavailable" {})))
+ search.engine/results (fn [ctx]
+ (case (:search-engine ctx)
+ :search.engine/semantic (semantic.core/results ctx)
+ fallback-results))
+ analytics/inc! (fn [metric & _args]
+ (swap! metrics update metric (fnil inc 0)))]
+ (let [results (semantic.core/results search-ctx)]
+ (is (= fallback-results results))
+ (is (= 1 (:metabase-search/semantic-error-fallback @metrics))
+ "Should increment semantic-error-fallback metric on error")))))))
diff --git a/src/metabase/analytics/prometheus.clj b/src/metabase/analytics/prometheus.clj
index 3f1c85d00f5..e8c547576bd 100644
--- a/src/metabase/analytics/prometheus.clj
+++ b/src/metabase/analytics/prometheus.clj
@@ -357,6 +357,9 @@
(prometheus/counter :metabase-search/semantic-fallback-triggered
{:description "Number of times semantic search triggered fallback to appdb search due to insufficient results"
:labels [:fallback-engine]})
+ (prometheus/counter :metabase-search/semantic-error-fallback
+ {:description "Number of times semantic search failed with an error and fell back to another engine"
+ :labels [:fallback-engine]})
(prometheus/histogram :metabase-search/semantic-results-before-fallback
{:description "Distribution of result counts from semantic search when fallback is triggered"
:buckets [0 1 5 10 20 50 100]})