The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Require mutating MCP tools to declare destructiveHint (#84482)
Chris Trutercbadcb2a36b7
diff --git a/test/metabase/mcp/v2/registry_test.clj b/test/metabase/mcp/v2/registry_test.cljindex c6fd5be092c..f4d63ad44c9 100644--- a/test/metabase/mcp/v2/registry_test.clj+++ b/test/metabase/mcp/v2/registry_test.clj@@ -427,6 +427,17 @@(testing tool-name(is (contains? mutating tool-name))))))))+(def ^:private additive-only-tools+ "Names of the mutating tools that declare `destructiveHint false`, because they only create."+ #{"duplicate_content"})++;; The registry defaults `destructiveHint` to false, so this turns that default around for mutating tools.+(deftest mutating-tools-are-destructive-test+ (testing "a mutating tool declares itself destructive unless it only creates (#84324)"+ (let [hints (update-vals (mutating-tools) (comp :destructiveHint :annotations))]+ (is (= (zipmap additive-only-tools (repeat false))+ (into {} (remove (comp true? val)) hints))))))+(deftest delivery-tools-are-open-world-test(testing "delivery tools are open-world: they send to email addresses and Slack channels outside Metabase"(let [delivery (filter #(= "agent:delivery:write" (:scope %)) (@#'registry/manifest))]