Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix clickhouse transform flake, hopefully (#70316)

Chris Truterccd3e61ff013
diff --git a/enterprise/backend/test/metabase_enterprise/workspaces/api_test.clj b/enterprise/backend/test/metabase_enterprise/workspaces/api_test.clj
index 6b8e3cc8687..a056b3214ae 100644
--- a/enterprise/backend/test/metabase_enterprise/workspaces/api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/workspaces/api_test.clj
@@ -1452,14 +1452,14 @@
:not_run []}
(run!))))))))
-(deftest dry-run-workspace-transform-test
+(deftest dry-run-workspace-transform-api-test
(testing "POST /api/ee/workspace/:id/transform/:txid/dry-run returns 404 if transform not in workspace"
(ws.tu/with-workspaces! [ws1 {:name "Workspace 1"}
ws2 {:name "Workspace 2"}]
(mt/with-temp [:model/Transform x1 {:name "Transform in WS1"
:source {:type "query"
:query (mt/native-query
- {:query "SELECT 1 as id, 'hello' as name UNION ALL SELECT 2, 'world' ORDER BY 1"})}
+ {:query "SELECT * FROM (SELECT 1 as id, 'hello' as name UNION ALL SELECT 2, 'world') t ORDER BY 1"})}
:target {:type "table"
:database (mt/id)
:schema "public"
diff --git a/enterprise/backend/test/metabase_enterprise/workspaces/execute_test.clj b/enterprise/backend/test/metabase_enterprise/workspaces/execute_test.clj
index 8550f326742..591602563e8 100644
--- a/enterprise/backend/test/metabase_enterprise/workspaces/execute_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/workspaces/execute_test.clj
@@ -61,13 +61,13 @@
{:xf (t2/count :model/Transform)
:xfrun (t2/count :model/TransformRun)})))))))
-(deftest dry-run-workspace-transform-test
+(deftest dry-run-sql-workspace-transform-test
(testing "Dry-running a workspace transform returns rows without persisting"
(let [workspace (ws.tu/create-ready-ws! "Dry-Run Test Workspace")
db-id (:database_id workspace)
body {:name "Dry-Run Transform"
:source {:type "query"
- :query (mt/native-query {:query "SELECT 1 as id, 'hello' as name UNION ALL SELECT 2, 'world' ORDER BY 1"})}
+ :query (mt/native-query {:query "SELECT * FROM (SELECT 1 as id, 'hello' as name UNION ALL SELECT 2, 'world') t ORDER BY 1"})}
:target {:type "table"
:database db-id
:schema nil