Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

update edit table metadata button link to stay in data studio (#69187)

Nick Fitzpatrickce11a50d6432
diff --git a/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/TargetSection.unit.spec.tsx b/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/TargetSection.unit.spec.tsx
index c80ae6db9f7..66250768345 100644
--- a/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/TargetSection.unit.spec.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/TargetSection.unit.spec.tsx
@@ -16,6 +16,7 @@ import type {
} from "metabase-types/api";
import {
createMockDatabase,
+ createMockTable,
createMockTokenFeatures,
createMockTransform,
createMockTransformOwner,
@@ -165,3 +166,34 @@ describe("OwnerSection", () => {
expect(screen.getByText("Ownership")).toBeInTheDocument();
});
});
+
+describe("TargetSection", () => {
+ it("should not render a edit table metadata button when the target table does not exist", async () => {
+ setup({});
+
+ expect(
+ await screen.findByRole("button", { name: /Change target/ }),
+ ).toBeInTheDocument();
+
+ expect(
+ screen.queryByRole("link", { name: /Edit this table/ }),
+ ).not.toBeInTheDocument();
+ });
+ it("should link you to a page where you can edit the target tables metadata", async () => {
+ setup({
+ transform: createMockTransform({
+ table: createMockTable(),
+ }),
+ });
+
+ expect(
+ await screen.findByRole("button", { name: /Change target/ }),
+ ).toBeInTheDocument();
+ expect(
+ await screen.findByRole("link", { name: /Edit this table/ }),
+ ).toHaveAttribute(
+ "href",
+ expect.stringContaining("/data-studio/data/database"),
+ );
+ });
+});
diff --git a/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx b/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx
index cbe00a02502..d7311c6a4cb 100644
--- a/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx
@@ -237,7 +237,7 @@ function EditMetadataButton({ transform }: EditMetadataButtonProps) {
return (
<Button
component={Link}
- to={Urls.dataModel({
+ to={Urls.dataStudioData({
databaseId: table.db_id,
schemaName: table.schema,
tableId: table.id,