Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Restore sdk backward compat tests (#65154)

Timofey Kachalovd1c40b6c81bd
diff --git a/.github/workflows/e2e-component-tests-embedding-sdk-backward-compatibility.yml b/.github/workflows/e2e-component-tests-embedding-sdk-backward-compatibility.yml
index 5f54c023496..edeb510586b 100644
--- a/.github/workflows/e2e-component-tests-embedding-sdk-backward-compatibility.yml
+++ b/.github/workflows/e2e-component-tests-embedding-sdk-backward-compatibility.yml
@@ -1,4 +1,4 @@
-# Thi workflow does the backward compatibility tests
+# This workflow does the backward compatibility tests
# between the Embedding SDK package of version N and Embedding SDK Bundle of version N - 1
# N - 1 is a target of a PR
name: Embedding SDK backward-compatibility E2E Component Tests
diff --git a/.github/workflows/embedding-sdk.yml b/.github/workflows/embedding-sdk.yml
index fdf106a9a76..f55a06ff41e 100644
--- a/.github/workflows/embedding-sdk.yml
+++ b/.github/workflows/embedding-sdk.yml
@@ -148,16 +148,13 @@ jobs:
with:
cached-embedding-sdk-dist-artifact-name: embedding-sdk-${{ github.event.pull_request.head.sha || github.sha }}
- # Tests disabled to unblock switching the CI to use the staging tokens.
- # High priority issue tracked here: https://linear.app/metabase/issue/EMB-934/re-enable-sdk-backward-compatibility-e2e-tests-in-ci
- #
- # e2e-component-tests-embedding-sdk-backward-compatibility:
- # name: "SDK e2e backward compatibility tests"
- # uses: ./.github/workflows/e2e-component-tests-embedding-sdk-backward-compatibility.yml
- # needs: [build]
- # secrets: inherit
- # with:
- # cached-embedding-sdk-dist-artifact-name: embedding-sdk-${{ github.event.pull_request.head.sha || github.sha }}
+ e2e-component-tests-embedding-sdk-backward-compatibility:
+ name: "SDK e2e backward compatibility tests"
+ uses: ./.github/workflows/e2e-component-tests-embedding-sdk-backward-compatibility.yml
+ needs: [build]
+ secrets: inherit
+ with:
+ cached-embedding-sdk-dist-artifact-name: embedding-sdk-${{ github.event.pull_request.head.sha || github.sha }}
embedding-sdk-tests-result:
needs:
@@ -165,8 +162,7 @@ jobs:
- embedding-sdk-docs-snippets-type-check
- embedding-sdk-api-documentation-generation-validation
- sdk-e2e-tests
- # Uncomment the line below when EMB-934 gets resolved
- # - e2e-component-tests-embedding-sdk-backward-compatibility
+ - e2e-component-tests-embedding-sdk-backward-compatibility
if: always() && !cancelled()
runs-on: ubuntu-latest
timeout-minutes: 5