Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove failed bigquery fix attempt (#75344)

Riley Thompsond2022319503d
diff --git a/enterprise/backend/test/metabase_enterprise/workspaces/e2e_test.clj b/enterprise/backend/test/metabase_enterprise/workspaces/e2e_test.clj
index 2635add7d0b..122709e8164 100644
--- a/enterprise/backend/test/metabase_enterprise/workspaces/e2e_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/workspaces/e2e_test.clj
@@ -338,20 +338,6 @@
(let [{ws-id :id} (ws/create-workspace! {:name (str "ws-e2e-" run-id)
:creator_id (mt/user->id :crowberto)})]
(try
- ;; --- Pre-cleanup: delete any stale BigQuery service account whose
- ;; name collides with the one provisioning will create. In CI the
- ;; app DB is fresh each run so workspace IDs restart at 1, but the
- ;; shared GCP project may still hold `mb-ws-1` from a prior run.
- ;; A stale SA carries outdated IAM bindings; reusing it causes
- ;; `listDatasets` under impersonation to return empty within the
- ;; wait window, triggering "cannot find any matching datasets".
- (when (= admin-driver :bigquery-cloud-sdk)
- (let [iam ((requiring-resolve 'metabase.driver.bigquery-cloud-sdk.workspace-test-util/iam-client) admin-details)
- pid ((requiring-resolve 'metabase.driver.bigquery-cloud-sdk.workspace-test-util/project-id) admin-details)]
- (try
- ((requiring-resolve 'metabase.driver.bigquery-cloud-sdk.workspace-test-util/delete-sa-direct!)
- iam pid {:id ws-id})
- (finally (.close ^java.lang.AutoCloseable iam)))))
;; --- Stage 1: provision via the workspace provisioning entrypoint.
;; Drives the same `init-workspace-isolation!` + `grant-workspace-read-access!`
;; multimethods, but through `provisioning/provision-single!`, which writes