Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

fix typo (#66771)

Riley Thompsond35840366718
diff --git a/src/metabase/revisions/impl/segment.clj b/src/metabase/revisions/impl/segment.clj
index 09c6430ba5e..f1dbde9f4c8 100644
--- a/src/metabase/revisions/impl/segment.clj
+++ b/src/metabase/revisions/impl/segment.clj
@@ -5,7 +5,7 @@
[metabase.revisions.models.revision :as revision]))
(def ^:private excluded-columns-for-segment-revision
- #{:created_at :updated_at :dependency_analysis_versions})
+ #{:created_at :updated_at :dependency_analysis_version})
(defmethod revision/serialize-instance :model/Segment
[_model _id instance]
diff --git a/test/metabase/revisions/impl/segment_test.clj b/test/metabase/revisions/impl/segment_test.clj
index 160dddcbb90..4787c226c09 100644
--- a/test/metabase/revisions/impl/segment_test.clj
+++ b/test/metabase/revisions/impl/segment_test.clj
@@ -26,7 +26,10 @@
:archived false}
(into {} (-> (revision/serialize-instance :model/Segment (:id segment) segment)
(update :id boolean)
- (update :table_id boolean)))))))
+ (update :table_id boolean)))))
+ (testing "excluded columns are not present"
+ (is (not-any? #{:created_at :updated_at :dependency_analysis_version}
+ (keys (revision/serialize-instance :model/Segment (:id segment) segment)))))))
(deftest ^:parallel diff-segments-test
(mt/with-temp [:model/Database {database-id :id} {}