Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Convert QuestionSummarizeWidget to TypeScript (#69071)

Fraserd3c44902a17c
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionSummarizeWidget.jsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionSummarizeWidget.tsx
similarity index 76%
rename from frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionSummarizeWidget.jsx
rename to frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionSummarizeWidget.tsx
index 85917be80f7..b8985d4eb78 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionSummarizeWidget.jsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionSummarizeWidget.tsx
@@ -1,19 +1,27 @@
-/* eslint-disable react/prop-types */
import cx from "classnames";
import { t } from "ttag";
import { useRegisterShortcut } from "metabase/palette/hooks/useRegisterShortcut";
import { Button, Icon } from "metabase/ui";
import * as Lib from "metabase-lib";
+import type Question from "metabase-lib/v1/Question";
+import type { QueryBuilderMode } from "metabase-types/store";
import ViewTitleHeaderS from "../ViewTitleHeader.module.css";
+interface QuestionSummarizeWidgetProps {
+ isShowingSummarySidebar: boolean;
+ onEditSummary: () => void;
+ onCloseSummary: () => void;
+ className?: string;
+}
+
export function QuestionSummarizeWidget({
isShowingSummarySidebar,
onEditSummary,
onCloseSummary,
className,
-}) {
+}: QuestionSummarizeWidgetProps) {
const handleClick = () => {
if (isShowingSummarySidebar) {
onCloseSummary();
@@ -51,6 +59,11 @@ QuestionSummarizeWidget.shouldRender = ({
queryBuilderMode,
isObjectDetail,
isActionListVisible,
+}: {
+ question: Question;
+ queryBuilderMode: QueryBuilderMode;
+ isObjectDetail: boolean;
+ isActionListVisible: boolean;
}) => {
const { isEditable, isNative } = Lib.queryDisplayInfo(question.query());
return (