Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix broken Metabase icon in SDK banner when using EE with license (#69215)

Mahatthana (Kelvin) Nomsawadid3f97ef81cfd
diff --git a/eslint.config.mjs b/eslint.config.mjs
index e4f31ed3ea0..bf38dcfc5f6 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -520,7 +520,7 @@ const configs = [
"no-restricted-imports": [
"error",
{
- ...baseMetabaseRestrictedConfig,
+ paths: baseMetabaseRestrictedConfig.paths,
patterns: [
...baseMetabaseRestrictedConfig.patterns,
{
@@ -716,13 +716,19 @@ const configs = [
"no-restricted-imports": [
"error",
{
- ...baseMetabaseRestrictedConfig,
+ paths: baseMetabaseRestrictedConfig.paths,
patterns: [
...baseMetabaseRestrictedConfig.patterns,
{
group: ["__support__/**", "!__support__/metadata"],
message: TEST_FILES_NAME_PATTERN_ERROR_MESSAGE,
},
+ {
+ group: ["metabase/common/components/LogoIcon"],
+ importNames: ["LogoIcon"],
+ message:
+ "Do not use LogoIcon in the SDK. With custom Icon, it doesn't work because it uses the Metabase instance's relative path.",
+ },
],
},
],
@@ -755,7 +761,7 @@ const configs = [
"no-restricted-imports": [
"error",
{
- ...baseMetabaseRestrictedConfig,
+ paths: baseMetabaseRestrictedConfig.paths,
patterns: [
...baseMetabaseRestrictedConfig.patterns,
{
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx
index c6b7b4d494f..008661858f0 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx
@@ -8,7 +8,7 @@ import { useSdkDispatch } from "embedding-sdk-bundle/store";
import { setUsageProblem } from "embedding-sdk-bundle/store/reducer";
import type { SdkUsageProblem } from "embedding-sdk-bundle/types/usage-problem";
import { ExternalLink } from "metabase/common/components/ExternalLink";
-import { LogoIcon as MetabaseLogo } from "metabase/common/components/LogoIcon";
+import { DefaultLogoIcon } from "metabase/common/components/LogoIcon";
import { originalColors } from "metabase/lib/colors";
import { Button, Card, Flex, Icon, Popover, Stack, Text } from "metabase/ui";
@@ -59,7 +59,7 @@ export const SdkUsageProblemBanner = ({
i-should-be-flex="true"
>
<Flex bg="white" px="sm" className={S.Logo} align="center">
- <MetabaseLogo height={24} />
+ <DefaultLogoIcon height={24} />
</Flex>
<Flex justify="center" align="center" className={S.Content}>