Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Don't show run overlay on between field filter with no values (#71097)

Riley Thompsond6a45bdf993e
diff --git a/e2e/test/scenarios/native-filters/native-filters-reproductions.cy.spec.js b/e2e/test/scenarios/native-filters/native-filters-reproductions.cy.spec.js
index e935a1fc998..f9e6996ee26 100644
--- a/e2e/test/scenarios/native-filters/native-filters-reproductions.cy.spec.js
+++ b/e2e/test/scenarios/native-filters/native-filters-reproductions.cy.spec.js
@@ -1306,3 +1306,39 @@ describe("issue 63537", () => {
H.assertQueryBuilderRowCount(2);
});
});
+
+describe("issue 70311", () => {
+ beforeEach(() => {
+ H.restore();
+ cy.signInAsAdmin();
+ cy.intercept("POST", "/api/card/*/query").as("cardQuery");
+ });
+
+ it("should not show the run overlay for a saved question with an empty between field filter (metabase#70311)", () => {
+ H.createNativeQuestion(
+ {
+ name: "70311",
+ native: {
+ query: "SELECT * FROM PRODUCTS WHERE {{filter}} LIMIT 5",
+ "template-tags": {
+ filter: {
+ id: "a3b95feb-b6d2-33b6-660b-bb656f59b1d7",
+ name: "filter",
+ "display-name": "Filter",
+ type: "dimension",
+ dimension: ["field", PRODUCTS.RATING, null],
+ "widget-type": "number/between",
+ default: null,
+ },
+ },
+ },
+ },
+ { visitQuestion: true },
+ );
+
+ cy.wait("@cardQuery");
+
+ cy.findByTestId("query-visualization-root").should("be.visible");
+ cy.icon("play").should("not.exist");
+ });
+});
diff --git a/src/metabase/lib/schema/parameter.cljc b/src/metabase/lib/schema/parameter.cljc
index d36cf9af2e8..93645b4835f 100644
--- a/src/metabase/lib/schema/parameter.cljc
+++ b/src/metabase/lib/schema/parameter.cljc
@@ -342,8 +342,8 @@
:number/between
(let [[l u] (:value param)]
(cond-> param
- (nil? u) (assoc :type :number/>=, :value [l])
- (nil? l) (assoc :type :number/<=, :value [u])))
+ (and l (nil? u)) (assoc :type :number/>=, :value [l])
+ (and u (nil? l)) (assoc :type :number/<=, :value [u])))
param))))
(mr/def ::id
diff --git a/test/metabase/lib/schema/parameter_test.cljc b/test/metabase/lib/schema/parameter_test.cljc
index 21a71532da7..9a5f8e4a378 100644
--- a/test/metabase/lib/schema/parameter_test.cljc
+++ b/test/metabase/lib/schema/parameter_test.cljc
@@ -90,6 +90,22 @@
(is (= {:id "x", :type :text}
(lib/normalize ::lib.schema.parameter/parameter {:id "x"}))))
+(deftest ^:parallel normalize-number-between-test
+ (testing "number/between normalization (#70311)"
+ (are [value expected-type expected-value]
+ (= {:type expected-type, :value expected-value}
+ (select-keys
+ (lib/normalize ::lib.schema.parameter/parameter {:type "number/between", :value value})
+ [:type :value]))
+ ;; both nil — should stay as number/between
+ [nil nil] :number/between [nil nil]
+ nil :number/between nil
+ ;; one side set — should simplify
+ [5 nil] :number/>= [5]
+ [nil 10] :number/<= [10]
+ ;; both set — should stay as number/between
+ [5 10] :number/between [5 10])))
+
(deftest ^:parallel normalize-invalid-widget-type-test
(testing "Decode an invalid namespaced widget type like `:category/=` to the matching unnamespaced type (`:category`)"
(is (= :category