The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix MLv2 error with audit v1 (#63772)
Alexander Polyankind6c7ef8e6386
diff --git a/frontend/src/metabase-lib/v1/parameters/utils/template-tags.ts b/frontend/src/metabase-lib/v1/parameters/utils/template-tags.tsindex ade224875f8..56411a84256 100644--- a/frontend/src/metabase-lib/v1/parameters/utils/template-tags.ts+++ b/frontend/src/metabase-lib/v1/parameters/utils/template-tags.ts@@ -5,6 +5,7 @@ import Question from "metabase-lib/v1/Question";import type Metadata from "metabase-lib/v1/metadata/Metadata";import type { ParameterWithTarget } from "metabase-lib/v1/parameters/types";import { getTemplateTagFromTarget } from "metabase-lib/v1/parameters/utils/targets";+import { InternalQuery } from "metabase-lib/v1/queries/InternalQuery";import type {Card,Parameter,@@ -89,6 +90,10 @@ export function getTemplateTagParameters(export function getTemplateTags(card: Card, metadata: Metadata): TemplateTag[] {const question = new Question(card, metadata);+ // this code path is used by the last audit v1 query, `bad_table`+ if (InternalQuery.isDatasetQueryType(question.datasetQuery())) {+ return [];+ }const query = question.query();const { isNative } = Lib.queryDisplayInfo(query);return isNative ? Object.values(Lib.templateTags(question.query())) : [];diff --git a/frontend/src/metabase-lib/v1/parameters/utils/template-tags.unit.spec.js b/frontend/src/metabase-lib/v1/parameters/utils/template-tags.unit.spec.jsindex 85566f2791e..f407780e7a0 100644--- a/frontend/src/metabase-lib/v1/parameters/utils/template-tags.unit.spec.js+++ b/frontend/src/metabase-lib/v1/parameters/utils/template-tags.unit.spec.js@@ -16,6 +16,17 @@ describe("parameters/utils/cards", () => {expect(getTemplateTags(card)).toEqual([]);});+ it("should return an empty array for an internal query", () => {+ const card = {+ dataset_query: {+ type: "internal",+ fn: "metabase-enterprise.audit-app.pages.queries/bad-table",+ args: [],+ },+ };+ expect(getTemplateTags(card)).toEqual([]);+ });+it("should return an empty array for a non-parameterized query", () => {const card = {dataset_query: {