Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Check database features through the API helper, not the v1 wrapper (#80158)

Romeo Van Snickd7e2aa3d5b27
diff --git a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/index.tsx b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/index.tsx
index 15ca308311b..b64a45922b5 100644
--- a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/index.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/index.tsx
@@ -1,6 +1,7 @@
import { t } from "ttag";
import { modalRoute } from "metabase/common/components/ModalRoute";
+import { hasFeature } from "metabase/databases";
import {
PLUGIN_ADMIN_PERMISSIONS_DATABASE_ACTIONS,
PLUGIN_ADMIN_PERMISSIONS_DATABASE_GROUP_ROUTES,
@@ -70,7 +71,7 @@ export function initializePlugin() {
database,
) => [
...options,
- ...(database.hasFeature("connection-impersonation")
+ ...(hasFeature(database, "connection-impersonation")
? [IMPERSONATED_PERMISSION_OPTION]
: []),
BLOCK_PERMISSION_OPTION,
diff --git a/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/utils.tsx b/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/utils.tsx
index c87626df83d..de9411f7fb9 100644
--- a/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/utils.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/utils.tsx
@@ -4,10 +4,10 @@ import { t } from "ttag";
import { Link } from "metabase/common/components/Link";
import {
hasActionsEnabled,
- hasFeature,
hasTableEditingEnabled,
hasWritableConnectionDetails,
} from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import { Text } from "metabase/ui";
import type { Database } from "metabase-types/api";
diff --git a/enterprise/frontend/src/metabase-enterprise/model_persistence/components/ModelCacheControl/ModelCacheControl.tsx b/enterprise/frontend/src/metabase-enterprise/model_persistence/components/ModelCacheControl/ModelCacheControl.tsx
index 10739c9d3ef..d254a6f64d5 100644
--- a/enterprise/frontend/src/metabase-enterprise/model_persistence/components/ModelCacheControl/ModelCacheControl.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/model_persistence/components/ModelCacheControl/ModelCacheControl.tsx
@@ -7,7 +7,7 @@ import {
useUnpersistModelMutation,
} from "metabase/api";
import { DelayedLoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper/DelayedLoadingAndErrorWrapper";
-import { hasFeature } from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import { Switch, Tooltip } from "metabase/ui";
import type Question from "metabase-lib/v1/Question";
import type { ModelCacheRefreshStatus } from "metabase-types/api";
diff --git a/enterprise/frontend/src/metabase-enterprise/replacement/pages/MigrateModelsPage/ReplaceWithTransformModal/ReplaceWithTransformModal.tsx b/enterprise/frontend/src/metabase-enterprise/replacement/pages/MigrateModelsPage/ReplaceWithTransformModal/ReplaceWithTransformModal.tsx
index 4f488858fa6..c233df2eb0f 100644
--- a/enterprise/frontend/src/metabase-enterprise/replacement/pages/MigrateModelsPage/ReplaceWithTransformModal/ReplaceWithTransformModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/replacement/pages/MigrateModelsPage/ReplaceWithTransformModal/ReplaceWithTransformModal.tsx
@@ -9,7 +9,7 @@ import {
} from "metabase/api";
import FormCollectionPicker from "metabase/common/collections/containers/FormCollectionPicker";
import { DelayedLoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper/DelayedLoadingAndErrorWrapper";
-import { hasFeature } from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import {
Form,
FormErrorMessage,
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx
index 16fff393bfe..561d94c2f0f 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx
@@ -3,7 +3,7 @@ import {
useGetDatabaseQuery,
useListDatabasesQuery,
} from "metabase/api";
-import { hasFeature } from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import { DatabaseDataSelector } from "metabase/querying/common/components/DataSelector";
import { EditDefinitionButton } from "metabase/transforms/components/TransformEditor/EditDefinitionButton";
import { doesDatabaseSupportTransforms } from "metabase/transforms/utils";
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/DatabaseModelFeaturesSection.tsx b/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/DatabaseModelFeaturesSection.tsx
index eba5ad1e015..8025fd36127 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/DatabaseModelFeaturesSection.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/DatabaseModelFeaturesSection.tsx
@@ -4,8 +4,8 @@ import { t } from "ttag";
import {
hasActionsEnabled,
hasDbRoutingEnabled,
- hasFeature,
} from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import { Flex } from "metabase/ui";
import type { Database, DatabaseData, DatabaseId } from "metabase-types/api";
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/ModelCachingControl/ModelCachingControl.tsx b/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/ModelCachingControl/ModelCachingControl.tsx
index bec46273e6b..4b9a69c8f7a 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/ModelCachingControl/ModelCachingControl.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/ModelCachingControl/ModelCachingControl.tsx
@@ -7,7 +7,7 @@ import {
} from "metabase/api";
import { ExternalLink } from "metabase/common/components/ExternalLink";
import { useDocsUrl } from "metabase/common/hooks";
-import { hasFeature } from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import { useSetting } from "metabase/settings";
import { Alert, Box, Flex, Icon, Switch } from "metabase/ui";
import { getModelCacheSchemaName } from "metabase-lib/v1/metadata/utils/models";
diff --git a/frontend/src/metabase/common/utils/database.ts b/frontend/src/metabase/common/utils/database.ts
index ff7fb1dc084..916d1a04b68 100644
--- a/frontend/src/metabase/common/utils/database.ts
+++ b/frontend/src/metabase/common/utils/database.ts
@@ -1,13 +1,7 @@
import { t } from "ttag";
import { SAVED_QUESTIONS_VIRTUAL_DB_ID } from "metabase-lib/v1/metadata/utils/saved-questions";
-import type {
- Card,
- Dashboard,
- Database,
- DatabaseFeature,
- DatabaseId,
-} from "metabase-types/api";
+import type { Card, Dashboard, Database, DatabaseId } from "metabase-types/api";
export const isDbModifiable = (
database:
@@ -36,13 +30,6 @@ export const getDbNotModifiableMessage = (
t`This database is managed by Metabase Cloud and cannot be modified.`;
};
-export const hasFeature = (
- database: Pick<Database, "features">,
- feature: DatabaseFeature,
-) => {
- return database.features?.includes(feature) ?? false;
-};
-
export const hasActionsEnabled = (database: Pick<Database, "settings">) => {
return Boolean(database.settings?.["database-enable-actions"]);
};
diff --git a/frontend/src/metabase/databases/index.ts b/frontend/src/metabase/databases/index.ts
new file mode 100644
index 00000000000..1c66ea744e3
--- /dev/null
+++ b/frontend/src/metabase/databases/index.ts
@@ -0,0 +1,8 @@
+// The module's public interface.
+// Names absent here are module-private on purpose — add them only when a real consumer needs them.
+
+export {
+ hasFeature,
+ hasRequiredFeature,
+ supportsJoins,
+} from "./utils/features";
diff --git a/frontend/src/metabase/databases/utils/features.ts b/frontend/src/metabase/databases/utils/features.ts
new file mode 100644
index 00000000000..36e014784e1
--- /dev/null
+++ b/frontend/src/metabase/databases/utils/features.ts
@@ -0,0 +1,31 @@
+import type { Database, DatabaseFeature } from "metabase-types/api";
+
+export const hasFeature = (
+ database: Pick<Database, "features">,
+ feature: DatabaseFeature,
+) => {
+ return database.features?.includes(feature) ?? false;
+};
+
+/**
+ * The v1 `Database.hasFeature` treated "join" as any join type. It is not a
+ * `DatabaseFeature` of its own, so it needs naming here.
+ */
+const JOIN_FEATURES: DatabaseFeature[] = [
+ "left-join",
+ "right-join",
+ "inner-join",
+ "full-join",
+];
+
+export const supportsJoins = (database: Pick<Database, "features">) =>
+ JOIN_FEATURES.some((feature) => hasFeature(database, feature));
+
+/**
+ * For features that are optional on the thing requiring them, such as an
+ * expression clause with no `requiresFeature`. No requirement means supported.
+ */
+export const hasRequiredFeature = (
+ database: Pick<Database, "features">,
+ feature: DatabaseFeature | null | undefined,
+) => feature == null || hasFeature(database, feature);
diff --git a/frontend/src/metabase/databases/utils/features.unit.spec.ts b/frontend/src/metabase/databases/utils/features.unit.spec.ts
new file mode 100644
index 00000000000..94cd7c2b521
--- /dev/null
+++ b/frontend/src/metabase/databases/utils/features.unit.spec.ts
@@ -0,0 +1,51 @@
+import { createMockDatabase } from "metabase-types/api/mocks";
+
+import { hasFeature, hasRequiredFeature, supportsJoins } from "./features";
+
+describe("hasFeature", () => {
+ it("is true when the database lists the feature", () => {
+ expect(
+ hasFeature(
+ createMockDatabase({ features: ["expressions"] }),
+ "expressions",
+ ),
+ ).toBe(true);
+ });
+
+ it("is false when the database has no features", () => {
+ expect(
+ hasFeature(createMockDatabase({ features: [] }), "expressions"),
+ ).toBe(false);
+ });
+});
+
+describe("supportsJoins", () => {
+ it.each(["left-join", "right-join", "inner-join", "full-join"] as const)(
+ "treats %s as join support",
+ (feature) => {
+ expect(supportsJoins(createMockDatabase({ features: [feature] }))).toBe(
+ true,
+ );
+ },
+ );
+
+ it("is false when the database supports no join type", () => {
+ expect(
+ supportsJoins(createMockDatabase({ features: ["expressions"] })),
+ ).toBe(false);
+ });
+});
+
+describe("hasRequiredFeature", () => {
+ const database = createMockDatabase({ features: ["expressions"] });
+
+ it("is true when nothing is required", () => {
+ expect(hasRequiredFeature(database, null)).toBe(true);
+ expect(hasRequiredFeature(database, undefined)).toBe(true);
+ });
+
+ it("defers to the feature when one is required", () => {
+ expect(hasRequiredFeature(database, "expressions")).toBe(true);
+ expect(hasRequiredFeature(database, "nested-queries")).toBe(false);
+ });
+});
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/utils.ts b/frontend/src/metabase/query_builder/components/view/ViewHeader/utils.ts
index 17e75187708..27895c88a7d 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/utils.ts
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/utils.ts
@@ -1,3 +1,4 @@
+import { hasFeature } from "metabase/databases";
import * as Lib from "metabase-lib";
import type Question from "metabase-lib/v1/Question";
@@ -8,7 +9,10 @@ import type Question from "metabase-lib/v1/Question";
*/
export const canExploreResults = (question: Question): boolean => {
const { isEditable, isNative } = Lib.queryDisplayInfo(question.query());
- const canNest = Boolean(question.database()?.hasFeature("nested-queries"));
+ const canNest = Boolean(
+ question.database() != null &&
+ hasFeature(question.database()!, "nested-queries"),
+ );
return (
isNative &&
diff --git a/frontend/src/metabase/querying/common/components/AggregationPicker/AggregationPicker.tsx b/frontend/src/metabase/querying/common/components/AggregationPicker/AggregationPicker.tsx
index fbcc6c0a231..d467b49d2e2 100644
--- a/frontend/src/metabase/querying/common/components/AggregationPicker/AggregationPicker.tsx
+++ b/frontend/src/metabase/querying/common/components/AggregationPicker/AggregationPicker.tsx
@@ -21,6 +21,7 @@ import {
import { Popover } from "metabase/common/components/MetadataInfo/Popover";
import { useToggle } from "metabase/common/hooks/use-toggle";
import { useTranslateContent } from "metabase/content-translation/hooks";
+import { hasFeature } from "metabase/databases";
import { QueryColumnPicker } from "metabase/querying/common/components/QueryColumnPicker";
import {
ExpressionWidget,
@@ -173,9 +174,8 @@ export function AggregationPicker({
const measures = Lib.availableMeasures(query, stageIndex);
const databaseId = Lib.databaseID(query);
const database = metadata.database(databaseId);
- const supportsCustomExpressions = database?.hasFeature(
- "expression-aggregations",
- );
+ const supportsCustomExpressions =
+ database != null && hasFeature(database, "expression-aggregations");
if (operators.length > 0) {
const operatorItems = operators.map((operator) =>
diff --git a/frontend/src/metabase/querying/components/expressions/Editor/HelpText/HelpText.tsx b/frontend/src/metabase/querying/components/expressions/Editor/HelpText/HelpText.tsx
index a57400fc936..3a6918d8207 100644
--- a/frontend/src/metabase/querying/components/expressions/Editor/HelpText/HelpText.tsx
+++ b/frontend/src/metabase/querying/components/expressions/Editor/HelpText/HelpText.tsx
@@ -11,6 +11,7 @@ import { t } from "ttag";
import { ExternalLink } from "metabase/common/components/ExternalLink";
import { Markdown } from "metabase/common/components/Markdown";
import { useDocsUrl } from "metabase/common/hooks";
+import { hasRequiredFeature } from "metabase/databases";
import {
type HelpText,
expressionModeSupportsClause,
@@ -91,7 +92,8 @@ export function HelpText({
const clause = helpText && getClauseDefinition(helpText.name);
const isSupported =
clause &&
- database?.hasFeature(clause?.requiresFeature) &&
+ database != null &&
+ hasRequiredFeature(database, clause?.requiresFeature) &&
expressionModeSupportsClause(expressionMode, clause.name);
const { url: docsUrl, showMetabaseLinks } = useDocsUrl(
diff --git a/frontend/src/metabase/querying/components/expressions/FunctionBrowser/utils.unit.spec.ts b/frontend/src/metabase/querying/components/expressions/FunctionBrowser/utils.unit.spec.ts
index 9801c84f11a..b5fee7e9315 100644
--- a/frontend/src/metabase/querying/components/expressions/FunctionBrowser/utils.unit.spec.ts
+++ b/frontend/src/metabase/querying/components/expressions/FunctionBrowser/utils.unit.spec.ts
@@ -12,13 +12,35 @@ function setup({
filter?: string;
expressionMode?: Lib.ExpressionMode;
} = {}) {
- const sampleDatabase = createSampleDatabase();
+ // Every feature a clause can require, so this exercises name filtering
+ // rather than feature gating.
+ const sampleDatabase = createSampleDatabase({
+ features: [
+ "advanced-math-expressions",
+ "collate",
+ "convert-timezone",
+ "datetime-diff",
+ "distinct-where",
+ "expressions",
+ "expressions/date",
+ "expressions/datetime",
+ "expressions/float",
+ "expressions/integer",
+ "expressions/text",
+ "expressions/today",
+ "percentile-aggregations",
+ "regex",
+ "regex/lookaheads-and-lookbehinds",
+ "split-part",
+ "standard-deviation-aggregations",
+ "window-functions/offset",
+ ],
+ });
const metadata = createMockMetadata({ databases: [sampleDatabase] });
const database = metadata.database(sampleDatabase.id);
if (!database) {
throw new Error("Error in test: sample database not found");
}
- database.hasFeature = jest.fn().mockReturnValue(true);
const results = getFilteredClauses({
filter,
diff --git a/frontend/src/metabase/querying/expressions/clause.ts b/frontend/src/metabase/querying/expressions/clause.ts
index 48e986aff00..b2784845514 100644
--- a/frontend/src/metabase/querying/expressions/clause.ts
+++ b/frontend/src/metabase/querying/expressions/clause.ts
@@ -1,5 +1,6 @@
import _ from "underscore";
+import { hasRequiredFeature } from "metabase/databases";
import { isNotNull } from "metabase/utils/types";
import type * as Lib from "metabase-lib";
import {
@@ -87,7 +88,11 @@ export function getSupportedClauses({
database?: Database | null;
}) {
return clausesForMode(expressionMode)
- .filter((clause) => database?.hasFeature(clause.requiresFeature))
+ .filter(
+ (clause) =>
+ database != null &&
+ hasRequiredFeature(database, clause.requiresFeature),
+ )
.filter(function disableOffsetInFilterExpressions(clause) {
const isOffset = clause.name === "offset";
const isFilterExpression = expressionMode === "filter";
diff --git a/frontend/src/metabase/querying/expressions/diagnostics/expression/check-supported-functions.ts b/frontend/src/metabase/querying/expressions/diagnostics/expression/check-supported-functions.ts
index 368b75be454..31f99c31807 100644
--- a/frontend/src/metabase/querying/expressions/diagnostics/expression/check-supported-functions.ts
+++ b/frontend/src/metabase/querying/expressions/diagnostics/expression/check-supported-functions.ts
@@ -1,5 +1,6 @@
import { t } from "ttag";
+import { hasRequiredFeature } from "metabase/databases";
import * as Lib from "metabase-lib";
import type Metadata from "metabase-lib/v1/metadata/Metadata";
@@ -35,7 +36,10 @@ export function checkSupportedFunctions({
if (!clause) {
return;
}
- if (!database?.hasFeature(clause.requiresFeature)) {
+ if (
+ database == null ||
+ !hasRequiredFeature(database, clause.requiresFeature)
+ ) {
error(node, t`Unsupported function ${clause.displayName}`);
}
});
diff --git a/frontend/src/metabase/querying/filters/components/FilterPicker/StringFilterPicker/StringFilterPicker.tsx b/frontend/src/metabase/querying/filters/components/FilterPicker/StringFilterPicker/StringFilterPicker.tsx
index 175998e9b83..b295f46bcc2 100644
--- a/frontend/src/metabase/querying/filters/components/FilterPicker/StringFilterPicker/StringFilterPicker.tsx
+++ b/frontend/src/metabase/querying/filters/components/FilterPicker/StringFilterPicker/StringFilterPicker.tsx
@@ -3,6 +3,7 @@ import { useMemo } from "react";
import { t } from "ttag";
import { MultiAutocompleteWithTranslation } from "metabase/common/components/MultiAutocomplete";
+import { hasFeature } from "metabase/databases";
import { useSelector } from "metabase/redux";
import { getMetadata } from "metabase/selectors/metadata";
import { Box, Checkbox, Flex } from "metabase/ui";
@@ -39,7 +40,9 @@ export function StringFilterPicker({
const metadata = useSelector(getMetadata);
const database = metadata.database(Lib.databaseID(query));
const supportsCaseSensitivity =
- database?.hasFeature("case-sensitivity-string-filter-options") ?? true;
+ (database != null &&
+ hasFeature(database, "case-sensitivity-string-filter-options")) ||
+ database == null;
const {
type,
diff --git a/frontend/src/metabase/querying/notebook/utils/steps.ts b/frontend/src/metabase/querying/notebook/utils/steps.ts
index 4baccee6f37..e6448a2d8d4 100644
--- a/frontend/src/metabase/querying/notebook/utils/steps.ts
+++ b/frontend/src/metabase/querying/notebook/utils/steps.ts
@@ -1,5 +1,6 @@
import _ from "underscore";
+import { hasFeature, supportsJoins } from "metabase/databases";
import type { Query } from "metabase-lib";
import * as Lib from "metabase-lib";
import type Question from "metabase-lib/v1/Question";
@@ -40,7 +41,7 @@ const STEPS: NotebookStepDef[] = [
clauseType: "joins",
valid: (query, stageIndex, metadata) => {
const database = metadata.database(Lib.databaseID(query));
- return hasData(query) && Boolean(database?.hasFeature("join"));
+ return hasData(query) && Boolean(database && supportsJoins(database));
},
subSteps: (query, stageIndex) => {
return Lib.joins(query, stageIndex).length;
@@ -72,7 +73,10 @@ const STEPS: NotebookStepDef[] = [
clauseType: "expressions",
valid: (query, _stageIndex, metadata) => {
const database = metadata.database(Lib.databaseID(query));
- return hasData(query) && Boolean(database?.hasFeature("expressions"));
+ return (
+ hasData(query) &&
+ Boolean(database && hasFeature(database, "expressions"))
+ );
},
active: (query, stageIndex) => {
return Lib.expressions(query, stageIndex).length > 0;
@@ -205,7 +209,7 @@ export function getQuestionSteps(
const database = metadata.database(Lib.databaseID(query));
const allowsNesting =
- Boolean(database?.hasFeature("nested-queries")) &&
+ Boolean(database && hasFeature(database, "nested-queries")) &&
question.type() !== "metric";
const hasBreakouts = Lib.breakouts(query, -1).length > 0;
const hasAggregations = Lib.aggregations(query, -1).length > 0;
diff --git a/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx b/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx
index 6a6bf83ce94..73935ff28ac 100644
--- a/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx
+++ b/frontend/src/metabase/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx
@@ -11,7 +11,7 @@ import {
} from "metabase/api";
import FormCollectionPicker from "metabase/common/collections/containers/FormCollectionPicker";
import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";
-import { hasFeature } from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import {
Form,
FormErrorMessage,
diff --git a/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/UpdateTargetModal/UpdateTargetModal.tsx b/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/UpdateTargetModal/UpdateTargetModal.tsx
index c796385d29e..f671945ba72 100644
--- a/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/UpdateTargetModal/UpdateTargetModal.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsSection/UpdateTargetModal/UpdateTargetModal.tsx
@@ -10,7 +10,7 @@ import {
useUpdateTransformMutation,
} from "metabase/api";
import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";
-import { hasFeature } from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import {
Form,
FormErrorMessage,
diff --git a/frontend/src/metabase/transforms/utils.ts b/frontend/src/metabase/transforms/utils.ts
index 5c312ce795a..8f97f4ab0ae 100644
--- a/frontend/src/metabase/transforms/utils.ts
+++ b/frontend/src/metabase/transforms/utils.ts
@@ -2,7 +2,7 @@ import { t } from "ttag";
import _ from "underscore";
import type { OmniPickerCollectionItem } from "metabase/common/components/Pickers/EntityPicker/types";
-import { hasFeature } from "metabase/common/utils/database";
+import { hasFeature } from "metabase/databases";
import { parseTimestamp } from "metabase/utils/time-dayjs";
import * as Lib from "metabase-lib";
import type Metadata from "metabase-lib/v1/metadata/Metadata";