Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

use vertica-ce from ecr (#63609)

Oreon Lothamerd8be52f6515e
diff --git a/.github/workflows/drivers-stress-test.yml b/.github/workflows/drivers-stress-test.yml
index 863209737e6..fa360ae778a 100644
--- a/.github/workflows/drivers-stress-test.yml
+++ b/.github/workflows/drivers-stress-test.yml
@@ -689,25 +689,57 @@ jobs:
junit-name: 'be-tests-starburst-ee'
test-args: ":only ${{ inputs.test }} :times ${{ inputs.times }}"
- # TODO(rileythomp, 2025-08-20): Re-enable vertica tests once the docker image is updated
- # be-tests-vertica-ee:
- # if: ${{ false && inputs.driver == 'Vertica' }}
- # runs-on: ubuntu-22.04
- # timeout-minutes: 90
- # env:
- # CI: 'true'
- # DRIVERS: vertica
- # services:
- # vertica:
- # image: vertica/vertica-ce:12.0.2-0
- # ports:
- # - "5433:5433"
- # steps:
- # - uses: actions/checkout@v4
- # - name: Make plugins directory
- # run: mkdir plugins
- # - name: Test Vertica driver
- # uses: ./.github/actions/test-driver
- # with:
- # junit-name: 'be-tests-vertica-ee'
- # test-args: ":only ${{ inputs.test }} :times ${{ inputs.times }}"
+ login-to-ecr:
+ if: inputs.driver == 'Vertica'
+ runs-on: ubuntu-22.04
+ timeout-minutes: 15
+ permissions:
+ id-token: write
+ contents: read
+ steps:
+ - name: Configure AWS credentials
+ uses: aws-actions/configure-aws-credentials@v4
+ with:
+ role-to-assume: ${{ secrets.CI_IAM_ROLE }}
+ role-session-name: GitHub_to_AWS_via_FederatedOIDC
+ aws-region: us-east-1
+ - name: Get ECR password
+ id: login-ecr
+ run: |
+ PASSWORD=$(aws ecr get-login-password --region us-east-1)
+
+ REGISTRY="$(aws sts get-caller-identity --query Account --output text).dkr.ecr.us-east-1.amazonaws.com"
+
+ echo "docker_username=AWS" >> $GITHUB_OUTPUT
+ echo "docker_password=$PASSWORD" >> $GITHUB_OUTPUT
+ echo "registry=$REGISTRY" >> $GITHUB_OUTPUT
+ outputs:
+ registry: ${{ steps.login-ecr.outputs.registry }}
+ docker_username: ${{ steps.login-ecr.outputs.docker_username }}
+ docker_password: ${{ steps.login-ecr.outputs.docker_password }}
+
+ be-tests-vertica-ee:
+ if: inputs.driver == 'Vertica'
+ runs-on: ubuntu-22.04
+ needs: login-to-ecr
+ timeout-minutes: 90
+ env:
+ CI: 'true'
+ DRIVERS: vertica
+ services:
+ vertica:
+ image: ${{ needs.login-to-ecr.outputs.registry }}/vertica-ce:25.3.0-0
+ ports:
+ - "5433:5433"
+ credentials:
+ username: ${{ needs.login-to-ecr.outputs.docker_username }}
+ password: ${{ needs.login-to-ecr.outputs.docker_password }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Make plugins directory
+ run: mkdir plugins
+ - name: Test Vertica driver
+ uses: ./.github/actions/test-driver
+ with:
+ junit-name: 'be-tests-vertica-ee'
+ test-args: ":only ${{ inputs.test }} :times ${{ inputs.times }}"
diff --git a/.github/workflows/drivers.yml b/.github/workflows/drivers.yml
index f73331d4083..a1f8e7d9d97 100644
--- a/.github/workflows/drivers.yml
+++ b/.github/workflows/drivers.yml
@@ -1079,42 +1079,74 @@ jobs:
# aws-region: ${{ vars.AWS_REGION }}
# trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
- # TODO(rileythomp, 2025-08-20): Re-enable vertica tests once the docker image is updated
- # be-tests-vertica-ee:
- # needs: determine-driver-skips
- # if: ${{ false && !inputs.skip && !(needs.determine-driver-skips.outputs.skip == 'true') }}
- # runs-on: ubuntu-22.04
- # timeout-minutes: 60
- # env:
- # CI: 'true'
- # DRIVERS: vertica
- # services:
- # vertica:
- # image: vertica/vertica-ce:12.0.2-0
- # ports:
- # - "5433:5433"
- # name: Vertica
- # steps:
- # - uses: actions/checkout@v4
- # - name: Make plugins directory
- # run: mkdir plugins
- # - name: Test Vertica driver
- # uses: ./.github/actions/test-driver
- # with:
- # junit-name: 'be-tests-vertica-ee'
- # test-args: >-
- # :only-tags [:mb/driver-tests]
- # - name: Upload Test Results
- # uses: ./.github/actions/upload-test-results
- # if: always()
- # with:
- # input-path: ./target/junit/
- # output-name: ${{ github.job }}
- # bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
- # aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
- # aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
- # aws-region: ${{ vars.AWS_REGION }}
- # trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
+ login-to-ecr:
+ needs: determine-driver-skips
+ if: ${{ !inputs.skip && !(needs.determine-driver-skips.outputs.skip == 'true') }}
+ runs-on: ubuntu-22.04
+ timeout-minutes: 15
+ permissions:
+ id-token: write
+ contents: read
+ steps:
+ - name: Configure AWS credentials
+ uses: aws-actions/configure-aws-credentials@v4
+ with:
+ role-to-assume: ${{ secrets.CI_IAM_ROLE }}
+ role-session-name: GitHub_to_AWS_via_FederatedOIDC
+ aws-region: us-east-1
+ - name: Get ECR password
+ id: login-ecr
+ run: |
+ PASSWORD=$(aws ecr get-login-password --region us-east-1)
+
+ REGISTRY="$(aws sts get-caller-identity --query Account --output text).dkr.ecr.us-east-1.amazonaws.com"
+
+ echo "docker_username=AWS" >> $GITHUB_OUTPUT
+ echo "docker_password=$PASSWORD" >> $GITHUB_OUTPUT
+ echo "registry=$REGISTRY" >> $GITHUB_OUTPUT
+ outputs:
+ registry: ${{ steps.login-ecr.outputs.registry }}
+ docker_username: ${{ steps.login-ecr.outputs.docker_username }}
+ docker_password: ${{ steps.login-ecr.outputs.docker_password }}
+
+ be-tests-vertica-ee:
+ needs: [determine-driver-skips, login-to-ecr]
+ if: ${{ !inputs.skip && !(needs.determine-driver-skips.outputs.skip == 'true') }}
+ runs-on: ubuntu-22.04
+ timeout-minutes: 60
+ env:
+ CI: 'true'
+ DRIVERS: vertica
+ services:
+ vertica:
+ image: ${{ needs.login-to-ecr.outputs.registry }}/vertica-ce:25.3.0-0
+ ports:
+ - "5433:5433"
+ credentials:
+ username: ${{ needs.login-to-ecr.outputs.docker_username }}
+ password: ${{ needs.login-to-ecr.outputs.docker_password }}
+ name: Vertica
+ steps:
+ - uses: actions/checkout@v4
+ - name: Make plugins directory
+ run: mkdir plugins
+ - name: Test Vertica driver
+ uses: ./.github/actions/test-driver
+ with:
+ junit-name: 'be-tests-vertica-ee'
+ test-args: >-
+ :only-tags [:mb/driver-tests]
+ - name: Upload Test Results
+ uses: ./.github/actions/upload-test-results
+ if: always()
+ with:
+ input-path: ./target/junit/
+ output-name: ${{ github.job }}
+ bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
+ aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
+ aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
+ aws-region: ${{ vars.AWS_REGION }}
+ trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
drivers-tests-result:
needs:
diff --git a/modules/drivers/vertica/test/metabase/driver/vertica_test.clj b/modules/drivers/vertica/test/metabase/driver/vertica_test.clj
index 9693a9c3e0c..29a041b26d3 100644
--- a/modules/drivers/vertica/test/metabase/driver/vertica_test.clj
+++ b/modules/drivers/vertica/test/metabase/driver/vertica_test.clj
@@ -46,7 +46,8 @@
(mt/test-driver :vertica
(testing "Columns with dots in the name should be properly quoted (#13932)"
(mt/dataset dots-in-names
- (is (= {:query ["SELECT"
+ (is (= {:lib/type :mbql.stage/native
+ :query ["SELECT"
" *"
"FROM"
" table"