Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove theme transition from dashbaord header, tabs, and parameters panel (#72370)

Nick Fitzpatrickd93f7fecde3f
diff --git a/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.module.css b/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.module.css
index 0e34ff64b9d..edc4fe5a616 100644
--- a/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.module.css
+++ b/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.module.css
@@ -24,7 +24,6 @@
.DashboardHeaderContainer {
position: relative;
z-index: 2;
- transition: var(--transition-theme-change);
&:not(.noBorder) {
border-bottom: 1px solid var(--mb-color-border);
diff --git a/frontend/src/metabase/dashboard/components/DashboardParameterPanel/DashboardParameterPanel.tsx b/frontend/src/metabase/dashboard/components/DashboardParameterPanel/DashboardParameterPanel.tsx
index 9e33df0bc61..1d7cb741a1e 100644
--- a/frontend/src/metabase/dashboard/components/DashboardParameterPanel/DashboardParameterPanel.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardParameterPanel/DashboardParameterPanel.tsx
@@ -1,7 +1,6 @@
import cx from "classnames";
import { useRef } from "react";
-import TransitionS from "metabase/css/core/transitions.module.css";
import { DASHBOARD_HEADER_PARAMETERS_PDF_EXPORT_NODE_ID } from "metabase/dashboard/constants";
import { useDashboardContext } from "metabase/dashboard/context";
import { useIsParameterPanelSticky } from "metabase/dashboard/hooks/use-is-parameter-panel-sticky";
@@ -30,13 +29,11 @@ export function DashboardParameterPanel() {
const allowSticky = isParametersWidgetContainersSticky(
visibleParameters.length,
);
- const { isSticky, isStickyStateChanging } = useIsParameterPanelSticky({
+ const { isSticky } = useIsParameterPanelSticky({
parameterPanelRef,
disabled: !allowSticky || !hasVisibleParameters,
});
- const shouldApplyThemeChangeTransition = !isStickyStateChanging && isSticky;
-
if (!hasVisibleParameters) {
return null;
}
@@ -70,7 +67,6 @@ export function DashboardParameterPanel() {
<span ref={parameterPanelRef}>
<FullWidthContainer
className={cx(S.ParametersWidgetContainer, {
- [TransitionS.transitionThemeChange]: shouldApplyThemeChangeTransition,
[S.allowSticky]: allowSticky,
[S.isSticky]: isSticky,
[S.isEmbeddingSdk]: isEmbeddingSdk(),
diff --git a/frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.module.css b/frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.module.css
index c760b290a89..e7db73c752a 100644
--- a/frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.module.css
+++ b/frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.module.css
@@ -8,7 +8,6 @@
position: absolute;
bottom: 0;
width: 100%;
- transition: var(--transition-theme-change);
}
}