The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Updated Chromium to v144 in Cypress (#69721)
Fraserda223ea0a1e0
diff --git a/.github/actions/prepare-cypress/action.yml b/.github/actions/prepare-cypress/action.ymlindex 59a978aec72..58ad7f83bae 100644--- a/.github/actions/prepare-cypress/action.yml+++ b/.github/actions/prepare-cypress/action.yml@@ -15,11 +15,10 @@ outputs:runs:using: "composite"steps:- - name: Install Chrome v111+ - name: Install Chrome v144uses: browser-actions/setup-chrome@v2with:- # https://chromium.cypress.io/linux/stable/111.0.5563.146- chrome-version: 1097615+ chrome-version: 144id: setup-chrome- name: Get cache keysdiff --git a/e2e/support/helpers/e2e-ui-elements-helpers.js b/e2e/support/helpers/e2e-ui-elements-helpers.jsindex ffccb2fc0f8..6d6fb9959a4 100644--- a/e2e/support/helpers/e2e-ui-elements-helpers.js+++ b/e2e/support/helpers/e2e-ui-elements-helpers.js@@ -689,8 +689,10 @@ export function getUniqueTableColumnValues(columnName) {export function ensureParameterColumnValue({ columnName, columnValue }) {tableInteractiveBody().within(() => {- cy.get(`[data-column-id="${columnName}"]`).each((cell) => {- cy.wrap(cell).should("have.text", columnValue);+ cy.get(`[data-column-id="${columnName}"]`).should(($cells) => {+ $cells.each((i, cell) => {+ expect(cell).to.have.text(columnValue);+ });});});}diff --git a/e2e/test/scenarios/admin/database-routing/database-routing-admin.cy.spec.ts b/e2e/test/scenarios/admin/database-routing/database-routing-admin.cy.spec.tsindex 96d86ed26e8..9f92732e7f3 100644--- a/e2e/test/scenarios/admin/database-routing/database-routing-admin.cy.spec.ts+++ b/e2e/test/scenarios/admin/database-routing/database-routing-admin.cy.spec.ts@@ -675,9 +675,16 @@ function assertDbRoutingDisabled() {dbRoutingSection().within(() => {cy.findByLabelText("Enable database routing").should("not.be.checked")- .should("be.disabled")- .realHover();+ .should("be.disabled");});+ // Use cy.trigger("mouseenter") instead of realHover() because Chrome v122++ // headless hit-tests CDP mouse events to the disabled <input> inside the+ // Mantine Switch, which suppresses boundary events and prevents the Tooltip+ // from appearing. cy.trigger() dispatches the event directly on the Box+ // wrapper, bypassing Chrome's hit-testing.+ dbRoutingSection()+ .findByTestId("database-routing-toggle-wrapper")+ .trigger("mouseenter");H.tooltip().findByText(/Database routing can't be enabled if/).should("exist");diff --git a/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js b/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.jsindex 84e19f47ea6..5716de6b694 100644--- a/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js+++ b/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js@@ -804,7 +804,7 @@ describe("issue 29304", () => {cy.findByTestId("scalar-value").should(([$scalarValue]) => {expect($scalarValue.offsetWidth).to.be.closeTo(expectedWidth,- expectedWidth * 0.1,+ expectedWidth * 0.2, // 20% tolerance for font rendering differences across Chrome versions);});});diff --git a/e2e/test/scenarios/dashboard/title-drill.cy.spec.js b/e2e/test/scenarios/dashboard/title-drill.cy.spec.jsindex 61fd0303fa4..1b3c9267864 100644--- a/e2e/test/scenarios/dashboard/title-drill.cy.spec.js+++ b/e2e/test/scenarios/dashboard/title-drill.cy.spec.js@@ -64,7 +64,7 @@ describe("scenarios > dashboard > title drill", () => {cy.findByTestId("loading-indicator").should("not.exist");H.getDashboardCard().findByRole("link", { name: "Q1" }).as("title");- cy.get("@title").realHover();+ cy.get("@title").trigger("mouseover");cy.get("@title").should("have.attr", "href").and("include", `/question/${questionId}`);diff --git a/e2e/test/scenarios/data-model/data-model-shared-1.cy.spec.ts b/e2e/test/scenarios/data-model/data-model-shared-1.cy.spec.tsindex f7bcaf28053..7e3d0ed5605 100644--- a/e2e/test/scenarios/data-model/data-model-shared-1.cy.spec.ts+++ b/e2e/test/scenarios/data-model/data-model-shared-1.cy.spec.ts@@ -705,7 +705,14 @@ describe.each<Area>(areas)("data model > %s", (area: Area) => {column: "Total",values: ["39.72", "117.03", "49.21", "115.23", "134.91"],});- PreviewSection.get().findByTestId("header-cell").realHover();+ // Use trigger("mouseover") instead of realHover() because Chrome v133++ // headless hit-tests CDP mouse events differently, preventing the+ // HoverCard from appearing. mouseover bubbles and React 18 uses it to+ // simulate onMouseEnter (which Mantine HoverCard.Target relies on).+ PreviewSection.get()+ .findByTestId("header-cell")+ .findByTestId("cell-data")+ .trigger("mouseover");H.hovercard().should("not.contain.text", "The total billed amount.");cy.visit(@@ -767,7 +774,11 @@ function verifyTablePreview({});if (description != null) {- cy.findByTestId("header-cell").realHover();+ // mouseover bubbles and React 18 uses it to simulate onMouseEnter+ // (which Mantine HoverCard.Target relies on).+ cy.findByTestId("header-cell")+ .findByTestId("cell-data")+ .trigger("mouseover");}});diff --git a/e2e/test/scenarios/data-studio/transforms/transforms-inspect.cy.spec.ts b/e2e/test/scenarios/data-studio/transforms/transforms-inspect.cy.spec.tsindex 1651b73f409..a1d203b373d 100644--- a/e2e/test/scenarios/data-studio/transforms/transforms-inspect.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/transforms/transforms-inspect.cy.spec.ts@@ -280,7 +280,7 @@ describe("scenarios > data-studio > transforms > inspect", () => {H.expectUnstructuredSnowplowEvent({event: "transform_inspect_lens_loaded",- event_detail: "unmatched-rows",+ event_detail: "unmatched-rows?join_step=1",});cy.findByRole("tab", { name: tabName }).within(() => {diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/select-embed-options.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/select-embed-options.cy.spec.tsindex c302820cf18..626bc1e266d 100644--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/select-embed-options.cy.spec.ts+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/select-embed-options.cy.spec.ts@@ -191,11 +191,14 @@ describe(suiteTitle, () => {.and("be.disabled");cy.log("Email warning should only be shown on non-guest embedding");+ // Use trigger("mouseenter") instead of realHover() because Chrome v133++ // headless CDP hit-testing on elements near disabled inputs suppresses+ // mouse boundary events, preventing the Tooltip from appearing.getEmbedSidebar().findByLabelText("Allow subscriptions").closest("[data-testid=tooltip-warning]").icon("info")- .realHover();+ .trigger("mouseenter");H.tooltip().should("contain.text","Not available if Guest Mode is selected",@@ -228,10 +231,14 @@ describe(suiteTitle, () => {cy.button("Next").click();cy.button("Next").click();+ // Trigger mouseover (not mouseenter) because this HoverCard is outside a+ // HoverCardGroup, so Mantine attaches a React onMouseEnter prop. React 18+ // simulates onMouseEnter from mouseover events (which bubble to the React+ // root for delegation). Native mouseenter doesn't bubble and React ignores it.cy.findByLabelText("Allow subscriptions").closest("[data-testid=tooltip-warning]").icon("info")- .realHover();+ .trigger("mouseover");});H.hovercard().should("contain.text",@@ -563,7 +570,7 @@ describe(suiteTitle, () => {.findByLabelText("Allow alerts").closest("[data-testid=tooltip-warning]").icon("info")- .realHover();+ .trigger("mouseenter");H.tooltip().should("contain.text","Not available if Guest Mode is selected",@@ -599,7 +606,7 @@ describe(suiteTitle, () => {cy.findByLabelText("Allow alerts").closest("[data-testid=tooltip-warning]").icon("info")- .realHover();+ .trigger("mouseover");});H.hovercard().should("contain.text",diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/metabase-browser.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/metabase-browser.cy.spec.tsindex 47a5089db33..f2f8029e520 100644--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/metabase-browser.cy.spec.ts+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/metabase-browser.cy.spec.ts@@ -165,8 +165,16 @@ describe("scenarios > embedding > sdk iframe embedding > metabase-browser", () =cy.findByText("Pick your starting data").should("be.visible");+ cy.intercept("POST", "/api/dataset/query_metadata").as("datasetMetadata");cy.findByText("Orders").click();+ // Wait for the dataset metadata POST triggered by updateQuestionSdk+ // to complete before clicking the breadcrumb. Without this, the stale+ // updateQuestion dispatch can race with loadAndQueryQuestion and+ // overwrite the reset state.+ cy.wait("@datasetMetadata");+ cy.findByTestId("data-step-cell").should("have.text", "Orders");+cy.findByTestId("sdk-breadcrumbs").findByText("New exploration").click();cy.findByText("Pick your starting data").should("be.visible");diff --git a/e2e/test/scenarios/native-filters/helpers/e2e-field-filter-data-objects.js b/e2e/test/scenarios/native-filters/helpers/e2e-field-filter-data-objects.jsindex 443888e6d2b..3e02de240b2 100644--- a/e2e/test/scenarios/native-filters/helpers/e2e-field-filter-data-objects.js+++ b/e2e/test/scenarios/native-filters/helpers/e2e-field-filter-data-objects.js@@ -94,6 +94,6 @@ export const DATE_FILTER_SUBTYPES = {// 2022.dayjs().diff(dayjs("2022-05-24"), "month") + 2,},- representativeResult: "Synergistic Steel Chair",+ representativeResult: "Rustic Paper Wallet",},};diff --git a/e2e/test/scenarios/native-filters/helpers/e2e-sql-filter-helpers.js b/e2e/test/scenarios/native-filters/helpers/e2e-sql-filter-helpers.jsindex 9b3b59c5f93..d1d25e97100 100644--- a/e2e/test/scenarios/native-filters/helpers/e2e-sql-filter-helpers.js+++ b/e2e/test/scenarios/native-filters/helpers/e2e-sql-filter-helpers.js@@ -87,7 +87,7 @@ export function toggleRequired() {export function runQuery(xhrAlias = "dataset") {getRunQueryButton().click();cy.wait("@" + xhrAlias);- cy.icon("play").should("not.exist");+ cy.findByTestId("query-visualization-root").should("exist");}/**diff --git a/e2e/test/scenarios/onboarding/setup/user_settings.cy.spec.js b/e2e/test/scenarios/onboarding/setup/user_settings.cy.spec.jsindex 340edb19640..69abe558835 100644--- a/e2e/test/scenarios/onboarding/setup/user_settings.cy.spec.js+++ b/e2e/test/scenarios/onboarding/setup/user_settings.cy.spec.js@@ -247,7 +247,6 @@ describe("user > settings", () => {describe("dark mode", () => {const isMac = Cypress.platform === "darwin";- const metaKey = isMac ? "Meta" : "Control";it("should toggle through light and dark mode when clicking on the label or icon", () => {cy.visit("/account/profile");@@ -260,9 +259,22 @@ describe("user > settings", () => {H.popover().findByText("Light").click();assertLightMode();- //Need to take focus off the inpout+ //Need to take focus off the inputH.navigationSidebar().findByRole("link", { name: /Home/ }).click();- cy.realPress([metaKey, "Shift", "L"]);+ // Wait for navigation to complete so kbar shortcut handlers are re-registered+ cy.location("pathname").should("eq", "/");+ // Use eventConstructor: "KeyboardEvent" so tinykeys' instanceof check+ // passes. cy.trigger() defaults to generic Event which kbar rejects.+ // Chrome v123+ headless also intercepts cy.realPress() CDP keyboard+ // events before they reach the page.+ cy.get("body").trigger("keydown", {+ eventConstructor: "KeyboardEvent",+ key: "L",+ code: "KeyL",+ metaKey: isMac,+ ctrlKey: !isMac,+ shiftKey: true,+ });assertDarkMode();});diff --git a/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx b/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsxindex b675fa65e24..8e461456d8f 100644--- a/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx@@ -134,7 +134,7 @@ export const DatabaseRoutingSection = ({</Stack><Flex gap="md"><Tooltip label={disabledFeatMsg} disabled={!disabledFeatMsg}>- <Box>+ <Box data-testid="database-routing-toggle-wrapper"><Switchid="database-routing-toggle"checked={enabled}