The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Filter transforms based on permissions GHY-3152 (#70125)
Eric Normanddbfe313b4a35
diff --git a/enterprise/backend/src/metabase_enterprise/dependencies/api.clj b/enterprise/backend/src/metabase_enterprise/dependencies/api.cljindex cd6d34e85a9..4c1d35f95a0 100644--- a/enterprise/backend/src/metabase_enterprise/dependencies/api.clj+++ b/enterprise/backend/src/metabase_enterprise/dependencies/api.clj@@ -67,7 +67,7 @@(update :dashboard #(some-> % (select-keys [:id :name])))(update :document #(some-> % (select-keys [:id :name])))))))broken-cards)- :bad_transforms (into [] broken-transforms)}))+ :bad_transforms (into [] (filter mi/can-read?) broken-transforms)}))(api.macros/defendpoint :post "/check-card" :- ::broken-cards-response"Check a proposed edit to a card, and return the card IDs for those cards this edit will break."diff --git a/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj b/enterprise/backend/test/metabase_enterprise/dependencies/api_test.cljindex e6e3cdc8fae..a5e66cf7b50 100644--- a/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj+++ b/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj@@ -3,6 +3,7 @@[clojure.test :refer :all][medley.core :as m][metabase-enterprise.dependencies.api :as deps.api]+ [metabase-enterprise.dependencies.core :as dependencies][metabase-enterprise.dependencies.events][metabase-enterprise.dependencies.findings :as dependencies.findings][metabase-enterprise.dependencies.task.backfill :as dependencies.backfill]@@ -680,6 +681,31 @@:source (:source transform):target (:target transform)}))))))))+(deftest check-card-bad-transforms-filtered-by-can-read-test+ (testing "POST /api/ee/dependencies/check-card filters bad_transforms by mi/can-read?"+ (mt/dataset test-data+ (mt/with-premium-features #{:dependencies :transforms}+ (mt/with-temp [:model/User user {:email "[email protected]"}+ :model/Transform transform {}]+ (mt/with-model-cleanup [:model/Card :model/Dependency]+ (let [base-card (card/create-card! (basic-card) user)+ proposed-card {:id (:id base-card)+ :type :question+ :dataset_query (:dataset_query base-card)}]+ ;; Mock errors-from-proposed-edits to report the transform as broken+ (with-redefs [dependencies/errors-from-proposed-edits+ (constantly {:transform {(:id transform) #{:some-error}}})]+ (testing "Admin sees broken transforms in response"+ (let [response (mt/user-http-request :crowberto :post 200 "ee/dependencies/check-card"+ proposed-card)]+ (is (false? (:success response)))+ (is (=? [{:id (:id transform)}]+ (:bad_transforms response)))))+ (testing "Non-admin user cannot see broken transforms they lack read permission for"+ (let [response (mt/user-http-request :rasta :post 200 "ee/dependencies/check-card"+ proposed-card)]+ (is (= [] (:bad_transforms response)))))))))))))+(deftest graph-permissions-test(testing "GET /api/ee/dependencies/graph requires read permissions on the starting entity"(mt/with-premium-features #{:dependencies}