Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Add keyboard shortcut (g s) to navigate to Data Studio (#71328)

Nathan Voxlanddc38720b2066
diff --git a/e2e/test/scenarios/onboarding/command-palette.cy.spec.js b/e2e/test/scenarios/onboarding/command-palette.cy.spec.js
index 331628b3803..faa1e062be5 100644
--- a/e2e/test/scenarios/onboarding/command-palette.cy.spec.js
+++ b/e2e/test/scenarios/onboarding/command-palette.cy.spec.js
@@ -575,6 +575,16 @@ describe("shortcuts", { tags: ["@actions"] }, () => {
event_detail: "navigate-trash",
});
+ cy.realPress("g").realPress("s");
+ cy.location("pathname").should("match", /^\/data-studio/);
+
+ H.expectUnstructuredSnowplowEvent({
+ event: "keyboard_shortcut_performed",
+ event_detail: "navigate-data-studio",
+ });
+
+ cy.realPress("g").realPress("m");
+
cy.log("shortcuts should not be enabled when working in a modal (ADM 658)");
H.navigationSidebar().should("be.visible");
@@ -618,6 +628,17 @@ describe("shortcuts", { tags: ["@actions"] }, () => {
cy.location("pathname").should("contain", "/admin/tools");
});
+ it("should not navigate to data studio via shortcut for non-admin users", () => {
+ cy.signInAsNormalUser();
+ cy.visit("/");
+ cy.findByTestId("home-page")
+ .findByText(/see what metabase can do/i)
+ .should("exist");
+
+ cy.realPress("g").realPress("s");
+ cy.location("pathname").should("equal", "/");
+ });
+
it("should support dashboard shortcuts", () => {
H.createDashboardWithTabs({
tabs: [TAB_1, TAB_2, TAB_3, TAB_4],
diff --git a/frontend/src/metabase/palette/hooks/useCommandPaletteBasicActions.tsx b/frontend/src/metabase/palette/hooks/useCommandPaletteBasicActions.tsx
index 2898f81f5da..145d87d7018 100644
--- a/frontend/src/metabase/palette/hooks/useCommandPaletteBasicActions.tsx
+++ b/frontend/src/metabase/palette/hooks/useCommandPaletteBasicActions.tsx
@@ -10,6 +10,7 @@ import {
useSearchListQuery,
} from "metabase/common/hooks";
import { trackMetricCreateStarted } from "metabase/data-studio/analytics";
+import { canAccessDataStudio } from "metabase/data-studio/selectors";
import { Collections } from "metabase/entities/collections/collections";
import { useDispatch, useSelector } from "metabase/lib/redux";
import * as Urls from "metabase/lib/urls";
@@ -49,6 +50,7 @@ export const BASIC_ACTION_ORDER = [
"navigate-user-settings",
"navigate-trash",
"navigate-home",
+ "navigate-data-studio",
"navigate-browse-model",
"navigate-browse-database",
"navigate-browse-metric",
@@ -73,6 +75,7 @@ export const useCommandPaletteBasicActions = ({
const personalCollectionId = useSelector(getUserPersonalCollectionId);
const isAdmin = useSelector(getUserIsAdmin);
+ const hasDataStudioAccess = useSelector(canAccessDataStudio);
const hasDataAccess = useSelector(canUserCreateQueries);
const hasNativeWrite = useSelector(canUserCreateNativeQueries);
@@ -259,6 +262,13 @@ export const useCommandPaletteBasicActions = ({
},
);
+ if (hasDataStudioAccess) {
+ actions.push({
+ id: "navigate-data-studio",
+ perform: () => dispatch(push("/data-studio")),
+ });
+ }
+
const browseActions: RegisterShortcutProps[] = [
{
id: "navigate-browse-model",
@@ -293,6 +303,7 @@ export const useCommandPaletteBasicActions = ({
}, [
dispatch,
hasDataAccess,
+ hasDataStudioAccess,
hasNativeWrite,
collectionId,
openNewModal,
diff --git a/frontend/src/metabase/palette/shortcuts/global.ts b/frontend/src/metabase/palette/shortcuts/global.ts
index fd537a18241..6223f154963 100644
--- a/frontend/src/metabase/palette/shortcuts/global.ts
+++ b/frontend/src/metabase/palette/shortcuts/global.ts
@@ -71,6 +71,13 @@ export const globalShortcuts = {
shortcut: ["g k"],
shortcutGroup: "global" as const,
},
+ "navigate-data-studio": {
+ get name() {
+ return t`Go to Data Studio`;
+ },
+ shortcut: ["g s"],
+ shortcutGroup: "global" as const,
+ },
"download-diagnostics": {
get name() {