The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Add transform job run history page (#76017)
Oleh Kdc878ea1e5b8
diff --git a/frontend/src/metabase-types/api/mocks/transform.ts b/frontend/src/metabase-types/api/mocks/transform.tsindex c91349c863c..47e34fd89c7 100644--- a/frontend/src/metabase-types/api/mocks/transform.ts+++ b/frontend/src/metabase-types/api/mocks/transform.ts@@ -2,12 +2,15 @@ import type {DatabaseId,InspectorCard,InspectorSource,+ ListTransformJobRunsResponse,ListTransformRunsResponse,PythonTransformTableAliases,Transform,TransformJob,+ TransformJobRun,TransformOwner,TransformRun,+ TransformRunForJobRun,TransformSource,TransformTag,TransformTarget,@@ -137,6 +140,51 @@ export function createMockListTransformRunsResponse(};}+export function createMockTransformJobRun(+ opts?: Partial<TransformJobRun>,+): TransformJobRun {+ return {+ id: 1,+ job_id: 1,+ status: "succeeded",+ run_method: "cron",+ start_time: "2000-01-01T00:00:00Z",+ end_time: "2000-01-01T00:00:00Z",+ message: null,+ is_active: false,+ created_at: "2000-01-01T00:00:00Z",+ updated_at: "2000-01-01T00:00:00Z",+ ...opts,+ };+}++export function createMockListTransformJobRunsResponse(+ opts?: Partial<ListTransformJobRunsResponse>,+): ListTransformJobRunsResponse {+ return {+ data: [],+ total: 0,+ limit: null,+ offset: null,+ ...opts,+ };+}++export function createMockTransformRunForJobRun(+ opts?: Partial<TransformRunForJobRun>,+): TransformRunForJobRun {+ return {+ ...createMockTransformRun(),+ transform_id: 1,+ job_run_id: 1,+ transform_name: "Transform",+ transform_entity_id: null,+ metered_as: null,+ user_id: null,+ ...opts,+ };+}+export function createMockTransformTag(opts?: Partial<TransformTag>,): TransformTag {diff --git a/frontend/src/metabase-types/api/transform.ts b/frontend/src/metabase-types/api/transform.tsindex 88b0c62d52b..df4491ff7d9 100644--- a/frontend/src/metabase-types/api/transform.ts+++ b/frontend/src/metabase-types/api/transform.ts@@ -198,6 +198,47 @@ export const TRANSFORM_RUN_SORT_COLUMNS = [export type TransformRunSortColumn =(typeof TRANSFORM_RUN_SORT_COLUMNS)[number];+export type TransformJobRunId = number;++export const TRANSFORM_JOB_RUN_STATUSES = [+ "started",+ "succeeded",+ "failed",+ "timeout",+] as const;+export type TransformJobRunStatus = (typeof TRANSFORM_JOB_RUN_STATUSES)[number];++export type TransformJobRun = {+ id: TransformJobRunId;+ job_id: TransformJobId;+ status: TransformJobRunStatus;+ run_method: TransformRunMethod;+ start_time: string;+ end_time: string | null;+ message: string | null;+ is_active: boolean | null;+ created_at: string;+ updated_at: string;+};++export const TRANSFORM_JOB_RUN_SORT_COLUMNS = [+ "start_time",+ "end_time",+] as const;+export type TransformJobRunSortColumn =+ (typeof TRANSFORM_JOB_RUN_SORT_COLUMNS)[number];++// A transform run that made up a given job run. Superset of TransformRun so it+// can be passed to the existing run-rendering components.+export type TransformRunForJobRun = TransformRun & {+ transform_id: TransformId | null;+ job_run_id: TransformJobRunId | null;+ transform_name?: string | null;+ transform_entity_id?: string | null;+ metered_as?: string | null;+ user_id?: UserId | null;+};+export type TransformTag = {id: TransformTagId;name: string;@@ -306,6 +347,24 @@ export type ListTransformRunsResponse = {data: TransformRun[];} & PaginationResponse;+export type ListTransformJobRunsRequest = {+ jobId: TransformJobId;+ status?: TransformJobRunStatus;+ "run-method"?: TransformRunMethod;+ "start-time"?: string;+ "sort-column"?: TransformJobRunSortColumn;+ "sort-direction"?: SortDirection;+} & PaginationRequest;++export type ListTransformJobRunsResponse = {+ data: TransformJobRun[];+} & PaginationResponse;++export type ListJobRunTransformRunsRequest = {+ jobId: TransformJobId;+ runId: TransformJobRunId;+};+export type TestPythonTransformRequest = {code: string;source_tables: PythonTransformTableAliases;diff --git a/frontend/src/metabase/api/transform-job.ts b/frontend/src/metabase/api/transform-job.tsindex 0172e67c707..1164e5c01f6 100644--- a/frontend/src/metabase/api/transform-job.ts+++ b/frontend/src/metabase/api/transform-job.ts@@ -1,9 +1,13 @@import type {CreateTransformJobRequest,+ ListJobRunTransformRunsRequest,+ ListTransformJobRunsRequest,+ ListTransformJobRunsResponse,ListTransformJobsRequest,Transform,TransformJob,TransformJobId,+ TransformRunForJobRun,UpdateTransformJobRequest,} from "metabase-types/api";@@ -45,6 +49,31 @@ export const transformJobApi = Api.injectEndpoints({...provideTransformListTags(transforms),],}),+ listTransformJobRuns: builder.query<+ ListTransformJobRunsResponse,+ ListTransformJobRunsRequest+ >({+ query: ({ jobId, ...params }) => ({+ method: "GET",+ url: `/api/transform-job/${jobId}/runs`,+ params,+ }),+ providesTags: (_response, _error, { jobId }) => [+ idTag("transform-job", jobId),+ ],+ }),+ listJobRunTransformRuns: builder.query<+ TransformRunForJobRun[],+ ListJobRunTransformRunsRequest+ >({+ query: ({ jobId, runId }) => ({+ method: "GET",+ url: `/api/transform-job/${jobId}/runs/${runId}/transform-runs`,+ }),+ providesTags: (_response, _error, { jobId }) => [+ idTag("transform-job", jobId),+ ],+ }),runTransformJob: builder.mutation<void, TransformJobId>({query: (id) => ({method: "POST",@@ -154,6 +183,8 @@ export const transformJobApi = Api.injectEndpoints({export const {useListTransformJobsQuery,useListTransformJobTransformsQuery,+ useListTransformJobRunsQuery,+ useListJobRunTransformRunsQuery,useGetTransformJobQuery,useLazyGetTransformJobQuery,useRunTransformJobMutation,diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/ErrorSection.module.css b/frontend/src/metabase/transforms/components/ErrorSection/ErrorSection.module.csssimilarity index 67%rename from frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/ErrorSection.module.cssrename to frontend/src/metabase/transforms/components/ErrorSection/ErrorSection.module.cssindex ef86f525cf9..a38323bd214 100644--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/ErrorSection.module.css+++ b/frontend/src/metabase/transforms/components/ErrorSection/ErrorSection.module.css@@ -1,6 +1,6 @@.codeContainer {- border: var(--border-size) var(--border-style) var(--mb-color-border);+ border: var(--border-size) var(--border-style) var(--mb-color-border-neutral);border-radius: var(--default-border-radius);- box-shadow: 0 2px 2px var(--mb-color-shadow);+ box-shadow: 0 2px 2px var(--mb-color-shadow-default);overflow: hidden;}diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/ErrorSection.tsx b/frontend/src/metabase/transforms/components/ErrorSection/ErrorSection.tsxsimilarity index 76%rename from frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/ErrorSection.tsxrename to frontend/src/metabase/transforms/components/ErrorSection/ErrorSection.tsxindex fe428a4cb7d..12a611d936b 100644--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/ErrorSection.tsx+++ b/frontend/src/metabase/transforms/components/ErrorSection/ErrorSection.tsx@@ -9,16 +9,17 @@ import S from "./ErrorSection.module.css";type ErrorSectionProps = {run: TransformRun;+ showTitle?: boolean;};-export function ErrorSection({ run }: ErrorSectionProps) {+export function ErrorSection({ run, showTitle = true }: ErrorSectionProps) {if (run.message == null) {return null;}return (- <Stack role="region" aria-label={t`Error`}>- <Title order={5}>{t`Error`}</Title>+ <Stack role="region" aria-label={t`Error`} gap="sm">+ {showTitle && <Title order={5}>{t`Error`}</Title>}<Box className={S.codeContainer} pos="relative" pr="lg"><CodeEditor value={run.message} readOnly /><Box p="sm" pos="absolute" right={0} top={0}>diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/ErrorSection.unit.spec.tsx b/frontend/src/metabase/transforms/components/ErrorSection/ErrorSection.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/ErrorSection.unit.spec.tsxrename to frontend/src/metabase/transforms/components/ErrorSection/ErrorSection.unit.spec.tsxdiff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/index.ts b/frontend/src/metabase/transforms/components/ErrorSection/index.tssimilarity index 100%rename from frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/ErrorSection/index.tsrename to frontend/src/metabase/transforms/components/ErrorSection/index.tsdiff --git a/frontend/src/metabase/transforms/components/JobEditor/JobEditor.tsx b/frontend/src/metabase/transforms/components/JobEditor/JobEditor.tsxindex 66da5ad6282..03e4e05a536 100644--- a/frontend/src/metabase/transforms/components/JobEditor/JobEditor.tsx+++ b/frontend/src/metabase/transforms/components/JobEditor/JobEditor.tsx@@ -26,6 +26,7 @@ type JobEditorProps = {job: TransformJobInfo;menu?: ReactNode;actions?: ReactNode;+ tabs?: ReactNode;readOnly?: boolean;isCheckingPermissions?: boolean;onNameChange: (name: string) => void;@@ -40,6 +41,7 @@ export function JobEditor({job,menu,actions,+ tabs,readOnly,isCheckingPermissions,onNameChange,@@ -61,11 +63,11 @@ export function JobEditor({/>{isMeterLocked && (<LockedTransformsHoverCard>- <TransformBadge bg="background-warning-secondary">{t`Disabled`}</TransformBadge>+ <TransformBadge bg="background_surface-warning-strong">{t`Disabled`}</TransformBadge></LockedTransformsHoverCard>)}{!isMeterLocked && !job.active && (- <TransformBadge bg="background-warning-secondary">+ <TransformBadge bg="background_surface-warning-strong">{t`Disabled`}</TransformBadge>)}@@ -82,6 +84,7 @@ export function JobEditor({}menu={menu}actions={actions}+ tabs={tabs}data-testid="jobs-header"/><Stack gap="3.5rem">diff --git a/frontend/src/metabase/transforms/components/JobTabs/JobTabs.tsx b/frontend/src/metabase/transforms/components/JobTabs/JobTabs.tsxnew file mode 100644index 00000000000..c4277c722d1--- /dev/null+++ b/frontend/src/metabase/transforms/components/JobTabs/JobTabs.tsx@@ -0,0 +1,30 @@+import { t } from "ttag";++import {+ type PaneHeaderTab,+ PaneHeaderTabs,+} from "metabase/data-studio/common/components/PaneHeader";+import * as Urls from "metabase/urls";+import type { TransformJobId } from "metabase-types/api";++type JobTabsProps = {+ jobId: TransformJobId;+};++export const JobTabs = ({ jobId }: JobTabsProps) => {+ const tabs = getTabs(jobId);+ return <PaneHeaderTabs tabs={tabs} />;+};++function getTabs(jobId: TransformJobId): PaneHeaderTab[] {+ return [+ {+ label: t`Overview`,+ to: Urls.transformJob(jobId),+ },+ {+ label: t`Run history`,+ to: Urls.transformJobRuns(jobId),+ },+ ];+}diff --git a/frontend/src/metabase/transforms/components/JobTabs/index.ts b/frontend/src/metabase/transforms/components/JobTabs/index.tsnew file mode 100644index 00000000000..bfa9996eccd--- /dev/null+++ b/frontend/src/metabase/transforms/components/JobTabs/index.ts@@ -0,0 +1 @@+export { JobTabs } from "./JobTabs";diff --git a/frontend/src/metabase/transforms/components/SidebarInfoRow/SidebarInfoRow.module.css b/frontend/src/metabase/transforms/components/SidebarInfoRow/SidebarInfoRow.module.cssnew file mode 100644index 00000000000..11a7ee31f67--- /dev/null+++ b/frontend/src/metabase/transforms/components/SidebarInfoRow/SidebarInfoRow.module.css@@ -0,0 +1,5 @@+.row {+ &:not(:last-child) {+ border-bottom: 1px solid var(--mb-color-border-neutral);+ }+}diff --git a/frontend/src/metabase/transforms/components/SidebarInfoRow/SidebarInfoRow.tsx b/frontend/src/metabase/transforms/components/SidebarInfoRow/SidebarInfoRow.tsxnew file mode 100644index 00000000000..897ae327c59--- /dev/null+++ b/frontend/src/metabase/transforms/components/SidebarInfoRow/SidebarInfoRow.tsx@@ -0,0 +1,36 @@+import { type ReactNode, useId } from "react";++import CS from "metabase/css/core/index.css";+import { Box, Stack } from "metabase/ui";++import S from "./SidebarInfoRow.module.css";++type SidebarInfoRowProps = {+ label: string;+ children?: ReactNode;+};++export function SidebarInfoRow({ label, children }: SidebarInfoRowProps) {+ const labelId = useId();++ return (+ <Stack+ className={S.row}+ p="md"+ gap="xs"+ role="group"+ aria-labelledby={labelId}+ >+ <Box+ id={labelId}+ className={CS.textWrap}+ c="text-secondary"+ fz="sm"+ lh="h5"+ >+ {label}+ </Box>+ <Box lh="h4">{children}</Box>+ </Stack>+ );+}diff --git a/frontend/src/metabase/transforms/components/SidebarInfoRow/index.ts b/frontend/src/metabase/transforms/components/SidebarInfoRow/index.tsnew file mode 100644index 00000000000..11515e7654f--- /dev/null+++ b/frontend/src/metabase/transforms/components/SidebarInfoRow/index.ts@@ -0,0 +1 @@+export { SidebarInfoRow } from "./SidebarInfoRow";diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/SidebarResizableBox/SidebarResizableBox.module.css b/frontend/src/metabase/transforms/components/SidebarResizableBox/SidebarResizableBox.module.csssimilarity index 100%rename from frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/SidebarResizableBox/SidebarResizableBox.module.cssrename to frontend/src/metabase/transforms/components/SidebarResizableBox/SidebarResizableBox.module.cssdiff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/SidebarResizableBox/SidebarResizableBox.tsx b/frontend/src/metabase/transforms/components/SidebarResizableBox/SidebarResizableBox.tsxsimilarity index 100%rename from frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/SidebarResizableBox/SidebarResizableBox.tsxrename to frontend/src/metabase/transforms/components/SidebarResizableBox/SidebarResizableBox.tsxdiff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/SidebarResizableBox/index.ts b/frontend/src/metabase/transforms/components/SidebarResizableBox/index.tssimilarity index 100%rename from frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/SidebarResizableBox/index.tsrename to frontend/src/metabase/transforms/components/SidebarResizableBox/index.tsdiff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunTable/TimezoneIndicator/TimezoneIndicator.tsx b/frontend/src/metabase/transforms/components/TimezoneIndicator/TimezoneIndicator.tsxsimilarity index 100%rename from frontend/src/metabase/transforms/pages/RunListPage/RunTable/TimezoneIndicator/TimezoneIndicator.tsxrename to frontend/src/metabase/transforms/components/TimezoneIndicator/TimezoneIndicator.tsxdiff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunTable/TimezoneIndicator/index.ts b/frontend/src/metabase/transforms/components/TimezoneIndicator/index.tssimilarity index 100%rename from frontend/src/metabase/transforms/pages/RunListPage/RunTable/TimezoneIndicator/index.tsrename to frontend/src/metabase/transforms/components/TimezoneIndicator/index.tsdiff --git a/frontend/src/metabase/transforms/pages/JobPage/JobPage.tsx b/frontend/src/metabase/transforms/pages/JobPage/JobPage.tsxindex 33638bf6f00..b4d7a8a6840 100644--- a/frontend/src/metabase/transforms/pages/JobPage/JobPage.tsx+++ b/frontend/src/metabase/transforms/pages/JobPage/JobPage.tsx@@ -24,6 +24,7 @@ import type {import { JobEditor } from "../../components/JobEditor";import { JobMoreMenu } from "../../components/JobMoreMenu";+import { JobTabs } from "../../components/JobTabs";import { POLLING_INTERVAL } from "../../constants";type JobPageParams = {@@ -157,6 +158,7 @@ function JobPageBody({<JobEditorjob={job}menu={!readOnly && <JobMoreMenu job={job} />}+ tabs={<JobTabs jobId={job.id} />}readOnly={readOnly}isCheckingPermissions={isCheckingPermissions}onNameChange={handleNameChange}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.module.css b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.module.cssnew file mode 100644index 00000000000..5780d690fe1--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.module.css@@ -0,0 +1,7 @@+.main {+ overflow: hidden;+}++.resizing {+ user-select: none;+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.tsxnew file mode 100644index 00000000000..5c38c4265a9--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.tsx@@ -0,0 +1,293 @@+import { useDisclosure, useElementSize } from "@mantine/hooks";+import cx from "classnames";+import type { Location } from "history";+import { useCallback, useLayoutEffect, useMemo, useState } from "react";+import { Link } from "react-router";+import { replace } from "react-router-redux";+import { t } from "ttag";++import {+ skipToken,+ useGetTransformJobQuery,+ useListTransformJobRunsQuery,+} from "metabase/api";+import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";+import { PaginationControls } from "metabase/common/components/PaginationControls";+import { DataStudioBreadcrumbs } from "metabase/data-studio/common/components/DataStudioBreadcrumbs";+import {+ PaneHeader,+ PanelHeaderTitle,+} from "metabase/data-studio/common/components/PaneHeader";+import { usePageTitle } from "metabase/hooks/use-page-title";+import { useDispatch } from "metabase/redux";+import { POLLING_INTERVAL } from "metabase/transforms/constants";+import { formatRunMethod, formatStatus } from "metabase/transforms/utils";+import { Center, Flex, Group, Select, Stack } from "metabase/ui";+import * as Urls from "metabase/urls";+import {+ TRANSFORM_JOB_RUN_STATUSES,+ TRANSFORM_RUN_METHODS,+ type TransformJobRun,+ type TransformJobRunId,+ type TransformJobRunStatus,+ type TransformRunMethod,+} from "metabase-types/api";++import { JobTabs } from "../../components/JobTabs";++import S from "./JobRunListPage.module.css";+import { JobRunSidebar } from "./JobRunSidebar";+import { JobRunTable } from "./JobRunTable";+import { PAGE_SIZE } from "./constants";+import type { JobRunSortOptions } from "./types";+import { getParsedParams, getSortOptions } from "./utils";++const EMPTY_RUNS: TransformJobRun[] = [];++type JobRunListPageProps = {+ params: { jobId: string };+ location: Location;+};++export function JobRunListPage({ params, location }: JobRunListPageProps) {+ usePageTitle(t`Run history`);+ const jobId = Urls.extractEntityId(params.jobId);+ const parsedParams = getParsedParams(location);+ const { page = 0 } = parsedParams;+ const { ref: containerRef, width: containerWidth } = useElementSize();+ const [isResizing, { open: startResizing, close: stopResizing }] =+ useDisclosure();+ const [selectedRunId, setSelectedRunId] = useState<+ TransformJobRunId | undefined+ >();+ const [isPolling, setIsPolling] = useState(false);+ const dispatch = useDispatch();++ const { data: job } = useGetTransformJobQuery(jobId ?? skipToken);++ const { data, isLoading, error } = useListTransformJobRunsQuery(+ jobId != null+ ? {+ jobId,+ offset: page * PAGE_SIZE,+ limit: PAGE_SIZE,+ status: parsedParams.status,+ "run-method": parsedParams.runMethod,+ "start-time": parsedParams.startTime,+ "sort-column": parsedParams.sortColumn,+ "sort-direction": parsedParams.sortDirection,+ }+ : skipToken,+ {+ pollingInterval: isPolling ? POLLING_INTERVAL : undefined,+ },+ );++ if (isPolling !== isPollingNeeded(data?.data)) {+ setIsPolling(isPollingNeeded(data?.data));+ }++ const runs = data?.data ?? EMPTY_RUNS;++ const selectedRun = useMemo(+ () =>+ selectedRunId != null+ ? runs.find((run) => run.id === selectedRunId)+ : undefined,+ [selectedRunId, runs],+ );++ useLayoutEffect(() => {+ if (selectedRunId != null && selectedRun == null) {+ setSelectedRunId(undefined);+ }+ }, [selectedRunId, selectedRun]);++ const handleParamsChange = useCallback(+ (newParams: Urls.TransformJobRunListParams) => {+ if (jobId != null) {+ dispatch(replace(Urls.transformJobRuns(jobId, newParams)));+ }+ },+ [dispatch, jobId],+ );++ const handleStatusChange = useCallback(+ (status: TransformJobRunStatus | undefined) => {+ handleParamsChange({ ...parsedParams, status, page: undefined });+ },+ [parsedParams, handleParamsChange],+ );++ const handleRunMethodChange = useCallback(+ (runMethod: TransformRunMethod | undefined) => {+ handleParamsChange({ ...parsedParams, runMethod, page: undefined });+ },+ [parsedParams, handleParamsChange],+ );++ const handleStartTimeChange = useCallback(+ (startTime: string | undefined) => {+ handleParamsChange({ ...parsedParams, startTime, page: undefined });+ },+ [parsedParams, handleParamsChange],+ );++ const handleSortOptionsChange = useCallback(+ (sortOptions: JobRunSortOptions | undefined) => {+ handleParamsChange({+ ...parsedParams,+ sortColumn: sortOptions?.column,+ sortDirection: sortOptions?.direction,+ page: undefined,+ });+ },+ [parsedParams, handleParamsChange],+ );++ const handlePageChange = useCallback(+ (nextPage: number) => {+ handleParamsChange({ ...parsedParams, page: nextPage });+ },+ [parsedParams, handleParamsChange],+ );++ const handleSelect = useCallback((runId: TransformJobRunId) => {+ setSelectedRunId(runId);+ }, []);++ return (+ <Flex+ className={cx({ [S.resizing]: isResizing })}+ ref={containerRef}+ h="100%"+ wrap="nowrap"+ data-testid="job-run-list"+ >+ <Stack className={S.main} flex={1} px="3.5rem" pb="md" gap={0}>+ <PaneHeader+ title={job != null && <PanelHeaderTitle>{job.name}</PanelHeaderTitle>}+ tabs={jobId != null && <JobTabs jobId={jobId} />}+ breadcrumbs={+ <DataStudioBreadcrumbs>+ <Link to={Urls.transformJobList()}>{t`Jobs`}</Link>+ {job?.name ?? t`Run history`}+ </DataStudioBreadcrumbs>+ }+ py={0}+ showMetabotButton+ />+ {isLoading || error != null ? (+ <Center h="100%">+ <LoadingAndErrorWrapper loading={isLoading} error={error} />+ </Center>+ ) : (+ <Stack flex="0 1 auto" mih={0} gap="lg" pt="2.5rem">+ <Group>+ <Select+ data={getStatusOptions()}+ value={parsedParams.status ?? null}+ placeholder={t`All statuses`}+ clearable+ w={180}+ aria-label={t`Status`}+ onChange={(value) =>+ handleStatusChange(+ Urls.parseEnumParam(value, TRANSFORM_JOB_RUN_STATUSES),+ )+ }+ />+ <Select+ data={getRunMethodOptions()}+ value={parsedParams.runMethod ?? null}+ placeholder={t`All triggers`}+ clearable+ w={180}+ aria-label={t`Trigger`}+ onChange={(value) =>+ handleRunMethodChange(+ Urls.parseEnumParam(value, TRANSFORM_RUN_METHODS),+ )+ }+ />+ <Select+ data={getStartTimeOptions()}+ value={parsedParams.startTime ?? null}+ placeholder={t`Any time`}+ clearable+ w={180}+ aria-label={t`Started at`}+ onChange={(value) => handleStartTimeChange(value ?? undefined)}+ />+ </Group>+ <JobRunTable+ runs={runs}+ hasFilters={+ parsedParams.status != null ||+ parsedParams.runMethod != null ||+ parsedParams.startTime != null+ }+ sortOptions={getSortOptions(parsedParams)}+ onSortOptionsChange={handleSortOptionsChange}+ onSelect={handleSelect}+ />+ {data != null && data.total > PAGE_SIZE && (+ <Group justify="end">+ <PaginationControls+ page={page}+ pageSize={PAGE_SIZE}+ itemsLength={runs.length}+ total={data.total}+ showTotal+ onPreviousPage={() => handlePageChange(page - 1)}+ onNextPage={() => handlePageChange(page + 1)}+ />+ </Group>+ )}+ </Stack>+ )}+ </Stack>+ {jobId != null && selectedRun != null && (+ <JobRunSidebar+ jobId={jobId}+ run={selectedRun}+ containerWidth={containerWidth}+ onResizeStart={startResizing}+ onResizeStop={stopResizing}+ onClose={() => setSelectedRunId(undefined)}+ />+ )}+ </Flex>+ );+}++function getStatusOptions() {+ return TRANSFORM_JOB_RUN_STATUSES.map((status) => ({+ value: status,+ label: formatStatus(status),+ }));+}++function getRunMethodOptions() {+ return TRANSFORM_RUN_METHODS.map((runMethod) => ({+ value: runMethod,+ label: formatRunMethod(runMethod),+ }));+}++function getStartTimeOptions() {+ return [+ { value: "thisday", label: t`Today` },+ { value: "past1days", label: t`Yesterday` },+ { value: "past1weeks", label: t`Previous week` },+ { value: "past7days", label: t`Previous 7 days` },+ { value: "past30days", label: t`Previous 30 days` },+ { value: "past1months", label: t`Previous month` },+ { value: "past3months", label: t`Previous 3 months` },+ { value: "past12months", label: t`Previous 12 months` },+ ];+}++export function isPollingNeeded(runs: TransformJobRun[] = []) {+ return runs.some((run) => run.status === "started");+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.unit.spec.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.unit.spec.tsxnew file mode 100644index 00000000000..4b8d8010d1f--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunListPage.unit.spec.tsx@@ -0,0 +1,251 @@+import userEvent from "@testing-library/user-event";+import fetchMock from "fetch-mock";+import { Route } from "react-router";++import {+ setupGetTransformJobEndpoint,+ setupListJobRunTransformRunsEndpoint,+ setupListTransformJobRunsEndpoint,+ setupUserMetabotPermissionsEndpoint,+} from "__support__/server-mocks";+import {+ act,+ mockGetBoundingClientRect,+ renderWithProviders,+ screen,+ waitFor,+ within,+} from "__support__/ui";+import { POLLING_INTERVAL } from "metabase/transforms/constants";+import type {+ TransformJobRun,+ TransformRunForJobRun,+} from "metabase-types/api";+import {+ createMockListTransformJobRunsResponse,+ createMockTransformJob,+ createMockTransformJobRun,+ createMockTransformRunForJobRun,+} from "metabase-types/api/mocks";++import { JobRunListPage } from "./JobRunListPage";++const JOB_ID = 3;++type SetupOpts = {+ runs?: TransformJobRun[];+ transformRunsByRunId?: Record<number, TransformRunForJobRun[]>;+ initialRoute?: string;+};++function setup({+ runs = [],+ transformRunsByRunId = {},+ initialRoute = `/data-studio/transforms/jobs/${JOB_ID}/runs`,+}: SetupOpts = {}) {+ const job = createMockTransformJob({ id: JOB_ID, name: "Nightly job" });+ let currentRuns = runs;++ setupUserMetabotPermissionsEndpoint();+ setupGetTransformJobEndpoint(job);+ setupListTransformJobRunsEndpoint(JOB_ID, () =>+ createMockListTransformJobRunsResponse({+ data: currentRuns,+ total: currentRuns.length,+ }),+ );+ Object.entries(transformRunsByRunId).forEach(([runId, transformRuns]) => {+ setupListJobRunTransformRunsEndpoint(JOB_ID, Number(runId), transformRuns);+ });+ mockGetBoundingClientRect({ width: 1200, height: 800 });++ const path = "/data-studio/transforms/jobs/:jobId/runs";++ renderWithProviders(<Route path={path} component={JobRunListPage} />, {+ withRouter: true,+ initialRoute,+ });++ return {+ setRuns(nextRuns: TransformJobRun[]) {+ currentRuns = nextRuns;+ },+ };+}++function getLastRunsRequestParams() {+ const call = fetchMock.callHistory.lastCall(+ `path:/api/transform-job/${JOB_ID}/runs`,+ );+ if (!call) {+ throw new Error("Expected a request to the job runs endpoint");+ }+ return new URL(call.url).searchParams;+}++describe("JobRunListPage", () => {+ it("renders job runs with the job name and tabs", async () => {+ setup({+ runs: [createMockTransformJobRun({ id: 5, status: "succeeded" })],+ });++ expect(await screen.findAllByText("Nightly job")).not.toHaveLength(0);+ expect(+ screen.getByRole("link", { name: "Run history" }),+ ).toBeInTheDocument();+ expect(await screen.findByText("Success")).toBeInTheDocument();+ });++ it("shows an empty state when there are no runs", async () => {+ setup({ runs: [] });+ expect(await screen.findByText("No runs yet")).toBeInTheDocument();+ });++ it("opens the sidebar with the constituent transform runs on row click", async () => {+ const run = createMockTransformJobRun({ id: 5, status: "succeeded" });+ setup({+ runs: [run],+ transformRunsByRunId: {+ 5: [+ createMockTransformRunForJobRun({+ id: 17,+ status: "succeeded",+ transform_name: "transform_2",+ }),+ ],+ },+ });++ const row = await screen.findByRole("row", { name: /Success/ });+ await userEvent.click(row);++ const sidebar = await screen.findByTestId("job-run-list-sidebar");+ expect(await within(sidebar).findByText("transform_2")).toBeInTheDocument();+ });++ it("renders the error section for a failed transform run in the sidebar", async () => {+ const run = createMockTransformJobRun({ id: 8, status: "failed" });+ setup({+ runs: [run],+ transformRunsByRunId: {+ 8: [+ createMockTransformRunForJobRun({+ id: 21,+ status: "failed",+ transform_name: "broken_transform",+ message: 'relation "abc" does not exist',+ }),+ ],+ },+ });++ const row = await screen.findByRole("row", { name: /Failed/ });+ await userEvent.click(row);++ expect(+ await screen.findByRole("region", { name: "Error" }),+ ).toBeInTheDocument();+ });++ it("refreshes the sidebar transform runs when the run finishes while open", async () => {+ jest.useFakeTimers({ advanceTimers: true });++ try {+ const { setRuns } = setup({+ runs: [createMockTransformJobRun({ id: 5, status: "started" })],+ });++ let isFinished = false;+ setupListJobRunTransformRunsEndpoint(JOB_ID, 5, () => [+ createMockTransformRunForJobRun({+ id: 17,+ status: isFinished ? "succeeded" : "started",+ transform_name: "transform_f",+ }),+ ]);++ await userEvent.click(+ await screen.findByRole("row", { name: /In progress/ }),+ );+ const item = await screen.findByTestId("transform-run-item");+ expect(within(item).getByText("In progress")).toBeInTheDocument();++ // The run (and its transform) finish while the sidebar stays open; the+ // next poll should refresh the transform's status+ isFinished = true;+ setRuns([createMockTransformJobRun({ id: 5, status: "succeeded" })]);+ act(() => {+ jest.advanceTimersByTime(POLLING_INTERVAL);+ });++ expect(await within(item).findByText("Success")).toBeInTheDocument();+ } finally {+ jest.useRealTimers();+ }+ });++ describe("filters", () => {+ it("filters by status", async () => {+ setup({+ runs: [createMockTransformJobRun({ id: 5, status: "succeeded" })],+ });+ await screen.findByText("Success");++ await userEvent.click(screen.getByLabelText("Status"));+ await userEvent.click(+ await screen.findByRole("option", { name: "Failed" }),+ );++ await waitFor(() => {+ expect(getLastRunsRequestParams().get("status")).toBe("failed");+ });+ });++ it("filters by trigger (run method)", async () => {+ setup({+ runs: [createMockTransformJobRun({ id: 5, status: "succeeded" })],+ });+ await screen.findByText("Success");++ await userEvent.click(screen.getByLabelText("Trigger"));+ await userEvent.click(+ await screen.findByRole("option", { name: "Manual" }),+ );++ await waitFor(() => {+ expect(getLastRunsRequestParams().get("run-method")).toBe("manual");+ });+ });++ it("filters by start time", async () => {+ setup({+ runs: [createMockTransformJobRun({ id: 5, status: "succeeded" })],+ });+ await screen.findByText("Success");++ await userEvent.click(screen.getByLabelText("Started at"));+ await userEvent.click(+ await screen.findByRole("option", { name: "Previous 7 days" }),+ );++ await waitFor(() => {+ expect(getLastRunsRequestParams().get("start-time")).toBe("past7days");+ });+ });++ it("sends active filters from the URL in the request", async () => {+ setup({+ runs: [],+ initialRoute: `/data-studio/transforms/jobs/${JOB_ID}/runs?status=failed&run-method=manual&start-time=past7days`,+ });++ // With filters applied, the empty state reflects "not found" rather than "none yet".+ expect(await screen.findByText("No runs found")).toBeInTheDocument();++ const params = getLastRunsRequestParams();+ expect(params.get("status")).toBe("failed");+ expect(params.get("run-method")).toBe("manual");+ expect(params.get("start-time")).toBe("past7days");+ });+ });+});diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunInfoSection.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunInfoSection.tsxnew file mode 100644index 00000000000..e41f0253018--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunInfoSection.tsx@@ -0,0 +1,48 @@+import { t } from "ttag";++import { DateTime } from "metabase/common/components/DateTime";+import { SidebarInfoRow } from "metabase/transforms/components/SidebarInfoRow";+import {+ formatRunMethod,+ formatStatus,+ getRunDurationMs,+ isErrorStatus,+} from "metabase/transforms/utils";+import { Box, Card } from "metabase/ui";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";+import { formatDurationLong } from "metabase/utils/formatting/time";+import type { TransformJobRun } from "metabase-types/api";++type JobRunInfoSectionProps = {+ run: TransformJobRun;+};++export function JobRunInfoSection({ run }: JobRunInfoSectionProps) {+ const durationMs = getRunDurationMs(run);++ return (+ <Card p={0} shadow="none" withBorder role="region" aria-label={t`Info`}>+ <SidebarInfoRow label={t`Status`}>+ <Box c={isErrorStatus(run.status) ? "feedback-negative" : undefined}>+ {formatStatus(run.status)}+ </Box>+ </SidebarInfoRow>+ <SidebarInfoRow label={t`Trigger`}>+ {formatRunMethod(run.run_method)}+ </SidebarInfoRow>+ <SidebarInfoRow label={t`Started at`}>+ <DateTime value={run.start_time} unit="minute" />+ </SidebarInfoRow>+ {run.end_time != null && (+ <SidebarInfoRow label={t`Ended at`}>+ <DateTime value={run.end_time} unit="minute" />+ </SidebarInfoRow>+ )}+ <SidebarInfoRow label={t`Duration`}>+ {durationMs != null+ ? formatDurationLong(durationMs)+ : EMPTY_CELL_PLACEHOLDER}+ </SidebarInfoRow>+ </Card>+ );+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.module.css b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.module.cssnew file mode 100644index 00000000000..ce06f4b9e89--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.module.css@@ -0,0 +1,12 @@+.sidebar {+ border-left: 1px solid var(--mb-color-border-neutral);+}++.header {+ flex-shrink: 0;+ border-bottom: 1px solid var(--mb-color-border-neutral);+}++.scrollArea {+ overflow-y: auto;+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.tsxnew file mode 100644index 00000000000..a5e72d4b15f--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/JobRunSidebar.tsx@@ -0,0 +1,154 @@+import { memo, useState } from "react";+import { t } from "ttag";++import { useListJobRunTransformRunsQuery } from "metabase/api";+import { ListEmptyState } from "metabase/common/components/ListEmptyState";+import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";+import { SidebarResizableBox } from "metabase/transforms/components/SidebarResizableBox";+import { POLLING_INTERVAL } from "metabase/transforms/constants";+import {+ ActionIcon,+ Badge,+ Box,+ Card,+ FixedSizeIcon,+ Flex,+ Group,+ Stack,+ Title,+} from "metabase/ui";+import type {+ TransformJobId,+ TransformJobRun,+ TransformRunForJobRun,+} from "metabase-types/api";++import { JobRunInfoSection } from "./JobRunInfoSection";+import S from "./JobRunSidebar.module.css";+import { TransformRunItem } from "./TransformRunItem";++type JobRunSidebarProps = {+ jobId: TransformJobId;+ run: TransformJobRun;+ containerWidth: number;+ onResizeStart: () => void;+ onResizeStop: () => void;+ onClose: () => void;+};++export const JobRunSidebar = memo(function JobRunSidebar({+ jobId,+ run,+ containerWidth,+ onResizeStart,+ onResizeStop,+ onClose,+}: JobRunSidebarProps) {+ const [isPolling, setIsPolling] = useState(false);+ const {+ data: transformRuns = [],+ isLoading,+ error,+ } = useListJobRunTransformRunsQuery(+ { jobId, runId: run.id },+ { pollingInterval: isPolling ? POLLING_INTERVAL : undefined },+ );++ const shouldPoll =+ run.status === "started" ||+ transformRuns.some(+ (transformRun) =>+ transformRun.status === "started" ||+ transformRun.status === "canceling",+ );+ if (isPolling !== shouldPoll) {+ setIsPolling(shouldPoll);+ }++ return (+ <SidebarResizableBox+ containerWidth={containerWidth}+ onResizeStart={onResizeStart}+ onResizeStop={onResizeStop}+ >+ <Flex+ className={S.sidebar}+ direction="column"+ flex={1}+ h="100%"+ bg="background_page-primary"+ data-testid="job-run-list-sidebar"+ >+ <Box className={S.header} p="lg">+ <JobRunSidebarHeader onClose={onClose} />+ </Box>+ <Box className={S.scrollArea} flex={1} mih={0} p="lg">+ <Stack gap="xl">+ <JobRunInfoSection run={run} />+ <Stack gap="md">+ <Group gap="sm" wrap="nowrap">+ <Badge variant="filled" bg="core-brand">+ {transformRuns.length}+ </Badge>+ <Title order={5}>{t`Transforms`}</Title>+ </Group>+ <TransformRunList+ transformRuns={transformRuns}+ isLoading={isLoading}+ error={error}+ />+ </Stack>+ </Stack>+ </Box>+ </Flex>+ </SidebarResizableBox>+ );+});++type TransformRunListProps = {+ transformRuns: TransformRunForJobRun[];+ isLoading: boolean;+ error: unknown;+};++function TransformRunList({+ transformRuns,+ isLoading,+ error,+}: TransformRunListProps) {+ if (isLoading || error != null) {+ return <LoadingAndErrorWrapper loading={isLoading} error={error} />;+ }++ if (transformRuns.length === 0) {+ return <ListEmptyState label={t`No transform runs`} />;+ }++ return (+ <Card p={0} shadow="none" withBorder>+ {transformRuns.map((transformRun) => (+ <TransformRunItem key={transformRun.id} transformRun={transformRun} />+ ))}+ </Card>+ );+}++type JobRunSidebarHeaderProps = {+ onClose: () => void;+};++function JobRunSidebarHeader({ onClose }: JobRunSidebarHeaderProps) {+ return (+ <Group+ justify="space-between"+ align="center"+ wrap="nowrap"+ data-testid="job-run-list-sidebar-header"+ >+ <Title order={3}>{t`Job run`}</Title>+ <ActionIcon aria-label={t`Close`} onClick={onClose}>+ <FixedSizeIcon name="close" />+ </ActionIcon>+ </Group>+ );+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.module.css b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.module.cssnew file mode 100644index 00000000000..e011dc4e912--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.module.css@@ -0,0 +1,5 @@+.transformItem {+ &:not(:last-child) {+ border-bottom: 1px solid var(--mb-color-border-neutral);+ }+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.tsxnew file mode 100644index 00000000000..9a6e0009f66--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/TransformRunItem.tsx@@ -0,0 +1,102 @@+import { t } from "ttag";++import { DateTime } from "metabase/common/components/DateTime";+import { ForwardRefLink } from "metabase/common/components/Link";+import CS from "metabase/css/core/index.css";+import { ErrorSection } from "metabase/transforms/components/ErrorSection";+import {+ formatStatus,+ getRunDurationMs,+ getTransformRunName,+ isErrorStatus,+} from "metabase/transforms/utils";+import { Anchor, Box, FixedSizeIcon, Group, Stack, Tooltip } from "metabase/ui";+import * as Urls from "metabase/urls";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";+import { formatDurationLong } from "metabase/utils/formatting/time";+import type { TransformRunForJobRun } from "metabase-types/api";++import S from "./TransformRunItem.module.css";++type TransformRunItemProps = {+ transformRun: TransformRunForJobRun;+};++export function TransformRunItem({ transformRun }: TransformRunItemProps) {+ const name = transformRun.transform_name ?? getTransformRunName(transformRun);+ const transformId = transformRun.transform_id;+ const durationMs = getRunDurationMs(transformRun);++ return (+ <Group+ className={S.transformItem}+ p="md"+ gap="sm"+ wrap="nowrap"+ align="start"+ aria-label={name}+ data-testid="transform-run-item"+ >+ <FixedSizeIcon name="transform" />+ <Stack gap="sm" flex={1} miw={0}>+ <Box className={CS.textWrap} lh="1rem">+ {name}+ </Box>+ <Group gap="sm" wrap="nowrap" fz="sm" lh="1rem">+ <Box+ c={+ isErrorStatus(transformRun.status)+ ? "feedback-negative"+ : undefined+ }+ >+ {formatStatus(transformRun.status)}+ </Box>+ <Box c="text-secondary">•</Box>+ <Tooltip label={<TransformRunTimes run={transformRun} />}>+ <Box>+ {durationMs != null+ ? formatDurationLong(durationMs)+ : EMPTY_CELL_PLACEHOLDER}+ </Box>+ </Tooltip>+ {transformId != null && (+ <>+ <Box c="text-secondary">•</Box>+ <Anchor+ component={ForwardRefLink}+ to={Urls.transform(transformId)}+ target="_blank"+ lh="inherit"+ fz="inherit"+ >+ {t`View transform`}+ </Anchor>+ </>+ )}+ </Group>+ {transformRun.message != null && (+ <ErrorSection run={transformRun} showTitle={false} />+ )}+ </Stack>+ </Group>+ );+}++type TransformRunTimesProps = {+ run: TransformRunForJobRun;+};++function TransformRunTimes({ run }: TransformRunTimesProps) {+ return (+ <Group gap="xs" wrap="nowrap">+ <DateTime value={run.start_time} unit="minute" />+ {run.end_time != null && (+ <>+ {"–"}+ <DateTime value={run.end_time} unit="minute" />+ </>+ )}+ </Group>+ );+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/index.ts b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/index.tsnew file mode 100644index 00000000000..948ef4f900d--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunSidebar/index.ts@@ -0,0 +1 @@+export { JobRunSidebar } from "./JobRunSidebar";diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/JobRunTable.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/JobRunTable.tsxnew file mode 100644index 00000000000..2ae05d6868e--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/JobRunTable.tsx@@ -0,0 +1,83 @@+import type { Row, SortingState, Updater } from "@tanstack/react-table";+import { useCallback, useMemo } from "react";+import { t } from "ttag";++import { ListEmptyState } from "metabase/common/components/ListEmptyState";+import { useSetting } from "metabase/common/hooks";+import CS from "metabase/css/core/index.css";+import { Card, TreeTable, useTreeTableInstance } from "metabase/ui";+import type { TransformJobRun, TransformJobRunId } from "metabase-types/api";++import type { JobRunSortOptions } from "../types";++import { getColumns, getSortingOptions, getSortingState } from "./utils";++type JobRunTableProps = {+ runs: TransformJobRun[];+ hasFilters: boolean;+ sortOptions: JobRunSortOptions | undefined;+ onSortOptionsChange: (sortOptions: JobRunSortOptions | undefined) => void;+ onSelect: (runId: TransformJobRunId) => void;+};++export function JobRunTable({+ runs,+ hasFilters,+ sortOptions,+ onSortOptionsChange,+ onSelect,+}: JobRunTableProps) {+ const systemTimezone = useSetting("system-timezone");++ const columns = useMemo(() => getColumns(systemTimezone), [systemTimezone]);++ const sortingState = useMemo(+ () => getSortingState(sortOptions),+ [sortOptions],+ );++ const notFoundLabel = hasFilters ? t`No runs found` : t`No runs yet`;++ const handleRowClick = useCallback(+ (row: Row<TransformJobRun>) => {+ onSelect(row.original.id);+ },+ [onSelect],+ );++ const handleSortingChange = useCallback(+ (updater: Updater<SortingState>) => {+ const newSortingState =+ typeof updater === "function" ? updater(sortingState) : updater;+ onSortOptionsChange(getSortingOptions(newSortingState));+ },+ [sortingState, onSortOptionsChange],+ );++ const treeTableInstance = useTreeTableInstance<TransformJobRun>({+ data: runs,+ columns,+ sorting: sortingState,+ manualSorting: true,+ getNodeId: (run) => String(run.id),+ onSortingChange: handleSortingChange,+ });++ return (+ <Card+ className={CS.overflowHidden}+ p={0}+ flex="0 1 auto"+ mih={0}+ shadow="none"+ withBorder+ >+ <TreeTable+ instance={treeTableInstance}+ emptyState={<ListEmptyState label={notFoundLabel} />}+ ariaLabel={t`Job runs`}+ onRowClick={handleRowClick}+ />+ </Card>+ );+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/index.ts b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/index.tsnew file mode 100644index 00000000000..b54f2bf6f2e--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/index.ts@@ -0,0 +1 @@+export { JobRunTable } from "./JobRunTable";diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/utils.tsx b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/utils.tsxnew file mode 100644index 00000000000..78b1cf1fcac--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/JobRunTable/utils.tsx@@ -0,0 +1,153 @@+import type { SortingState } from "@tanstack/react-table";+import { t } from "ttag";++import { TimezoneIndicator } from "metabase/transforms/components/TimezoneIndicator";+import {+ formatRunMethod,+ formatStatus,+ getRunDurationMs,+ isErrorStatus,+ parseTimestampWithTimezone,+} from "metabase/transforms/utils";+import type { TreeTableColumnDef } from "metabase/ui";+import { Box, Ellipsified, Group, SortableHeaderPill } from "metabase/ui";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";+import { formatDurationLong } from "metabase/utils/formatting/time";+import {+ TRANSFORM_JOB_RUN_SORT_COLUMNS,+ type TransformJobRun,+ type TransformJobRunSortColumn,+} from "metabase-types/api";++import type { JobRunSortOptions } from "../types";++function getStatusColumn(): TreeTableColumnDef<TransformJobRun> {+ return {+ id: "status",+ header: t`Status`,+ width: 120,+ accessorFn: (row) => formatStatus(row.status),+ cell: ({ row }) => {+ const { status } = row.original;+ return (+ <Box c={isErrorStatus(status) ? "feedback-negative" : undefined}>+ {formatStatus(status)}+ </Box>+ );+ },+ };+}++function getRunMethodColumn(): TreeTableColumnDef<TransformJobRun> {+ return {+ id: "run-method",+ header: t`Trigger`,+ width: "auto",+ accessorFn: (row) => formatRunMethod(row.run_method),+ cell: ({ getValue }) => <Ellipsified>{String(getValue())}</Ellipsified>,+ };+}++function getStartedAtColumn(+ systemTimezone: string | undefined,+): TreeTableColumnDef<TransformJobRun> {+ return {+ id: "start_time" satisfies TransformJobRunSortColumn,+ header: ({ header }) => (+ <Group gap="xs" wrap="nowrap">+ <SortableHeaderPill+ name={t`Started at`}+ sort={header.column.getIsSorted() || undefined}+ />+ <TimezoneIndicator />+ </Group>+ ),+ width: "auto",+ enableSorting: true,+ accessorFn: (run) =>+ parseTimestampWithTimezone(run.start_time, systemTimezone).format("lll"),+ cell: ({ getValue }) => <Ellipsified>{String(getValue())}</Ellipsified>,+ };+}++function getEndedAtColumn(+ systemTimezone: string | undefined,+): TreeTableColumnDef<TransformJobRun> {+ return {+ id: "end_time" satisfies TransformJobRunSortColumn,+ header: ({ header }) => (+ <Group gap="xs" wrap="nowrap">+ <SortableHeaderPill+ name={t`Ended at`}+ sort={header.column.getIsSorted() || undefined}+ />+ <TimezoneIndicator />+ </Group>+ ),+ width: "auto",+ enableSorting: true,+ accessorFn: (run) =>+ run.end_time != null+ ? parseTimestampWithTimezone(run.end_time, systemTimezone).format("lll")+ : null,+ cell: ({ getValue }) => {+ const value = getValue<string | null>();+ if (value == null) {+ return EMPTY_CELL_PLACEHOLDER;+ }+ return <Ellipsified>{String(value)}</Ellipsified>;+ },+ };+}++function getDurationColumn(): TreeTableColumnDef<TransformJobRun> {+ return {+ id: "duration",+ header: t`Duration`,+ width: 120,+ accessorFn: (run) => getRunDurationMs(run),+ cell: ({ getValue }) => {+ const ms = getValue<number | null>();+ if (ms == null) {+ return EMPTY_CELL_PLACEHOLDER;+ }+ return <Ellipsified>{formatDurationLong(ms)}</Ellipsified>;+ },+ };+}++export function getColumns(+ systemTimezone: string | undefined,+): TreeTableColumnDef<TransformJobRun>[] {+ return [+ getStatusColumn(),+ getRunMethodColumn(),+ getStartedAtColumn(systemTimezone),+ getEndedAtColumn(systemTimezone),+ getDurationColumn(),+ ];+}++export function getSortingState(+ sortOptions: JobRunSortOptions | undefined,+): SortingState {+ return sortOptions != null+ ? [{ id: sortOptions.column, desc: sortOptions.direction === "desc" }]+ : [];+}++export function getSortingOptions(+ sortingState: SortingState,+): JobRunSortOptions | undefined {+ if (sortingState.length === 0) {+ return undefined;+ }++ const { id, desc } = sortingState[0];+ const column = TRANSFORM_JOB_RUN_SORT_COLUMNS.find((column) => column === id);+ if (column == null) {+ return undefined;+ }++ return { column, direction: desc ? "desc" : "asc" };+}diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/constants.ts b/frontend/src/metabase/transforms/pages/JobRunListPage/constants.tsnew file mode 100644index 00000000000..bfab9067148--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/constants.ts@@ -0,0 +1 @@+export const PAGE_SIZE = 20;diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/index.ts b/frontend/src/metabase/transforms/pages/JobRunListPage/index.tsnew file mode 100644index 00000000000..73b374b7a47--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/index.ts@@ -0,0 +1 @@+export { JobRunListPage } from "./JobRunListPage";diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/types.ts b/frontend/src/metabase/transforms/pages/JobRunListPage/types.tsnew file mode 100644index 00000000000..ee2d599fb51--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/types.ts@@ -0,0 +1,9 @@+import type {+ SortDirection,+ TransformJobRunSortColumn,+} from "metabase-types/api";++export type JobRunSortOptions = {+ column: TransformJobRunSortColumn;+ direction: SortDirection;+};diff --git a/frontend/src/metabase/transforms/pages/JobRunListPage/utils.ts b/frontend/src/metabase/transforms/pages/JobRunListPage/utils.tsnew file mode 100644index 00000000000..bd209285d80--- /dev/null+++ b/frontend/src/metabase/transforms/pages/JobRunListPage/utils.ts@@ -0,0 +1,41 @@+import type { Location } from "history";++import * as Urls from "metabase/urls";+import {+ SORT_DIRECTIONS,+ TRANSFORM_JOB_RUN_SORT_COLUMNS,+ TRANSFORM_JOB_RUN_STATUSES,+ TRANSFORM_RUN_METHODS,+} from "metabase-types/api";++import type { JobRunSortOptions } from "./types";++export function getParsedParams(+ location: Location,+): Urls.TransformJobRunListParams {+ const {+ page,+ status,+ "run-method": runMethod,+ "start-time": startTime,+ "sort-column": sortColumn,+ "sort-direction": sortDirection,+ } = location.query;++ return {+ page: Urls.parseNumberParam(page),+ status: Urls.parseEnumParam(status, TRANSFORM_JOB_RUN_STATUSES),+ runMethod: Urls.parseEnumParam(runMethod, TRANSFORM_RUN_METHODS),+ startTime: Urls.parseStringParam(startTime),+ sortColumn: Urls.parseEnumParam(sortColumn, TRANSFORM_JOB_RUN_SORT_COLUMNS),+ sortDirection: Urls.parseEnumParam(sortDirection, SORT_DIRECTIONS),+ };+}++export function getSortOptions(+ params: Urls.TransformJobRunListParams,+): JobRunSortOptions | undefined {+ return params.sortColumn != null && params.sortDirection != null+ ? { column: params.sortColumn, direction: params.sortDirection }+ : undefined;+}diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.module.css b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.module.cssdeleted file mode 100644index cf225830fc0..00000000000--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.module.css+++ /dev/null@@ -1,5 +0,0 @@-.section {- &:not(:last-child) {- border-bottom: 1px solid var(--mb-color-border);- }-}diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.tsxindex 7d060d032c2..0f8ffb4c03c 100644--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.tsx+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/InfoSection/InfoSection.tsx@@ -1,21 +1,18 @@-import { type ReactNode, useId } from "react";import { t } from "ttag";import { skipToken, useGetFieldQuery } from "metabase/api";import { DateTime } from "metabase/common/components/DateTime";-import CS from "metabase/css/core/index.css";-import { Box, Card, Stack } from "metabase/ui";+import { Box, Card } from "metabase/ui";import type { TransformRun } from "metabase-types/api";import { CheckpointValue } from "../../../../components/CheckpointValue";+import { SidebarInfoRow } from "../../../../components/SidebarInfoRow";import {formatRunMethod,formatStatus,isErrorStatus,} from "../../../../utils";-import S from "./InfoSection.module.css";-type InfoSectionProps = {run: TransformRun;};@@ -29,73 +26,43 @@ export function InfoSection({ run }: InfoSectionProps) {return (<Card p={0} shadow="none" withBorder role="region" aria-label={t`Info`}>- <InfoSectionItem label={t`Started at`}>+ <SidebarInfoRow label={t`Started at`}><DateTime value={run.start_time} unit="minute" />- </InfoSectionItem>+ </SidebarInfoRow>{run.end_time != null && (- <InfoSectionItem label={t`Ended at`}>+ <SidebarInfoRow label={t`Ended at`}><DateTime value={run.end_time} unit="minute" />- </InfoSectionItem>+ </SidebarInfoRow>)}- <InfoSectionItem label={t`Status`}>- <Box c={isErrorStatus(run.status) ? "error" : undefined}>+ <SidebarInfoRow label={t`Status`}>+ <Box c={isErrorStatus(run.status) ? "feedback-negative" : undefined}>{formatStatus(run.status)}</Box>- </InfoSectionItem>- <InfoSectionItem label={t`Trigger`}>+ </SidebarInfoRow>+ <SidebarInfoRow label={t`Trigger`}>{formatRunMethod(run.run_method)}- </InfoSectionItem>+ </SidebarInfoRow>{checkpointField != null && (- <InfoSectionItem label={t`Checkpoint field`}>+ <SidebarInfoRow label={t`Checkpoint field`}>{checkpointField.display_name}- </InfoSectionItem>+ </SidebarInfoRow>)}{run.checkpoint_lo_value != null && (- <InfoSectionItem label={t`Checkpoint from`}>+ <SidebarInfoRow label={t`Checkpoint from`}><CheckpointValuevalue={run.checkpoint_lo_value}checkpointField={checkpointField}/>- </InfoSectionItem>+ </SidebarInfoRow>)}{run.checkpoint_hi_value != null && (- <InfoSectionItem label={t`Checkpoint to`}>+ <SidebarInfoRow label={t`Checkpoint to`}><CheckpointValuevalue={run.checkpoint_hi_value}checkpointField={checkpointField}/>- </InfoSectionItem>+ </SidebarInfoRow>)}</Card>);}--type InfoSectionItemProps = {- label: string;- children?: ReactNode;-};--function InfoSectionItem({ label, children }: InfoSectionItemProps) {- const labelId = useId();-- return (- <Stack- className={S.section}- p="md"- gap="xs"- role="group"- aria-labelledby={labelId}- >- <Box- id={labelId}- className={CS.textWrap}- c="text-secondary"- fz="sm"- lh="h5"- >- {label}- </Box>- <Box lh="h4">{children}</Box>- </Stack>- );-}diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/RunSidebar.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/RunSidebar.tsxindex d994773a959..aff1d98dc95 100644--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/RunSidebar.tsx+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/RunSidebar.tsx@@ -1,15 +1,15 @@import { memo } from "react";+import { ErrorSection } from "metabase/transforms/components/ErrorSection";+import { SidebarResizableBox } from "metabase/transforms/components/SidebarResizableBox";import { Stack } from "metabase/ui";import type { TransformRun } from "metabase-types/api";import { CancelationSection } from "./CancelationSection";-import { ErrorSection } from "./ErrorSection";import { InfoSection } from "./InfoSection";import { LocationSection } from "./LocationSection";import S from "./RunSidebar.module.css";import { SidebarHeader } from "./SidebarHeader";-import { SidebarResizableBox } from "./SidebarResizableBox";type RunSidebarProps = {run: TransformRun;@@ -36,7 +36,7 @@ export const RunSidebar = memo(function RunSidebar({className={S.sidebar}p="lg"gap="xl"- bg="background-primary"+ bg="background_page-primary"data-testid="run-list-sidebar"><Stack gap="lg">diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunTable/utils.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunTable/utils.tsxindex aef03571eb1..3c3fb9dfe45 100644--- a/frontend/src/metabase/transforms/pages/RunListPage/RunTable/utils.tsx+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunTable/utils.tsx@@ -1,6 +1,7 @@import type { SortingState } from "@tanstack/react-table";import { t } from "ttag";+import { TimezoneIndicator } from "metabase/transforms/components/TimezoneIndicator";import {formatRunMethod,formatStatus,@@ -31,7 +32,6 @@ import {import type { TransformRunSortOptions } from "../types";import { TagList } from "./TagList";-import { TimezoneIndicator } from "./TimezoneIndicator";function getTransformColumn(): TreeTableColumnDef<TransformRun> {return {@@ -53,7 +53,7 @@ function getTransformColumn(): TreeTableColumnDef<TransformRun> {{isTransformDeleted ? (<Tooltip label={t`${value} has been deleted`}><Text- c="text-tertiary"+ c="text-disabled"component="span"display="inline"fs="italic"@@ -161,7 +161,7 @@ function getStatusColumn(): TreeTableColumnDef<TransformRun> {cell: ({ row }) => {const { status } = row.original;return (- <Box c={isErrorStatus(status) ? "error" : undefined}>+ <Box c={isErrorStatus(status) ? "feedback-negative" : undefined}>{formatStatus(status)}</Box>);diff --git a/frontend/src/metabase/transforms/routes.tsx b/frontend/src/metabase/transforms/routes.tsxindex bfeca8b45f6..111fd630fac 100644--- a/frontend/src/metabase/transforms/routes.tsx+++ b/frontend/src/metabase/transforms/routes.tsx@@ -8,6 +8,7 @@ import {import { JobListPage } from "./pages/JobListPage";import { JobPage } from "./pages/JobPage";+import { JobRunListPage } from "./pages/JobRunListPage";import { JobSectionLayout } from "./pages/JobSectionLayout";import { NewJobPage } from "./pages/NewJobPage";import {@@ -32,6 +33,7 @@ export function getDataStudioTransformRoutes() {<IndexRoute component={JobListPage} /><Route path="new" component={NewJobPage} /><Route path=":jobId" component={JobPage} />+ <Route path=":jobId/runs" component={JobRunListPage} /></Route><Route path="new/query" component={NewQueryTransformPage} />diff --git a/frontend/src/metabase/urls/transforms.ts b/frontend/src/metabase/urls/transforms.tsindex 96e46d245d6..9092ce3bc51 100644--- a/frontend/src/metabase/urls/transforms.ts+++ b/frontend/src/metabase/urls/transforms.ts@@ -6,6 +6,8 @@ import type {TableId,TransformId,TransformJobId,+ TransformJobRunSortColumn,+ TransformJobRunStatus,TransformRunMethod,TransformRunSortColumn,TransformRunStatus,@@ -93,6 +95,51 @@ export function transformJob(id: TransformJobId) {return `${JOBS_ROOT_URL}/${id}`;}+export type TransformJobRunListParams = {+ page?: number;+ status?: TransformJobRunStatus;+ runMethod?: TransformRunMethod;+ startTime?: string;+ sortColumn?: TransformJobRunSortColumn;+ sortDirection?: SortDirection;+};++export function transformJobRuns(+ id: TransformJobId,+ {+ page,+ status,+ runMethod,+ startTime,+ sortColumn,+ sortDirection,+ }: TransformJobRunListParams = {},+) {+ const searchParams = new URLSearchParams();+ if (page != null) {+ searchParams.set("page", String(page));+ }+ if (status != null) {+ searchParams.set("status", status);+ }+ if (runMethod != null) {+ searchParams.set("run-method", runMethod);+ }+ if (startTime != null) {+ searchParams.set("start-time", startTime);+ }+ if (sortColumn != null) {+ searchParams.set("sort-column", sortColumn);+ }+ if (sortDirection != null) {+ searchParams.set("sort-direction", sortDirection);+ }++ const queryString = searchParams.toString();+ const baseUrl = `${JOBS_ROOT_URL}/${id}/runs`;+ return queryString.length > 0 ? `${baseUrl}?${queryString}` : baseUrl;+}+export type TransformRunListParams = {page?: number;statuses?: TransformRunStatus[];diff --git a/frontend/test/__support__/server-mocks/transform.ts b/frontend/test/__support__/server-mocks/transform.tsindex 011d6ff9715..7f6e1315516 100644--- a/frontend/test/__support__/server-mocks/transform.ts+++ b/frontend/test/__support__/server-mocks/transform.ts@@ -3,11 +3,14 @@ import fetchMock from "fetch-mock";import type {Dataset,InspectorLensId,+ ListTransformJobRunsResponse,ListTransformRunsResponse,Transform,TransformId,TransformJob,TransformJobId,+ TransformJobRunId,+ TransformRunForJobRun,TransformTag,} from "metabase-types/api";@@ -54,6 +57,24 @@ export function setupGetTransformJobEndpoint(job: TransformJob) {fetchMock.get(`path:/api/transform-job/${job.id}`, job);}+export function setupListTransformJobRunsEndpoint(+ jobId: TransformJobId,+ response: ListTransformJobRunsResponse | (() => ListTransformJobRunsResponse),+) {+ fetchMock.get(`path:/api/transform-job/${jobId}/runs`, response);+}++export function setupListJobRunTransformRunsEndpoint(+ jobId: TransformJobId,+ runId: TransformJobRunId,+ runs: TransformRunForJobRun[] | (() => TransformRunForJobRun[]),+) {+ fetchMock.get(+ `path:/api/transform-job/${jobId}/runs/${runId}/transform-runs`,+ runs,+ );+}+export function setupCreateTransformJobEndpoint(job: TransformJob) {fetchMock.post("path:/api/transform-job", job);}