Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Update skill files to avoid agents accidentally running the entire unit test suite (#83875)

Kevin Kelleherdcb183785a6d
diff --git a/.claude/skills/_shared/typescript-commands.md b/.claude/skills/_shared/typescript-commands.md
index eeffc2d3fb8..63a19181c19 100644
--- a/.claude/skills/_shared/typescript-commands.md
+++ b/.claude/skills/_shared/typescript-commands.md
@@ -11,7 +11,7 @@
### JavaScript/TypeScript Tests
-- **Test a specific file:** `bun run test-unit-keep-cljs path/to/file.unit.spec.js`
+- **Test a specific file:** `bun run test-unit-keep-cljs --testPathPatterns=path/to/file.unit.spec.ts`
- **Test by pattern:** `bun run test-unit-keep-cljs -t "pattern"`
- Runs tests matching the given pattern
diff --git a/.claude/skills/fe-modularization/SKILL.md b/.claude/skills/fe-modularization/SKILL.md
index a7e7cd2561c..be82254e1e9 100644
--- a/.claude/skills/fe-modularization/SKILL.md
+++ b/.claude/skills/fe-modularization/SKILL.md
@@ -201,7 +201,7 @@ prefix; never generic `-shared` / `-feature` suffixes.
bunx eslint --no-warn-ignored <touched files>
bun run lint-oxlint # enforce-module-public-api included
bun run type-check-pure
- bun run test-unit-keep-cljs <touched folders' specs>
+ bun run test-unit-keep-cljs --testPathPatterns=<touched folders' specs>
bun run module-boundaries 2>&1 | tail -1 # after; no violation may name the new files
bun run build-release:static-viz # only if viz/static-viz/ui/dayjs touched; hard 3.5 MiB budget
```
diff --git a/dev/bot/common/test-strategy.md b/dev/bot/common/test-strategy.md
index 2f978585ee5..deb6d99fc91 100644
--- a/dev/bot/common/test-strategy.md
+++ b/dev/bot/common/test-strategy.md
@@ -42,5 +42,5 @@ Search for existing tests of the buggy function/component first — add to the e
### Running tests
- **Backend**: `./bin/test-agent :only '[metabase.foo-test/issue-12345-test]'`
-- **Frontend unit**: `bun run test-unit-keep-cljs path/to/file.unit.spec.ts`
+- **Frontend unit**: `bun run test-unit-keep-cljs --testPathPatterns=path/to/file.unit.spec.ts`
- **Cypress**: `npx cypress run --spec e2e/test/scenarios/category/file.cy.spec.ts`
diff --git a/dev/bot/reprobot-agent.md b/dev/bot/reprobot-agent.md
index c35e5cea48d..3e572181b59 100644
--- a/dev/bot/reprobot-agent.md
+++ b/dev/bot/reprobot-agent.md
@@ -108,7 +108,7 @@ For each attempt (up to 3):
3. Write a minimal failing test that demonstrates the bug
4. Run the test to confirm it fails:
- **Backend**: `./bin/test-agent :only '[namespace/test-name]'`
- - **Frontend**: `bun run test-unit-keep-cljs path/to/file.unit.spec.ts`
+ - **Frontend**: `bun run test-unit-keep-cljs --testPathPatterns=path/to/file.unit.spec.ts`
5. Save the test changes as a patch: `git diff > {{OUTPUT_DIR}}/test-diff.patch`
If you can't write a useful test (complex setup, external dependencies), note the reason and skip to Phase 4.