The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Trigger the stats workflows from Run tests, gated on the uberjar artifact (#82244)
Romeo Van Snickdcb85ae92455
diff --git a/.github/workflows/bundle-size-stats.yml b/.github/workflows/bundle-size-stats.ymlindex 56ab968f3bd..e57b1a9f652 100644--- a/.github/workflows/bundle-size-stats.yml+++ b/.github/workflows/bundle-size-stats.yml@@ -4,25 +4,54 @@ name: Bundle Size Stats# emitted JS) plus the bundle-stats and embedding-sdk artifacts, measures# initial/total bundle sizes, and appends them to eng-stats-importer.+# Triggered by "Run tests", which is the workflow that builds the uberjar on a+# master merge.on:workflow_run:- workflows: ["Build Uberjar"]+ workflows: ["Run tests"]types: [completed]# Master only: releases form non-linear lines whose deltas are meaningless,# so their sizes are backfilled separately rather than logged here.branches: [master]+ workflow_call:+ inputs:+ commit:+ description: "Commit SHA to measure."+ type: string+ required: false+ default: ""concurrency:- group: bundle-size-stats-${{ github.event.workflow_run.head_sha }}+ group: bundle-size-stats-${{ inputs.commit || github.event.workflow_run.head_sha }}cancel-in-progress: truejobs:+ # "Run tests" concludes `failure` on master more often than `success`, from+ # jobs that have nothing to do with the jar, so its conclusion is not a usable+ # gate. The artifact is one: the uberjar job publishes it, and a docs-only+ # merge that skipped that job publishes none.+ uberjar-built:+ if: ${{ github.repository == 'metabase/metabase' }}+ runs-on: ${{ vars.SLIM_RUNNER_KEY }}+ timeout-minutes: 5+ outputs:+ found: ${{ steps.probe.outputs.fetch-hit }}+ steps:+ - uses: actions/checkout@v6+ - id: probe+ uses: ./.github/actions/fetch-artifact+ with:+ commit: ${{ inputs.commit || github.event.workflow_run.head_sha }}+ edition: ee+ download: false+bundle-size-stats:- if: ${{ github.event.workflow_run.conclusion == 'success' && github.repository == 'metabase/metabase' }}+ needs: [uberjar-built]+ if: ${{ needs.uberjar-built.outputs.found == 'true' }}runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}timeout-minutes: 15env:- HEAD_SHA: ${{ github.event.workflow_run.head_sha }}+ HEAD_SHA: ${{ inputs.commit || github.event.workflow_run.head_sha }}# Only record a data point when a bundle's as-served size (brotli where the# build ships .br, else gzip) moved by at least this percent vs the last# plotted point, keeping the chart to real changes.@@ -31,12 +60,12 @@ jobs:- name: Check out the codeuses: actions/checkout@v6with:- ref: ${{ github.event.workflow_run.head_sha }}+ ref: ${{ env.HEAD_SHA }}- uses: ./.github/actions/prepare-node-bun- name: Download EE uberjaruses: ./.github/actions/fetch-artifactwith:- commit: ${{ github.event.workflow_run.head_sha }}+ commit: ${{ env.HEAD_SHA }}edition: eeextract-path: temp/uberjar- name: Extract front-end bundles from uberjar@@ -108,7 +137,7 @@ jobs:run: bun ./.github/scripts/bundle-size-stats-prepare.ts- name: Import sizes (with deltas) into Statsid: upload- if: steps.prepare.outputs.significant == 'true'+ if: ${{ steps.prepare.outputs.significant == 'true' && inputs.commit == '' }}env:ROWS: artifacts/upload-rows.jsonENG_STATS_URL: ${{ secrets.ENG_STATS_URL }}diff --git a/.github/workflows/test.bundle-load-stats.yml b/.github/workflows/test.bundle-load-stats.ymlindex 49f0bea2a86..9f297ee3293 100644--- a/.github/workflows/test.bundle-load-stats.yml+++ b/.github/workflows/test.bundle-load-stats.yml@@ -8,17 +8,15 @@ name: Bundle Load Stats# signed-in user alone, so seeding content would not change a single byte of the# document this measures.+# Triggered by "Run tests", which is the workflow that builds the uberjar on a+# master merge.on:workflow_run:- workflows: ["Build Uberjar"]+ workflows: ["Run tests"]types: [completed]# Master only: a release forms a non-linear line whose times cannot be# compared against the commit before it.branches: [master]- # A `workflow_run` workflow always runs the copy on the default branch, so a- # change here cannot be tried out before it merges. The call lets a PR run- # this branch's copy against the uberjar CI already built. A called run- # measures and reports; it does not write rows to Stats.workflow_call:inputs:commit:@@ -32,8 +30,28 @@ concurrency:cancel-in-progress: truejobs:+ # "Run tests" concludes `failure` on master more often than `success`, from+ # jobs that have nothing to do with the jar, so its conclusion is not a usable+ # gate. The artifact is one: the uberjar job publishes it, and a docs-only+ # merge that skipped that job publishes none.+ uberjar-built:+ if: ${{ github.repository == 'metabase/metabase' }}+ runs-on: ${{ vars.SLIM_RUNNER_KEY }}+ timeout-minutes: 5+ outputs:+ found: ${{ steps.probe.outputs.fetch-hit }}+ steps:+ - uses: actions/checkout@v6+ - id: probe+ uses: ./.github/actions/fetch-artifact+ with:+ commit: ${{ inputs.commit || github.event.workflow_run.head_sha }}+ edition: ee+ download: false+bundle-load-stats:- if: ${{ github.repository == 'metabase/metabase' && (inputs.commit != '' || github.event.workflow_run.conclusion == 'success') }}+ needs: [uberjar-built]+ if: ${{ needs.uberjar-built.outputs.found == 'true' }}runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}timeout-minutes: 10env: