The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix tracking event never set to default in embed (#68407)
Sébastiendd00b33545e4
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/get-code.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/get-code.cy.spec.tsindex 7afb99d0c18..d6e900328bd 100644--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/get-code.cy.spec.ts+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/get-code.cy.spec.ts@@ -12,10 +12,7 @@ const { H } = cy;const DASHBOARD_NAME = "Orders in a dashboard";const QUESTION_NAME = "Orders, Count";-const suiteTitle =- "scenarios > embedding > sdk iframe embed setup > get code step";--describe(suiteTitle, () => {+describe("scenarios > embedding > sdk iframe embed setup > get code step", () => {beforeEach(() => {H.restore();H.resetSnowplow();@@ -160,6 +157,18 @@ describe(suiteTitle, () => {});});+ it("should track embed_wizard_options_completed with settings=default properly (metabase#68285)", () => {+ navigateToGetCodeStep({+ experience: "chart",+ resourceName: QUESTION_NAME,+ });++ H.expectUnstructuredSnowplowEvent({+ event: "embed_wizard_options_completed",+ event_detail: "settings=default",+ });+ });+it("should not include useExistingUserSession when SSO is selected", () => {enableJwtAuth();diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.tsindex a415270a69f..626c1bbe8bc 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.ts+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.ts@@ -63,6 +63,7 @@ export const getDefaultSdkIframeEmbedSettings = ({withDownloads: false,withTitle: true,isSaveEnabled: false,+ initialSqlParameters: {},}),).with(diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.unit.spec.tsindex 35ce62c5d50..60074228e2d 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.unit.spec.ts+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.unit.spec.ts@@ -43,6 +43,7 @@ describe("getDefaultSdkIframeEmbedSettings", () => {withDownloads: false,withTitle: true,isSaveEnabled: false,+ initialSqlParameters: {},},},{