Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Wire the `test-driver` action to work with the Quarantine switch (#77476)

Nemanja Glumacdea12ca75cdb
diff --git a/.github/actions/test-driver/action.yml b/.github/actions/test-driver/action.yml
index 9940e6debab..55cef4e83df 100644
--- a/.github/actions/test-driver/action.yml
+++ b/.github/actions/test-driver/action.yml
@@ -14,8 +14,15 @@ inputs:
description: Suffix to append to the test logs artifact name to avoid conflicts in matrix jobs
edition:
required: false
- default: 'ee'
+ default: "ee"
description: Edition to test (oss or ee)
+ quarantine-engine:
+ required: false
+ driver-status:
+ required: false
+ default: ""
+ description: >-
+ Configured status for this driver ("info", "skip", "required", or empty), as reported by `mage driver-decisions`.
outputs:
test-outcome:
@@ -39,35 +46,25 @@ runs:
run: bun run build-static-viz
shell: bash
env:
- MB_EDITION: ee
+ MB_EDITION: ${{ inputs.edition }}
+
- name: Test database driver
run: clojure -X:dev:ci:${{ inputs.edition }}:${{ inputs.edition }}-dev:drivers:drivers-dev:test ${{ inputs.test-args }}
shell: bash
id: run-test
- # Trunk Quarantine controls the final state of the run in the CI!
- # Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
- # whether to fail or to pass the whole job, based on the quarantine list.
+ # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
+ # Driver "info" status can affect this logic. See below.
continue-on-error: true
+
- name: Report failed tests to ci-conductor
- # Positioned right after the test run (before the report/upload steps) so it
- # reads pristine JUnit. Gated to non-clean runs + continue-on-error so it can
- # never change the job outcome — Trunk Quarantine remains the sole arbiter.
- # junit-name is the per-job identity label (e.g. be-tests-postgres-ee); only
- # workflows that also set CI_CONDUCTOR_BASE_URL actually POST. See DEV-2224 /
- # DEV-2235.
- if: ${{ always() && steps.run-test.outcome != 'success' }}
+ if: ${{ !cancelled() && steps.run-test.outcome == 'failure' }}
+ # This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
test-suite: ${{ inputs.junit-name }}
adapter: backend
- - name: Quarantine gate (dry run)
- if: ${{ always() && steps.run-test.outcome != 'success' }}
- continue-on-error: true
- uses: ./.github/actions/quarantine-gate
- with:
- adapter: backend
- test-suite: ${{ inputs.junit-name }}
+
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 # v3.0.0
# As per the documentation: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#steps-context
@@ -81,6 +78,7 @@ runs:
list-suites: failed
list-tests: failed
fail-on-error: false
+
- name: Upload Logs on Failure
if: always() && steps.run-test.outcome != 'success'
uses: actions/upload-artifact@v7
@@ -90,3 +88,20 @@ runs:
retention-days: 1
# Failing to upload the artifact should never affect the outcome of the whole test run.
continue-on-error: true
+
+ # Last, because this is the only step allowed to fail the job: everything above it reports the
+ # failure (JUnit report, logs, ci-conductor) and must run regardless of the verdict below.
+ - name: Quarantine gate
+ # Off master and release branches an "info" driver is data-collection only - the test always passes!
+ # On master and release branches "info" carries no weight - the quarantine logic applies.
+ if: |
+ !cancelled()
+ && steps.run-test.outcome == 'failure'
+ && !(inputs.driver-status == 'info'
+ && !(github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')))
+ continue-on-error: ${{ inputs.quarantine-engine != 'ci-conductor' }}
+ uses: ./.github/actions/quarantine-gate
+ with:
+ adapter: backend
+ test-suite: ${{ inputs.junit-name }}
+ enforce-quarantine: ${{ inputs.quarantine-engine == 'ci-conductor' }}
diff --git a/.github/workflows/app-db.yml b/.github/workflows/app-db.yml
index 4e2fc2626f8..760ec252c15 100644
--- a/.github/workflows/app-db.yml
+++ b/.github/workflows/app-db.yml
@@ -76,7 +76,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
- startsWith(github.ref_name, 'release-')
+ startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -120,6 +120,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -131,6 +132,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mysql:
if: ${{ !inputs.skip }}
@@ -191,7 +193,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
- startsWith(github.ref_name, 'release-')
+ startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -243,6 +245,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -254,6 +257,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-postgres:
if: ${{ !inputs.skip }}
@@ -307,7 +311,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
- startsWith(github.ref_name, 'release-')
+ startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -353,6 +357,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -364,6 +369,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
app-db-tests-result:
needs:
diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
index b90edb41f7b..5fcce0880f1 100644
--- a/.github/workflows/backend.yml
+++ b/.github/workflows/backend.yml
@@ -45,7 +45,7 @@ jobs:
be-linter-eastwood-test:
# Master / release safety net: lint every backend test namespace.
- if: ${{ !inputs.skip && github.event_name == 'push' && (github.ref_name == 'master' || startsWith(github.ref_name, 'release-')) }}
+ if: ${{ !inputs.skip && github.event_name == 'push' && (github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')) }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
name: Eastwood (tests only)
@@ -167,7 +167,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
- startsWith(github.ref_name, 'release-')
+ startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -197,15 +197,12 @@ jobs:
clojure -X:dev:ci:test:${{ matrix.job.edition }}:${{ matrix.job.edition }}-dev
:exclude-tags '[:mb/driver-tests ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
${{ matrix.job.test-args }}
- # Keep this step continue-on-error because the quarantine gate controls whether it ultimately fails.
+ # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Report failed tests to ci-conductor
- # Positioned between the test run and "Upload Test Results" so it reads
- # pristine JUnit (before Trunk quarantine processing). Gated to non-clean
- # runs + continue-on-error so it can never change the job outcome — Trunk
- # Quarantine remains the sole arbiter. See DEV-2224 / DEV-2235.
- if: ${{ always() && steps.run-java-tests.outcome != 'success' }}
+ if: ${{ !cancelled() && steps.run-java-tests.outcome == 'failure' }}
+ # This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
diff --git a/.github/workflows/drivers.yml b/.github/workflows/drivers.yml
index 0aceaca33cd..02dbf572d49 100644
--- a/.github/workflows/drivers.yml
+++ b/.github/workflows/drivers.yml
@@ -46,6 +46,7 @@ jobs:
sqlserver-should-run: ${{ steps.driver-decisions.outputs.sqlserver-should-run }}
vertica-should-run: ${{ steps.driver-decisions.outputs.vertica-should-run }}
# Per-driver configured status from ci-test-config (skip | info | required)
+ h2-status: ${{ steps.driver-decisions.outputs.h2-status }}
athena-status: ${{ steps.driver-decisions.outputs.athena-status }}
bigquery-status: ${{ steps.driver-decisions.outputs.bigquery-status }}
clickhouse-status: ${{ steps.driver-decisions.outputs.clickhouse-status }}
@@ -56,6 +57,7 @@ jobs:
mongo-sharded-cluster-status: ${{ steps.driver-decisions.outputs.mongo-sharded-cluster-status }}
mysql-mariadb-status: ${{ steps.driver-decisions.outputs.mysql-mariadb-status }}
oracle-status: ${{ steps.driver-decisions.outputs.oracle-status }}
+ postgres-status: ${{ steps.driver-decisions.outputs.postgres-status }}
presto-jdbc-status: ${{ steps.driver-decisions.outputs.presto-jdbc-status }}
redshift-status: ${{ steps.driver-decisions.outputs.redshift-status }}
snowflake-status: ${{ steps.driver-decisions.outputs.snowflake-status }}
@@ -136,7 +138,7 @@ jobs:
./bin/mage -driver-decisions "${MAGE_ARGS[@]}" --github-output-only >> $GITHUB_OUTPUT
env:
BASE_REF: ${{ github.event.pull_request.base.ref || github.ref_name }}
- IS_MASTER_OR_RELEASE: ${{ github.ref_name == 'master' || startsWith(github.ref_name, 'release-') }}
+ IS_MASTER_OR_RELEASE: ${{ github.ref_name == 'master' || startsWith(github.ref_name, 'release-x') }}
shell: bash
be-tests-athena-ee:
@@ -177,6 +179,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.athena-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -190,6 +194,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.athena-status }}
report-variant: ${{ matrix.job.name }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-bigquery-cloud-sdk-ee:
needs: determine-driver-skips
@@ -253,6 +258,8 @@ jobs:
junit-name: 'be-tests-bigquery-cloud-sdk-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.bigquery-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -266,6 +273,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.bigquery-status }}
report-variant: ${{ matrix.job.name }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -338,6 +346,8 @@ jobs:
junit-name: 'be-tests-clickhouse-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.clickhouse-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -349,6 +359,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.clickhouse-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -392,6 +404,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -403,6 +417,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-databricks-ee:
needs: determine-driver-skips
@@ -463,6 +479,8 @@ jobs:
with:
junit-name: 'be-tests-databricks-ee'
test-args: ${{ matrix.job.test-args }}
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -476,6 +494,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
report-variant: ${{ matrix.job.name }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-databricks-multi-catalog-ee:
needs: determine-driver-skips
@@ -537,6 +556,8 @@ jobs:
with:
junit-name: 'be-tests-databricks-multi-catalog-ee'
test-args: ${{ matrix.job.test-args }}
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -550,6 +571,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
report-variant: ${{ matrix.job.name }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-h2:
needs: determine-driver-skips
@@ -569,6 +591,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -580,6 +604,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-h2-oss:
needs: determine-driver-skips
@@ -600,6 +626,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -611,6 +639,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mysql-mariadb:
needs: determine-driver-skips
@@ -673,7 +703,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
- startsWith(github.ref_name, 'release-')
+ startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -730,6 +760,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -741,6 +773,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -810,6 +844,8 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.mongo-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -821,6 +857,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.mongo-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -892,6 +930,8 @@ jobs:
test-args: >-
:exclude-tags '[:mongo-sharded-cluster-tests :mb/transforms-python-test]'
:only-tags [:mb/driver-tests]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -903,6 +943,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mongo-sharded-cluster-ee:
needs: determine-driver-skips
@@ -937,6 +979,8 @@ jobs:
junit-name: 'be-tests-mongo-sharded-cluster-ee'
test-args: >-
:only metabase.driver.mongo.sharded-cluster-test
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -948,6 +992,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-oracle:
needs: determine-driver-skips
@@ -1022,6 +1068,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.oracle-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1033,6 +1081,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.oracle-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-postgres:
needs: determine-driver-skips
@@ -1075,7 +1125,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
- startsWith(github.ref_name, 'release-')
+ startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -1126,6 +1176,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.postgres-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1137,6 +1189,9 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.postgres-status }}
+ report-variant: ${{ matrix.version.name }}-${{ matrix.job.name }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -1213,6 +1268,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1224,6 +1281,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-redshift-ee:
needs: determine-driver-skips
@@ -1297,6 +1356,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.redshift-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: ${{ !matrix.job.skip && !cancelled() }}
@@ -1310,6 +1371,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.redshift-status }}
report-variant: ${{ matrix.job.name }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1382,6 +1444,8 @@ jobs:
junit-name: 'be-tests-snowflake-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.snowflake-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1395,6 +1459,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.snowflake-status }}
report-variant: ${{ matrix.job.name }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1436,6 +1501,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.sparksql-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1447,6 +1514,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.sparksql-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-sqlite-ee:
needs: determine-driver-skips
@@ -1477,6 +1546,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.sqlite-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1488,6 +1559,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.sqlite-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-sqlserver:
needs: determine-driver-skips
@@ -1553,6 +1626,8 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.version.name }}
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.sqlserver-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1564,6 +1639,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.sqlserver-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1678,6 +1755,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.vertica-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1689,6 +1768,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ driver-status: ${{ needs.determine-driver-skips.outputs.vertica-status }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
drivers-tests-result:
needs:
@@ -1742,11 +1823,13 @@ jobs:
"be-tests-clickhouse-ee": "${{ needs.determine-driver-skips.outputs.clickhouse-status }}",
"be-tests-databricks-ee": "${{ needs.determine-driver-skips.outputs.databricks-status }}",
"be-tests-druid-jdbc-ee": "${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}",
+ "be-tests-h2": "${{ needs.determine-driver-skips.outputs.h2-status }}",
"be-tests-mongo": "${{ needs.determine-driver-skips.outputs.mongo-status }}",
"be-tests-mongo-ssl": "${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}",
"be-tests-mongo-sharded-cluster-ee": "${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}",
"be-tests-mysql-mariadb": "${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}",
"be-tests-oracle": "${{ needs.determine-driver-skips.outputs.oracle-status }}",
+ "be-tests-postgres": "${{ needs.determine-driver-skips.outputs.postgres-status }}",
"be-tests-presto-jdbc-ee": "${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}",
"be-tests-redshift-ee": "${{ needs.determine-driver-skips.outputs.redshift-status }}",
"be-tests-snowflake-ee": "${{ needs.determine-driver-skips.outputs.snowflake-status }}",
diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
index ff1215d2cb1..3a9154e186e 100644
--- a/.github/workflows/e2e-test.yml
+++ b/.github/workflows/e2e-test.yml
@@ -164,7 +164,7 @@ jobs:
node e2e/runner/run_cypress_ci.js e2e \
--expose grepTags="-@mongo+-@python+-@OSS+-@skip" \
--spec "$SPEC_PATH"
- # Keep this step continue-on-error because the quarantine gate controls whether it ultimately fails.
+ # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Run Tagged EE Cypress tests on ${{ inputs.name }}
@@ -179,7 +179,7 @@ jobs:
node e2e/runner/run_cypress_ci.js e2e \
--expose grepTags="${{inputs.tags && format('{0}+-@skip', inputs.tags) || '-@mongo+-@python+-@OSS+-@skip'}}" \
--spec "$SPEC_PATH"
- # Keep this step continue-on-error because the quarantine gate controls whether it ultimately fails.
+ # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Rewrite JUnit hook failures
diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml
index a28ad150078..f7e6c04e774 100644
--- a/.github/workflows/frontend.yml
+++ b/.github/workflows/frontend.yml
@@ -110,14 +110,11 @@ jobs:
- name: Run frontend unit tests
id: fe-tests
run: bun run test-unit --silent --shard=${{ matrix.shard }}/${{ env.SHARDS }}
- # Keep this step continue-on-error because the quarantine gate controls whether it ultimately fails.
+ # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Report failed tests to ci-conductor
- # Positioned between the test run and "Upload Test Results" so it reads
- # pristine JUnit (before Trunk quarantine processing). Gated to non-clean
- # runs + continue-on-error so it can never change the job outcome — Trunk
- # Quarantine remains the sole arbiter. See DEV-2224 / DEV-2235.
- if: ${{ always() && steps.fe-tests.outcome != 'success' }}
+ if: ${{ !cancelled() && steps.fe-tests.outcome == 'failure' }}
+ # This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
diff --git a/.github/workflows/semantic-search.yml b/.github/workflows/semantic-search.yml
index 830848b2a4a..dc6faf705dc 100644
--- a/.github/workflows/semantic-search.yml
+++ b/.github/workflows/semantic-search.yml
@@ -61,6 +61,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -72,6 +73,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-mariadb:
if: ${{ !inputs.skip }}
@@ -134,6 +136,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -145,6 +148,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-mysql:
if: ${{ !inputs.skip }}
@@ -207,6 +211,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -218,6 +223,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-postgres:
if: ${{ !inputs.skip }}
@@ -281,6 +287,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
+ quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -292,6 +299,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
+ run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-result:
needs: