The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Forward-port regression tests for Issue 66405 affecting v0.56 (#66557)
Timothy S. Deandeafc8488679
diff --git a/enterprise/backend/test/metabase_enterprise/sandbox/query_processor/middleware/sandboxing_test.clj b/enterprise/backend/test/metabase_enterprise/sandbox/query_processor/middleware/sandboxing_test.cljindex fc281e153de..ed019d2b996 100644--- a/enterprise/backend/test/metabase_enterprise/sandbox/query_processor/middleware/sandboxing_test.clj+++ b/enterprise/backend/test/metabase_enterprise/sandbox/query_processor/middleware/sandboxing_test.clj@@ -29,6 +29,8 @@[metabase.query-processor.util.add-alias-info :as add][metabase.request.core :as request][metabase.test :as mt]+ [metabase.test.data :as data]+ [metabase.test.data.interface :as tx][metabase.test.fixtures :as fixtures][metabase.test.util :as tu][metabase.util :as u]@@ -1718,3 +1720,64 @@(met/with-gtaps! {:gtaps {:venues (venues-category-native-sandbox-def)}, :attributes {"cat" 50}}(mt/with-premium-features #{}(is (thrown-with-msg? clojure.lang.ExceptionInfo sandboxing-disabled-error (run-venues-count-query))))))))++(def ^:private long-names-dataset+ (tx/dataset-definition+ "long-column-names"+ [["long_table"+ [{:field-name "column_name_with_an_incredibly_verbose_and_exceedingly_detailed_description_that_never_seems_to_end"+ :base-type :type/Text}+ {:field-name "second_column_name_that_is_even_more_over_the_top_with_its_unnecessarily_expansive_wording"+ :base-type :type/Text}]+ [["First row, first column" "First row, second column"]+ ["Second row, first column" "Second row, second column"]]]]))++(deftest long-native-query-names-sandboxed-basic-test+ (testing "Issue #66405: Sandboxing with native SQL query should work with long column names"+ (data/dataset long-names-dataset+ (met/with-gtaps! {:gtaps {:long_table {:query (mt/native-query {:query "SELECT * FROM LONG_TABLE"})}}}+ (is (=? {:status "completed"+ :row_count 2}+ (mt/user-http-request :rasta :post 202 "dataset"+ (mt/mbql-query long_table {:limit 5}))))))))++(deftest long-native-query-names-sandboxed-row-filtering-test+ (testing "Issue #66405: with row filtering (verifies sandbox is actually applied)"+ (data/dataset long-names-dataset+ (met/with-gtaps! {:gtaps {:long_table {:query (mt/native-query {:query "SELECT * FROM LONG_TABLE WHERE LONG_TABLE.COLUMN_NAME_WITH_AN_INCREDIBLY_VERBOSE_AND_EXCEEDINGLY_DETAILED_DESCRIPTION_THAT_NEVER_SEEMS_TO_END LIKE 'First%'"})}}}+ (let [result (mt/user-http-request :rasta :post 202 "dataset"+ (mt/mbql-query long_table))]+ (is (=? {:status "completed"+ :row_count 1}+ result))+ (is (= "First row, first column"+ ;; The first column (index 0) is the auto-generated ID, the text column is at index 1+ (-> result :data :rows first second))))))))++(deftest long-native-query-names-sandboxed-column-filtering-test+ (testing "Issue #66405: with column restriction (only returns subset of columns)"+ (data/dataset long-names-dataset+ (met/with-gtaps! {:gtaps {:long_table {:query (mt/native-query {:query "SELECT COLUMN_NAME_WITH_AN_INCREDIBLY_VERBOSE_AND_EXCEEDINGLY_DETAILED_DESCRIPTION_THAT_NEVER_SEEMS_TO_END FROM LONG_TABLE"})}}}+ (let [result (mt/user-http-request :rasta :post 202 "dataset"+ (mt/mbql-query long_table))]+ (is (=? {:status "completed"+ :row_count 2}+ result))+ ;; Should only have 1 column (the long-named one), not 2 text columns + ID+ (is (= 1 (count (-> result :data :cols))))+ (is (= [["First row, first column"]+ ["Second row, first column"]]+ (-> result :data :rows))))))))++(deftest long-native-query-names-sandboxed-attribute-test+ (testing "Issue #66405: with attribute-based sandbox (no query, just remappings)"+ (data/dataset long-names-dataset+ (met/with-gtaps! {:gtaps {:long_table {:remappings {:col1 ["variable" [:field (data/id :long_table :column_name_with_an_incredibly_verbose_and_exceedingly_detailed_description_that_never_seems_to_end) nil]]}}}+ :attributes {:col1 "First row, first column"}}+ (let [result (mt/user-http-request :rasta :post 202 "dataset"+ (mt/mbql-query long_table))]+ (is (=? {:status "completed"+ :row_count 1}+ result))+ (is (= ["First row, first column" "First row, second column"]+ (->> result :data :rows first (drop 1)))))))))