Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

[Mutation Testing] Kill mutations in metabase.lib.field/find-visible-column-for-ref (#69320)

Eric Normanddf7d834e2eb5
diff --git a/test/metabase/lib/field_test.cljc b/test/metabase/lib/field_test.cljc
index 1781f0c6249..74b956cf2bb 100644
--- a/test/metabase/lib/field_test.cljc
+++ b/test/metabase/lib/field_test.cljc
@@ -1631,6 +1631,27 @@
:display-name "User ID"}
(lib/find-visible-column-for-ref query col-ref))))))
+(deftest ^:parallel find-visible-column-for-ref-aggregation-test
+ (testing "find-visible-column-for-ref works with aggregation refs"
+ (let [query (-> (lib/query meta/metadata-provider (meta/table-metadata :orders))
+ (lib/aggregate (lib/count)))
+ agg-cols (filter #(= :source/aggregations (:lib/source %))
+ (lib/returned-columns query))
+ agg-ref (lib/ref (first agg-cols))]
+ (is (=? {:lib/type :metadata/column
+ :display-name "Count"}
+ (lib/find-visible-column-for-ref query agg-ref))))))
+
+(deftest ^:parallel find-visible-column-for-ref-multi-stage-test
+ (testing "2-arity find-visible-column-for-ref uses last stage"
+ (let [query (-> (lib/query meta/metadata-provider (meta/table-metadata :orders))
+ (lib/aggregate (lib/count))
+ lib/append-stage)
+ cols (lib/visible-columns query)
+ col (first cols)
+ field-ref (lib/ref col)]
+ (is (some? (lib/find-visible-column-for-ref query field-ref))))))
+
(deftest ^:parallel self-join-ambiguity-test
(testing "Even when doing a tree-like self join, fields are matched correctly"
(let [base (-> (lib/query meta/metadata-provider (meta/table-metadata :orders))