The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Closes EMB-854 escape single quotes in embed code snippets (#64242)
Sébastiene01cbfc87ed1
diff --git a/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk_setup/utils/embed-snippet.ts b/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk_setup/utils/embed-snippet.tsindex 31442c83974..f38e66f42a9 100644--- a/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk_setup/utils/embed-snippet.ts+++ b/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk_setup/utils/embed-snippet.ts@@ -84,9 +84,11 @@ const toDashCase = (str: string): string =>str.replace(/[A-Z]/g, (letter) => `-${letter.toLowerCase()}`);// Convert values to string attributes-const formatAttributeValue = (value: unknown): string => {+export const formatAttributeValue = (value: unknown): string => {if (Array.isArray(value) || typeof value === "object") {- return `'${JSON.stringify(value)}'`;+ const jsonString = JSON.stringify(value);+ const escapedString = jsonString.replace(/'/g, "&39;");+ return `'${escapedString}'`;}return `"${value}"`;diff --git a/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk_setup/utils/embed-snippet.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk_setup/utils/embed-snippet.unit.spec.tsnew file mode 100644index 00000000000..86c3930fc7f--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk_setup/utils/embed-snippet.unit.spec.ts@@ -0,0 +1,63 @@+import { formatAttributeValue } from "./embed-snippet";++describe("formatAttributeValue", () => {+ it("should format string values correctly", () => {+ expect(formatAttributeValue("hello")).toBe('"hello"');+ });++ it("should format number values correctly", () => {+ expect(formatAttributeValue(42)).toBe('"42"');+ expect(formatAttributeValue(3.14)).toBe('"3.14"');+ });++ it("should format boolean values correctly", () => {+ expect(formatAttributeValue(true)).toBe('"true"');+ expect(formatAttributeValue(false)).toBe('"false"');+ });++ it("should format array values correctly", () => {+ expect(formatAttributeValue([1, 2, 3])).toBe("'[1,2,3]'");+ expect(formatAttributeValue(["a", "b", "c"])).toBe('\'["a","b","c"]\'');+ expect(formatAttributeValue([1, "b", true])).toBe("'[1,\"b\",true]'");+ });++ it("should HTML escape single quotes in array and objects", () => {+ expect(formatAttributeValue(["O'Reilly", "D'Angelo"])).toBe(+ `'["O&39;Reilly","D&39;Angelo"]'`,+ );+ expect(formatAttributeValue({ quote: "It's a test" })).toBe(+ `'{"quote":"It&39;s a test"}'`,+ );+ });++ it("should HTML escape single quotes in nested arrays and objects", () => {+ expect(+ formatAttributeValue([{ name: "O'Reilly" }, { name: "D'Angelo" }]),+ ).toBe(`'[{"name":"O&39;Reilly"},{"name":"D&39;Angelo"}]'`);+ expect(formatAttributeValue({ nested: { quote: "It's a test" } })).toBe(+ `'{"nested":{"quote":"It&39;s a test"}}'`,+ );+ });++ it("should format object values correctly", () => {+ expect(formatAttributeValue({ key: "value" })).toBe(`'{"key":"value"}'`);+ expect(formatAttributeValue({ a: 1, b: true })).toBe(`'{"a":1,"b":true}'`);+ });++ it("should handle nested arrays and objects", () => {+ expect(formatAttributeValue([{ a: 1 }, { b: 2 }])).toBe(+ `'[{"a":1},{"b":2}]'`,+ );+ expect(+ formatAttributeValue([+ [1, 2],+ [3, 4],+ ]),+ ).toBe("'[[1,2],[3,4]]'");+ });++ it("should handle null and undefined values", () => {+ expect(formatAttributeValue(null)).toBe("'null'");+ expect(formatAttributeValue(undefined)).toBe('"undefined"');+ });+});