Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

run loki tests through run-tests.yml (#82370)

Chris Vandoodewaarde0b1eac73d29
diff --git a/.github/workflows/loki.yml b/.github/workflows/loki.yml
index 28137ecfb1a..7d8b6502bcf 100644
--- a/.github/workflows/loki.yml
+++ b/.github/workflows/loki.yml
@@ -1,30 +1,21 @@
name: Loki Visual Regression Testing
on:
- pull_request:
+ workflow_call:
+ inputs:
+ skip:
+ type: boolean
+ default: false
-jobs:
- files-changed:
- name: Check which files changed
- runs-on: ${{ vars.SLIM_RUNNER_KEY }}
- timeout-minutes: 3
- outputs:
- frontend_ci: ${{ steps.changes.outputs.frontend_ci }}
- frontend_sources: ${{ steps.changes.outputs.frontend_sources }}
- frontend_loki_ci: ${{ steps.changes.outputs.frontend_loki_ci }}
- steps:
- - uses: actions/checkout@v6
- - name: Test which files changed
- uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
- id: changes
- with:
- token: ${{ github.token }}
- filters: .github/file-paths.yaml
+concurrency:
+ group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-loki
+ cancel-in-progress: true
+jobs:
visual-test:
- needs: files-changed
- if: needs.files-changed.outputs.frontend_ci == 'true' || needs.files-changed.outputs.frontend_sources == 'true' || needs.files-changed.outputs.frontend_loki_ci == 'true'
+ if: ${{ !inputs.skip }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
+ timeout-minutes: 30
services:
docker:
image: docker:19.03.12
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 08b3d894c35..09d7d00a1af 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -57,8 +57,10 @@ jobs:
build_scripts: ${{ steps.changes.outputs.build_scripts }}
embedder_plugin: ${{ steps.changes.outputs.embedder_plugin }}
frontend_all: ${{ steps.changes.outputs.frontend_all }}
+ frontend_ci: ${{ steps.changes.outputs.frontend_ci }}
frontend_sources: ${{ steps.changes.outputs.frontend_sources }}
frontend_unit_infra: ${{ steps.changes.outputs.frontend_unit_infra }}
+ frontend_loki_ci: ${{ steps.changes.outputs.frontend_loki_ci }}
frontend_loki_infra: ${{ steps.changes.outputs.frontend_loki_infra }}
shared_sources: ${{ steps.changes.outputs.shared_sources }}
documentation: ${{ steps.changes.outputs.documentation }}
@@ -289,6 +291,20 @@ jobs:
${{ needs.should-run.outputs.verdict != 'force-run' &&
needs.files-changed.outputs.custom_viz_all != 'true' }}
+ loki-tests:
+ needs: [should-run, files-changed]
+ if: |
+ !cancelled() &&
+ (needs.should-run.outputs.verdict == 'force-run' ||
+ needs.files-changed.result == 'success')
+ uses: ./.github/workflows/loki.yml
+ with:
+ skip: >-
+ ${{ needs.should-run.outputs.verdict != 'force-run' &&
+ needs.files-changed.outputs.frontend_ci != 'true' &&
+ needs.files-changed.outputs.frontend_sources != 'true' &&
+ needs.files-changed.outputs.frontend_loki_ci != 'true' }}
+
e2e-tests:
needs: [should-run, files-changed, uberjar]
# Skip e2e tests when the uberjar build failed or was cancelled — the