The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
[BOT-1247] Fix empty string content blocks in anthropic API (#71765)
Tyler Pludee0ba625be482
diff --git a/src/metabase/metabot/agent/core.clj b/src/metabase/metabot/agent/core.cljindex 5f802cafe68..8ced532870d 100644--- a/src/metabase/metabot/agent/core.clj+++ b/src/metabase/metabot/agent/core.clj@@ -584,6 +584,10 @@result))(catch Exception e(prometheus/inc! :metabase-metabot/agent-errors labels)+ (when (:api-error (ex-data e))+ (log/debugf "API error details: status=%s body=%s"+ (:status (ex-data e))+ (pr-str (:body (ex-data e)))))(if (:api-error (ex-data e))(log/errorf "Agent loop API error: %s" (ex-message e))(log/error e "Agent loop error"))diff --git a/src/metabase/metabot/self/claude.clj b/src/metabase/metabot/self/claude.cljindex 9fd0d765313..764e1c6e04b 100644--- a/src/metabase/metabot/self/claude.clj+++ b/src/metabase/metabot/self/claude.clj@@ -118,9 +118,10 @@(defn- ->content-blocks"Coerce content into a sequence of Claude content blocks."[content]- (if (and (string? content) (not (str/blank? content)))- [{:type "text" :text content}]- content))+ (cond+ (and (string? content) (str/blank? content)) []+ (string? content) [{:type "text" :text content}]+ :else content))(defn- merge-consecutive"Merge consecutive assistant messages into a single message with combined content.diff --git a/test/metabase/metabot/self/claude_test.clj b/test/metabase/metabot/self/claude_test.cljindex 85e2aa7069d..9876020972d 100644--- a/test/metabase/metabot/self/claude_test.clj+++ b/test/metabase/metabot/self/claude_test.clj@@ -128,3 +128,23 @@:content #"Error:.*failed"}]}](claude/parts->claude-messages[{:type :tool-output :id "call-1" :error {:message "Tool failed"}}])))))++(deftest ^:parallel parts->claude-messages-blank-content-test+ (testing "blank string content is filtered out during merge"+ ;; When Claude streams tokens, whitespace-only chunks can arrive separately.+ ;; These must not become bare strings in the content array (which would cause+ ;; API errors), so they are dropped during merge-consecutive.+ (is (=? [{:role "assistant"+ :content [{:type "text" :text "Hello"}+ {:type "text" :text "world"}]}]+ (claude/parts->claude-messages+ [{:type :text :text "Hello"}+ {:type :text :text " "}+ {:type :text :text "world"}]))))+ (testing "empty string content is also filtered out"+ (is (=? [{:role "assistant"+ :content [{:type "text" :text "Hello"}]}]+ (claude/parts->claude-messages+ [{:type :text :text ""}+ {:type :text :text "Hello"}+ {:type :text :text ""}])))))