The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
GDGT-1516 add datetime formatting to Task Run Monitoring features (#68427)
Egor Grushine2f7cc9d860e
diff --git a/e2e/test/scenarios/admin/tools/tools.cy.spec.ts b/e2e/test/scenarios/admin/tools/tools.cy.spec.tsindex 4fa98c21f9f..6aaba172474 100644--- a/e2e/test/scenarios/admin/tools/tools.cy.spec.ts+++ b/e2e/test/scenarios/admin/tools/tools.cy.spec.ts@@ -244,7 +244,7 @@ describe("scenarios > admin > tools > tasks", () => {cy.window().then((window) => {cy.stub(window.navigator.clipboard, "writeText").resolves();});- cy.icon("copy").click();+ cy.findByTestId("code-container").icon("copy").click();cy.window().its("navigator.clipboard.writeText").should("be.calledWith", formattedTaskJson);diff --git a/frontend/src/metabase-types/api/mocks/task.ts b/frontend/src/metabase-types/api/mocks/task.tsindex a8b86eaefda..e1a937d8626 100644--- a/frontend/src/metabase-types/api/mocks/task.ts+++ b/frontend/src/metabase-types/api/mocks/task.ts@@ -1,4 +1,4 @@-import type { Task } from "metabase-types/api";+import type { Task, TaskRun, TaskRunExtended } from "metabase-types/api";export const createMockTask = (task?: Partial<Task>): Task => ({id: 1,@@ -13,3 +13,25 @@ export const createMockTask = (task?: Partial<Task>): Task => ({run_id: task?.run_id ?? null,...task,});++export const createMockTaskRun = (taskRun?: Partial<TaskRun>): TaskRun => ({+ id: 1,+ run_type: "sync",+ entity_type: "database",+ entity_id: 1,+ started_at: "2023-03-04T01:45:26.005475-08:00",+ ended_at: "2023-03-04T01:45:26.518597-08:00",+ status: "success",+ entity_name: "Sample Database",+ task_count: 3,+ success_count: 3,+ failed_count: 0,+ ...taskRun,+});++export const createMockTaskRunExtended = (+ taskRunExtended?: Partial<TaskRunExtended>,+): TaskRunExtended => ({+ ...createMockTaskRun(taskRunExtended),+ tasks: taskRunExtended?.tasks ?? [],+});diff --git a/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.tsx b/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.tsxindex 773e722f134..a6804f95e76 100644--- a/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.tsx@@ -6,6 +6,7 @@ import _ from "underscore";import { useGetTaskQuery, useListDatabasesQuery } from "metabase/api";import { CodeEditor } from "metabase/common/components/CodeEditor";import { CopyButton } from "metabase/common/components/CopyButton";+import DateTime from "metabase/common/components/DateTime";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";import { openSaveDialog } from "metabase/lib/dom";import * as Urls from "metabase/lib/urls";@@ -19,6 +20,7 @@ import {Stack,Text,Title,+ Tooltip,} from "metabase/ui";import type { Database } from "metabase-types/api";@@ -67,7 +69,7 @@ export const TaskDetailsPage = ({ params }: TaskDetailsPageProps) => {</Link></Flex>- <Stack>+ <Stack gap="sm"><Title order={3}>{t`Task details`}</Title><Flex gap="md"><Text fw="bold" w={120}>{t`ID`}</Text>@@ -104,13 +106,31 @@ export const TaskDetailsPage = ({ params }: TaskDetailsPageProps) => {{isLoadingDatabases ? <Loader size="xs" /> : db ? dbEngine : "—"}</Text></Flex>- <Flex gap="md">+ <Flex gap="md" align="baseline"><Text fw="bold" w={120}>{t`Started at`}</Text>- <Text>{task.started_at}</Text>+ <Tooltip label={task.started_at}>+ <DateTime+ value={task.started_at}+ unit="minute"+ data-testid="started-at"+ />+ </Tooltip>+ <CopyButton value={task.started_at} /></Flex><Flex gap="md"><Text fw="bold" w={120}>{t`Ended at`}</Text>- <Text>{task.ended_at ?? "—"}</Text>+ {task.ended_at ? (+ <Tooltip label={task.ended_at}>+ <DateTime+ value={task.ended_at}+ unit="minute"+ data-testid="ended-at"+ />+ </Tooltip>+ ) : (+ "—"+ )}+ {task.ended_at && <CopyButton value={task.ended_at} />}</Flex><Flex gap="md"><Text fw="bold" w={120}>{t`Duration (ms)`}</Text>@@ -129,6 +149,7 @@ export const TaskDetailsPage = ({ params }: TaskDetailsPageProps) => {p={linesCount > 1 ? 0 : "xs"}pos="relative"mt="md"+ data-testid="code-container"><CodeEditorlanguage="json"diff --git a/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.unit.spec.tsx b/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.unit.spec.tsxnew file mode 100644index 00000000000..b99558d5fc1--- /dev/null+++ b/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.unit.spec.tsx@@ -0,0 +1,141 @@+import { useClipboard } from "@mantine/hooks";+import userEvent from "@testing-library/user-event";+import { Route } from "react-router";++import {+ setupDatabasesEndpoints,+ setupTaskEndpoint,+} from "__support__/server-mocks";+import {+ renderWithProviders,+ screen,+ waitForLoaderToBeRemoved,+ within,+} from "__support__/ui";+import * as Urls from "metabase/lib/urls";+import type { Task } from "metabase-types/api";+import { createMockTask } from "metabase-types/api/mocks";+import { createSampleDatabase } from "metabase-types/api/mocks/presets";++import { TaskDetailsPage } from "./TaskDetailsPage";++jest.mock("@mantine/hooks", () => ({+ ...jest.requireActual("@mantine/hooks"),+ useClipboard: jest.fn(),+}));++const mockUseClipboard = useClipboard as jest.Mock;++const PATHNAME = `${Urls.adminToolsTasksList()}/:taskId`;++interface SetupOpts {+ task?: Task;+}++const setup = ({ task = createMockTask() }: SetupOpts = {}) => {+ setupDatabasesEndpoints([createSampleDatabase()]);+ setupTaskEndpoint(task);++ return renderWithProviders(+ <Route path={PATHNAME} component={TaskDetailsPage} />,+ {+ initialRoute: Urls.adminToolsTaskDetails(task.id),+ withRouter: true,+ },+ );+};++describe("TaskDetailsPage", () => {+ beforeEach(() => {+ mockUseClipboard.mockReturnValue({+ copy: jest.fn(),+ copied: false,+ reset: jest.fn(),+ error: null,+ });+ });++ it("should display task details", async () => {+ const task = createMockTask({+ id: 42,+ task: "sync-database",+ status: "success",+ });++ setup({ task });++ await waitForLoaderToBeRemoved();++ expect(screen.getByText("Task details")).toBeInTheDocument();+ expect(screen.getByText("42")).toBeInTheDocument();+ expect(screen.getByText("sync-database")).toBeInTheDocument();+ });++ it("should display formatted datetime for started_at and ended_at", async () => {+ const task = createMockTask({+ started_at: "2023-03-04T01:45:26.005475-08:00",+ ended_at: "2023-03-04T01:46:26.518597-08:00",+ });++ setup({ task });++ await waitForLoaderToBeRemoved();++ const startedAtElement = screen.getByTestId("started-at");+ const endedAtElement = screen.getByTestId("ended-at");+ expect(startedAtElement).toHaveTextContent("March 4, 2023, 1:45 AM");+ expect(endedAtElement).toHaveTextContent("March 4, 2023, 1:46 AM");+ });++ it("should show raw ISO timestamp in tooltip on hover", async () => {+ const rawTimestamp = "2023-03-04T01:45:26.005475-08:00";+ const task = createMockTask({+ started_at: rawTimestamp,+ ended_at: "2023-03-04T01:46:26.518597-08:00",+ });++ setup({ task });++ await waitForLoaderToBeRemoved();++ const startedAtElement = screen.getByTestId("started-at");+ await userEvent.hover(startedAtElement);++ expect(await screen.findByRole("tooltip")).toHaveTextContent(rawTimestamp);+ });++ it("should copy raw ISO timestamp to clipboard when clicking copy button", async () => {+ const copyMock = jest.fn();+ mockUseClipboard.mockReturnValue({+ copy: copyMock,+ copied: false,+ reset: jest.fn(),+ error: null,+ });++ const startedAt = "2023-03-04T01:45:26.005475-08:00";+ const endedAt = "2023-03-04T01:46:26.518597-08:00";+ const task = createMockTask({+ started_at: startedAt,+ ended_at: endedAt,+ });++ setup({ task });++ await waitForLoaderToBeRemoved();++ const copyButtons = screen.getAllByTestId("copy-button");++ const startedAtCopyIcon = within(copyButtons[0]).getByRole("img", {+ name: "copy icon",+ });+ await userEvent.click(startedAtCopyIcon);+ expect(copyMock).toHaveBeenCalledWith(startedAt);++ const endedAtCopyIcon = within(copyButtons[1]).getByRole("img", {+ name: "copy icon",+ });+ await userEvent.click(endedAtCopyIcon);+ expect(copyMock).toHaveBeenCalledWith(endedAt);+ });+});diff --git a/frontend/src/metabase/admin/tools/components/TaskListPage/TaskListPage.unit.spec.tsx b/frontend/src/metabase/admin/tools/components/TaskListPage/TaskListPage.unit.spec.tsxindex f902b34f0d9..6d3ce1828c0 100644--- a/frontend/src/metabase/admin/tools/components/TaskListPage/TaskListPage.unit.spec.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskListPage/TaskListPage.unit.spec.tsx@@ -604,6 +604,49 @@ describe("TaskListPage", () => {"http://localhost/api/task?limit=50&offset=0&sort_column=duration&sort_direction=asc",]);});++ it("should display formatted datetime for started_at and ended_at", async () => {+ setup({+ tasksResponse: createMockTasksResponse({+ data: [+ createMockTask({+ started_at: "2023-03-04T01:45:26.005475-08:00",+ ended_at: "2023-03-04T01:46:26.518597-08:00",+ }),+ ],+ }),+ });++ await waitForLoaderToBeRemoved();++ const row = screen.getByTestId("task");+ const startedAtElement = within(row).getByTestId("started-at");+ const endedAtElement = within(row).getByTestId("ended-at");+ expect(startedAtElement).toHaveTextContent("March 4, 2023, 1:45 AM");+ expect(endedAtElement).toHaveTextContent("March 4, 2023, 1:46 AM");+ });++ it("should show raw ISO timestamp in tooltip on hover", async () => {+ const rawTimestamp = "2023-03-04T01:45:26.005475-08:00";+ setup({+ tasksResponse: createMockTasksResponse({+ data: [+ createMockTask({+ started_at: rawTimestamp,+ ended_at: "2023-03-04T01:46:26.518597-08:00",+ }),+ ],+ }),+ });++ await waitForLoaderToBeRemoved();++ const row = screen.getByTestId("task");+ const startedAtElement = within(row).getByTestId("started-at");+ await userEvent.hover(startedAtElement);++ expect(await screen.findByRole("tooltip")).toHaveTextContent(rawTimestamp);+ });});function createMockTasksResponse(diff --git a/frontend/src/metabase/admin/tools/components/TaskListPage/TasksTable.tsx b/frontend/src/metabase/admin/tools/components/TaskListPage/TasksTable.tsxindex 80e09fe8ae6..ad90bbf936a 100644--- a/frontend/src/metabase/admin/tools/components/TaskListPage/TasksTable.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskListPage/TasksTable.tsx@@ -4,6 +4,7 @@ import { t } from "ttag";import _ from "underscore";import { TaskStatusBadge } from "metabase/admin/tools/components/TaskStatusBadge";+import DateTime from "metabase/common/components/DateTime";import { Ellipsified } from "metabase/common/components/Ellipsified";import { SortableColumnHeader } from "metabase/common/components/ItemsTable/BaseItemsTable";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";@@ -110,15 +111,36 @@ export const TasksTable = ({<td className={CS.textBold}>{task.task}</td><td>{task.db_id ? name || t`Unknown name` : null}</td><td>{task.db_id ? engine || t`Unknown engine` : null}</td>+<td>- <Ellipsified style={{ maxWidth: 100 }}>- {task.started_at}+ <Ellipsified+ style={{ maxWidth: 180 }}+ alwaysShowTooltip+ tooltip={task.started_at}+ >+ <DateTime+ value={task.started_at}+ unit="minute"+ data-testid="started-at"+ /></Ellipsified></td><td>- <Ellipsified style={{ maxWidth: 100 }}>- {task.ended_at}- </Ellipsified>+ {task.ended_at ? (+ <Ellipsified+ style={{ maxWidth: 180 }}+ alwaysShowTooltip={Boolean(task.ended_at)}+ tooltip={task.ended_at}+ >+ <DateTime+ value={task.ended_at}+ unit="minute"+ data-testid="ended-at"+ />+ </Ellipsified>+ ) : (+ "—"+ )}</td><td>{task.duration}</td><td>diff --git a/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.tsx b/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.tsxindex 5b63757bcc9..79396179ec4 100644--- a/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.tsx@@ -5,12 +5,24 @@ import { t } from "ttag";import { SettingsSection } from "metabase/admin/components/SettingsSection";import { useGetTaskRunQuery } from "metabase/api";+import { CopyButton } from "metabase/common/components/CopyButton";+import DateTime from "metabase/common/components/DateTime";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";import AdminS from "metabase/css/admin.module.css";import CS from "metabase/css/core/index.css";import { useDispatch } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";-import { Anchor, Box, Flex, Grid, Icon, Stack, Text, Title } from "metabase/ui";+import {+ Anchor,+ Box,+ Flex,+ Grid,+ Icon,+ Stack,+ Text,+ Title,+ Tooltip,+} from "metabase/ui";import type { Task } from "metabase-types/api";import {@@ -49,10 +61,10 @@ export const TaskRunDetailsPage = ({ params }: TaskRunDetailsPageProps) => {</Link></Flex>- <Grid mt="md">+ <Grid><Grid.Col span={{ base: 12, lg: "content" }} maw="50%">- <Title order={3}>{t`Run details`}</Title>- <Stack gap="xs" mt="sm">+ <Title order={3} mb="md">{t`Run details`}</Title>+ <Stack gap="sm"><Flex gap="md"><Text fw="bold" w={120}>{t`ID`}</Text><Text>{taskRun.id}</Text>@@ -84,11 +96,31 @@ export const TaskRunDetailsPage = ({ params }: TaskRunDetailsPageProps) => {</Flex><Flex gap="md"><Text fw="bold" w={120}>{t`Started at`}</Text>- <Text>{taskRun.started_at}</Text>+ <Tooltip label={taskRun.started_at}>+ <DateTime+ value={taskRun.started_at}+ unit="minute"+ data-testid="started-at"+ />+ </Tooltip>+ <CopyButton value={taskRun.started_at} /></Flex><Flex gap="md"><Text fw="bold" w={120}>{t`Ended at`}</Text>- <Text>{taskRun.ended_at ?? "—"}</Text>+ {taskRun.ended_at ? (+ <>+ <Tooltip label={taskRun.ended_at}>+ <DateTime+ value={taskRun.ended_at}+ unit="minute"+ data-testid="ended-at"+ />+ </Tooltip>+ <CopyButton value={taskRun.ended_at} />+ </>+ ) : (+ "—"+ )}</Flex><Flex gap="md"><Text fw="bold" w={120}>{t`Task count`}</Text>@@ -98,7 +130,7 @@ export const TaskRunDetailsPage = ({ params }: TaskRunDetailsPageProps) => {</Grid.Col><Grid.Col span={{ base: 12, lg: "auto" }}>- <Title order={3}>{t`Associated tasks`}</Title>+ <Title order={3} mb="md">{t`Associated tasks`}</Title><tableclassName={cx(AdminS.ContentTable)}data-testid="task-run-tasks-table"diff --git a/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.unit.spec.tsx b/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.unit.spec.tsxnew file mode 100644index 00000000000..02f4ea83c5a--- /dev/null+++ b/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.unit.spec.tsx@@ -0,0 +1,120 @@+import { useClipboard } from "@mantine/hooks";+import userEvent from "@testing-library/user-event";+import { Route } from "react-router";++import { setupTaskRunEndpoint } from "__support__/server-mocks";+import {+ renderWithProviders,+ screen,+ waitForLoaderToBeRemoved,+ within,+} from "__support__/ui";+import * as Urls from "metabase/lib/urls";+import type { TaskRunExtended } from "metabase-types/api";+import { createMockTaskRunExtended } from "metabase-types/api/mocks";++import { TaskRunDetailsPage } from "./TaskRunDetailsPage";++jest.mock("@mantine/hooks", () => ({+ ...jest.requireActual("@mantine/hooks"),+ useClipboard: jest.fn(),+}));++const mockUseClipboard = useClipboard as jest.Mock;++const PATHNAME = `${Urls.adminToolsTasksRuns()}/:runId`;++interface SetupOpts {+ taskRun?: TaskRunExtended;+}++const setup = ({ taskRun = createMockTaskRunExtended() }: SetupOpts = {}) => {+ setupTaskRunEndpoint(taskRun);++ return renderWithProviders(+ <Route path={PATHNAME} component={TaskRunDetailsPage} />,+ {+ initialRoute: Urls.adminToolsTaskRunDetails(taskRun.id),+ withRouter: true,+ },+ );+};++describe("TaskRunDetailsPage", () => {+ beforeEach(() => {+ mockUseClipboard.mockReturnValue({+ copy: jest.fn(),+ copied: false,+ reset: jest.fn(),+ error: null,+ });+ });++ it("should display formatted datetime for started_at and ended_at", async () => {+ const taskRun = createMockTaskRunExtended({+ started_at: "2023-03-04T01:45:26.005475-08:00",+ ended_at: "2023-03-04T01:46:26.518597-08:00",+ });++ setup({ taskRun });++ await waitForLoaderToBeRemoved();++ const startedAtElement = screen.getByTestId("started-at");+ const endedAtElement = screen.getByTestId("ended-at");+ expect(startedAtElement).toHaveTextContent("March 4, 2023, 1:45 AM");+ expect(endedAtElement).toHaveTextContent("March 4, 2023, 1:46 AM");+ });++ it("should show raw ISO timestamp in tooltip on hover", async () => {+ const rawTimestamp = "2023-03-04T01:45:26.005475-08:00";+ const taskRun = createMockTaskRunExtended({+ started_at: rawTimestamp,+ ended_at: "2023-03-04T01:46:26.518597-08:00",+ });++ setup({ taskRun });++ await waitForLoaderToBeRemoved();++ const startedAtElement = screen.getByTestId("started-at");+ await userEvent.hover(startedAtElement);++ expect(await screen.findByRole("tooltip")).toHaveTextContent(rawTimestamp);+ });++ it("should copy raw ISO timestamp to clipboard when clicking copy button", async () => {+ const copyMock = jest.fn();+ mockUseClipboard.mockReturnValue({+ copy: copyMock,+ copied: false,+ reset: jest.fn(),+ error: null,+ });++ const startedAt = "2023-03-04T01:45:26.005475-08:00";+ const endedAt = "2023-03-04T01:46:26.518597-08:00";+ const taskRun = createMockTaskRunExtended({+ started_at: startedAt,+ ended_at: endedAt,+ });++ setup({ taskRun });++ await waitForLoaderToBeRemoved();++ const copyButtons = screen.getAllByTestId("copy-button");++ const startedAtCopyIcon = within(copyButtons[0]).getByRole("img", {+ name: "copy icon",+ });+ await userEvent.click(startedAtCopyIcon);+ expect(copyMock).toHaveBeenCalledWith(startedAt);++ const endedAtCopyIcon = within(copyButtons[1]).getByRole("img", {+ name: "copy icon",+ });+ await userEvent.click(endedAtCopyIcon);+ expect(copyMock).toHaveBeenCalledWith(endedAt);+ });+});diff --git a/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsPage.unit.spec.tsx b/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsPage.unit.spec.tsxnew file mode 100644index 00000000000..9f6a1877955--- /dev/null+++ b/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsPage.unit.spec.tsx@@ -0,0 +1,96 @@+import userEvent from "@testing-library/user-event";+import fetchMock from "fetch-mock";+import { Route } from "react-router";++import { setupTaskRunsEndpoints } from "__support__/server-mocks";+import {+ renderWithProviders,+ screen,+ waitForLoaderToBeRemoved,+} from "__support__/ui";+import * as Urls from "metabase/lib/urls";+import type { ListTaskRunsResponse } from "metabase-types/api";+import { createMockTaskRun } from "metabase-types/api/mocks";++import { TaskRunsPage } from "./TaskRunsPage";++const PATHNAME = Urls.adminToolsTasksRuns();++interface SetupOpts {+ taskRunsResponse?: ListTaskRunsResponse;+ error?: boolean;+}++const setup = ({+ taskRunsResponse = createMockTaskRunsResponse(),+ error,+}: SetupOpts = {}) => {+ if (error) {+ fetchMock.get("path:/api/task/runs", { status: 500 });+ } else {+ setupTaskRunsEndpoints(taskRunsResponse);+ }++ return renderWithProviders(+ <Route path={PATHNAME} component={TaskRunsPage} />,+ {+ initialRoute: PATHNAME,+ withRouter: true,+ },+ );+};++describe("TaskRunsPage", () => {+ it("should display formatted datetime for started_at and ended_at", async () => {+ setup({+ taskRunsResponse: createMockTaskRunsResponse({+ data: [+ createMockTaskRun({+ started_at: "2023-03-04T01:45:26.005475-08:00",+ ended_at: "2023-03-04T01:46:26.518597-08:00",+ }),+ ],+ }),+ });++ await waitForLoaderToBeRemoved();++ const startedAtElement = screen.getByTestId("started-at");+ const endedAtElement = screen.getByTestId("ended-at");+ expect(startedAtElement).toHaveTextContent("March 4, 2023, 1:45 AM");+ expect(endedAtElement).toHaveTextContent("March 4, 2023, 1:46 AM");+ });++ it("should show raw ISO timestamp in tooltip on hover", async () => {+ const rawTimestamp = "2023-03-04T01:45:26.005475-08:00";+ setup({+ taskRunsResponse: createMockTaskRunsResponse({+ data: [+ createMockTaskRun({+ started_at: rawTimestamp,+ ended_at: "2023-03-04T01:46:26.518597-08:00",+ }),+ ],+ }),+ });++ await waitForLoaderToBeRemoved();++ const startedAtElement = screen.getByTestId("started-at");+ await userEvent.hover(startedAtElement);++ expect(await screen.findByRole("tooltip")).toHaveTextContent(rawTimestamp);+ });+});++function createMockTaskRunsResponse(+ response?: Partial<ListTaskRunsResponse>,+): ListTaskRunsResponse {+ return {+ data: [],+ limit: 0,+ offset: 0,+ total: 0,+ ...response,+ };+}diff --git a/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsTable.tsx b/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsTable.tsxindex 8c19febd597..d26bfd546c7 100644--- a/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsTable.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsTable.tsx@@ -2,6 +2,7 @@ import cx from "classnames";import { push } from "react-router-redux";import { t } from "ttag";+import DateTime from "metabase/common/components/DateTime";import { Ellipsified } from "metabase/common/components/Ellipsified";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";import AdminS from "metabase/css/admin.module.css";@@ -86,14 +87,33 @@ export const TaskRunsTable = ({</Ellipsified></td><td>- <Ellipsified style={{ maxWidth: 150 }}>- {taskRun.started_at}+ <Ellipsified+ style={{ maxWidth: 180 }}+ alwaysShowTooltip+ tooltip={taskRun.started_at}+ >+ <DateTime+ value={taskRun.started_at}+ unit="minute"+ data-testid="started-at"+ /></Ellipsified></td><td>- <Ellipsified style={{ maxWidth: 150 }}>- {taskRun.ended_at}- </Ellipsified>+ {taskRun.ended_at ? (+ <Ellipsified+ style={{ maxWidth: 180 }}+ tooltip={taskRun.ended_at}+ >+ <DateTime+ value={taskRun.ended_at}+ unit="minute"+ data-testid="ended-at"+ />+ </Ellipsified>+ ) : (+ "—"+ )}</td><td><TaskRunStatusBadge taskRun={taskRun} />diff --git a/frontend/test/__support__/server-mocks/task.ts b/frontend/test/__support__/server-mocks/task.tsindex c19bcb467d2..758709d08fa 100644--- a/frontend/test/__support__/server-mocks/task.ts+++ b/frontend/test/__support__/server-mocks/task.ts@@ -1,6 +1,11 @@import fetchMock, { type UserRouteConfig } from "fetch-mock";-import type { ListTasksResponse, Task } from "metabase-types/api";+import type {+ ListTaskRunsResponse,+ ListTasksResponse,+ Task,+ TaskRunExtended,+} from "metabase-types/api";export function setupTasksEndpoints(response: ListTasksResponse,@@ -20,3 +25,18 @@ export function setupUniqueTasksEndpoint() {fetchMock.get(`path:/api/task/unique-tasks`, tasks, options);}++export function setupTaskRunsEndpoints(+ response: ListTaskRunsResponse,+ options?: UserRouteConfig,+) {+ fetchMock.get("path:/api/task/runs", response, options);+ fetchMock.get("path:/api/task/runs/entities", []);+}++export function setupTaskRunEndpoint(+ taskRun: TaskRunExtended,+ options?: UserRouteConfig,+) {+ fetchMock.get(`path:/api/task/runs/${taskRun.id}`, taskRun, options);+}