Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Skip the auto minor release when a minor or gold release shipped this week (#85571)

Chris Vandoodewaarde3101b840a66
diff --git a/.github/workflows/schedule-minor.yml b/.github/workflows/schedule-minor.yml
index 4a1b36c5103..e2596d78f5b 100644
--- a/.github/workflows/schedule-minor.yml
+++ b/.github/workflows/schedule-minor.yml
@@ -26,20 +26,53 @@ jobs:
env:
AWS_S3_STATIC_BUCKET: ${{ vars.AWS_S3_STATIC_BUCKET }}
AWS_REGION: ${{ vars.AWS_REGION }}
+ SLACK_RELEASE_CHANNEL: ${{ vars.SLACK_RELEASE_CHANNEL }}
+ SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+ RECENT_MINOR_WINDOW_DAYS: 3
with:
script: | # js
// Every supported major line gets regular minor releases so the
// branches we backport into don't go stale. Support is read from
- // `major_version_support` in version-info.json via getSupportedMajors —
+ // `major_version_support` in version-info.json via getSupportedMajorVersions —
// the same source the auto-backport workflow uses to pick its targets.
- const { getSupportedMajors } = require('${{ github.workspace }}/release/dist/index.cjs');
+ const {
+ getOssVersionInfo,
+ getSupportedMajorVersions,
+ hasRecentMinorReleaseIn,
+ sendSlackMessage,
+ } = require('${{ github.workspace }}/release/dist/index.cjs');
- const majors = await getSupportedMajors();
+ const rawWindowDays = process.env.RECENT_MINOR_WINDOW_DAYS;
+ const windowDays = Number(rawWindowDays);
+ if (!Number.isInteger(windowDays) || windowDays < 1) {
+ core.setFailed(`RECENT_MINOR_WINDOW_DAYS must be a whole number of 1 or more, got "${rawWindowDays}"`);
+ return;
+ }
+
+ let versionInfo;
+ let majors;
+ try {
+ versionInfo = await getOssVersionInfo();
+ majors = getSupportedMajorVersions(versionInfo);
+ } catch (error) {
+ core.setFailed(`Could not read the supported majors from version-info.json: ${error.message}`);
+ return;
+ }
console.log('supported majors', majors);
// release-auto.yml releases one major per dispatch.
- await Promise.all(majors.map(version =>
- github.rest.actions.createWorkflowDispatch({
+ const results = await Promise.allSettled(majors.map(async version => {
+ if (hasRecentMinorReleaseIn(versionInfo, version, windowDays)) {
+ const message = `Minor version already released in the last ${windowDays} days, skipping automatic minor release for v${version}`;
+ console.log(message);
+ await sendSlackMessage({
+ channelName: '${{ vars.SLACK_RELEASE_CHANNEL }}',
+ message,
+ }).catch(error => core.warning(`Could not send the skip message for v${version}: ${error.message}`));
+ return 'skipped';
+ }
+
+ await github.rest.actions.createWorkflowDispatch({
owner: context.repo.owner,
repo: context.repo.repo,
workflow_id: 'release-auto.yml',
@@ -48,5 +81,36 @@ jobs:
version: String(version),
kind: 'minor',
},
- }).catch(console.error)
- ));
+ });
+ return 'dispatched';
+ }));
+
+ const failures = [];
+ results.forEach((result, index) => {
+ const version = majors[index];
+ if (result.status === 'fulfilled') {
+ console.log(`v${version}: ${result.value}`);
+ } else {
+ failures.push(`v${version}: ${result.reason?.message ?? result.reason}`);
+ }
+ });
+
+ if (failures.length > 0) {
+ core.setFailed(`Auto-minor release was not scheduled for:\n${failures.join('\n')}`);
+ }
+ - name: Notify Slack of failure
+ if: failure()
+ uses: actions/github-script@v9
+ env:
+ SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+ with:
+ script: | # js
+ const { sendSlackMessage, mentionSlackTeam } = require('${{ github.workspace }}/release/dist/index.cjs');
+
+ const team = mentionSlackTeam('release-managers');
+ const runUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;
+
+ await sendSlackMessage({
+ channelName: '${{ vars.SLACK_RELEASE_CHANNEL }}',
+ message: `:rotating_light: Scheduling the automatic minor releases failed. Start the minor releases manually if necessary — see <${runUrl}|run logs> ${team}`,
+ }).catch(console.error);
diff --git a/release/src/version-info.ts b/release/src/version-info.ts
index 91bf3ef9e58..db80fb322e8 100644
--- a/release/src/version-info.ts
+++ b/release/src/version-info.ts
@@ -12,6 +12,7 @@ import {
getVersionType,
isEnterpriseVersion,
isPatchVersion,
+ isPreReleaseVersion,
} from "./version-helpers";
const generateVersionInfo = ({ version }: { version: string }): VersionInfo => {
@@ -171,6 +172,48 @@ export async function getSupportedMajors(
return getSupportedMajorVersions(versionInfo, today);
}
+const subtractDays = (day: string, days: number) => {
+ const date = new Date(`${day}T00:00:00Z`);
+ date.setUTCDate(date.getUTCDate() - days);
+ return date.toISOString().slice(0, 10);
+};
+
+export const hasRecentMinorReleaseIn = (
+ versionInfo: VersionInfoFile,
+ majorVersion: number,
+ windowDays: number,
+ today: string = new Date().toISOString().slice(0, 10),
+): boolean => {
+ if (!Number.isInteger(windowDays) || windowDays < 0) {
+ throw new Error(`Invalid window in days: ${windowDays}`);
+ }
+
+ const windowStart = subtractDays(today, windowDays - 1);
+
+ return [versionInfo.latest, ...(versionInfo.older ?? [])].some(
+ (info) =>
+ !!info &&
+ ["major", "minor"].includes(getVersionType(info.version)) &&
+ !isPreReleaseVersion(info.version) &&
+ getMajorVersion(info.version) === String(majorVersion) &&
+ info.released >= windowStart &&
+ info.released <= today,
+ );
+};
+
+export async function getOssVersionInfo(): Promise<VersionInfoFile> {
+ const url = getVersionInfoUrl("v0");
+ const response = await fetch(url);
+
+ if (!response.ok) {
+ throw new Error(
+ `Could not fetch ${url}: ${response.status} ${response.statusText}`,
+ );
+ }
+
+ return (await response.json()) as VersionInfoFile;
+}
+
// for promoting a released version to `latest` in version-info.json
export async function updateVersionInfoLatest({
newVersion,
diff --git a/release/src/version-info.unit.spec.ts b/release/src/version-info.unit.spec.ts
index 96bf61da003..81283dd9146 100644
--- a/release/src/version-info.unit.spec.ts
+++ b/release/src/version-info.unit.spec.ts
@@ -3,9 +3,11 @@ import fetch from "node-fetch";
import type { VersionInfoFile } from "./types";
import {
generateVersionInfoJson,
+ getOssVersionInfo,
getSupportedMajorVersions,
getSupportedMajors,
getVersionInfoUrl,
+ hasRecentMinorReleaseIn,
isLtsVersion,
updateVersionInfoLatest,
updateVersionInfoLatestJson,
@@ -436,6 +438,156 @@ describe("version-info", () => {
});
});
+ describe("hasRecentMinorReleaseIn", () => {
+ const release = (version: string, released: string) => ({
+ version,
+ released,
+ patch: true,
+ highlights: [],
+ });
+
+ const fileWith = (...releases: ReturnType<typeof release>[]) =>
+ ({
+ latest: releases[0],
+ older: releases.slice(1),
+ }) as VersionInfoFile;
+
+ it("skips v0.66.2 on Tuesday when v0.66.1 shipped on Monday", () => {
+ const versionInfo = fileWith(
+ release("v0.66.1", "2026-11-02"),
+ release("v0.66.0", "2026-10-26"),
+ );
+
+ expect(hasRecentMinorReleaseIn(versionInfo, 66, 3, "2026-11-03")).toBe(
+ true,
+ );
+ });
+
+ it("includes the first and last day of the window", () => {
+ expect(
+ hasRecentMinorReleaseIn(
+ fileWith(release("v0.65.2", "2026-11-01")),
+ 65,
+ 3,
+ "2026-11-03",
+ ),
+ ).toBe(true);
+ expect(
+ hasRecentMinorReleaseIn(
+ fileWith(release("v0.65.2", "2026-11-03")),
+ 65,
+ 3,
+ "2026-11-03",
+ ),
+ ).toBe(true);
+ });
+
+ it("ignores releases before the window", () => {
+ const versionInfo = fileWith(release("v0.65.2", "2026-10-31"));
+
+ expect(hasRecentMinorReleaseIn(versionInfo, 65, 3, "2026-11-03")).toBe(
+ false,
+ );
+ });
+
+ it("uses the window size it is given", () => {
+ const versionInfo = fileWith(release("v0.65.2", "2026-10-28"));
+
+ expect(hasRecentMinorReleaseIn(versionInfo, 65, 3, "2026-11-03")).toBe(
+ false,
+ );
+ expect(hasRecentMinorReleaseIn(versionInfo, 65, 7, "2026-11-03")).toBe(
+ true,
+ );
+ });
+
+ it("finds releases in the older list", () => {
+ const versionInfo = fileWith(
+ release("v0.66.1", "2026-10-27"),
+ release("v0.58.38", "2026-10-26"),
+ );
+
+ expect(hasRecentMinorReleaseIn(versionInfo, 58, 3, "2026-10-27")).toBe(
+ true,
+ );
+ });
+
+ it("ignores other majors", () => {
+ const versionInfo = fileWith(release("v0.65.2", "2026-10-27"));
+
+ expect(hasRecentMinorReleaseIn(versionInfo, 64, 3, "2026-10-27")).toBe(
+ false,
+ );
+ });
+
+ it("counts a gold release", () => {
+ const versionInfo = fileWith(release("v0.66.0", "2026-10-26"));
+
+ expect(hasRecentMinorReleaseIn(versionInfo, 66, 3, "2026-10-27")).toBe(
+ true,
+ );
+ });
+
+ it("ignores patches and pre-releases", () => {
+ const versionInfo = fileWith(
+ release("v0.66.0-beta", "2026-10-26"),
+ release("v0.65.2.1", "2026-10-27"),
+ release("v0.65.3-rc1", "2026-10-27"),
+ );
+
+ expect(hasRecentMinorReleaseIn(versionInfo, 66, 3, "2026-10-27")).toBe(
+ false,
+ );
+ expect(hasRecentMinorReleaseIn(versionInfo, 65, 3, "2026-10-27")).toBe(
+ false,
+ );
+ });
+
+ it("throws on an invalid window", () => {
+ const versionInfo = fileWith(release("v0.65.2", "2026-10-27"));
+
+ expect(() =>
+ hasRecentMinorReleaseIn(versionInfo, 65, NaN, "2026-10-27"),
+ ).toThrow(/Invalid window/);
+ expect(() =>
+ hasRecentMinorReleaseIn(versionInfo, 65, -1, "2026-10-27"),
+ ).toThrow(/Invalid window/);
+ });
+ });
+
+ describe("getOssVersionInfo", () => {
+ beforeEach(() => {
+ process.env.AWS_S3_STATIC_BUCKET = "my.metabase.com";
+ process.env.AWS_REGION = "us-north-9";
+ mockFetch.mockReset();
+ });
+
+ it("fetches the OSS version-info.json", async () => {
+ const versionInfo = { latest: {}, older: [] };
+ mockFetch.mockResolvedValue({
+ ok: true,
+ json: async () => versionInfo,
+ } as Awaited<ReturnType<typeof fetch>>);
+
+ expect(await getOssVersionInfo()).toEqual(versionInfo);
+ expect(mockFetch).toHaveBeenCalledWith(
+ "http://my.metabase.com.s3.us-north-9.amazonaws.com/version-info.json",
+ );
+ });
+
+ it("throws a clear error when the fetch fails", async () => {
+ mockFetch.mockResolvedValue({
+ ok: false,
+ status: 403,
+ statusText: "Forbidden",
+ } as Awaited<ReturnType<typeof fetch>>);
+
+ await expect(getOssVersionInfo()).rejects.toThrow(
+ "Could not fetch http://my.metabase.com.s3.us-north-9.amazonaws.com/version-info.json: 403 Forbidden",
+ );
+ });
+ });
+
describe("isLtsVersion", () => {
const majorVersionSupport = [
{ major: 55, released: "2025-04-15", lts: true, eol: "2027-06-01" },